wallet: Refactor WalletRescanReserver to use wallet reference #18601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
changed the title
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
This was referenced Apr 12, 2020
promag
force-pushed
the
2020-04-walletrescanreserver
branch
from
8566545 to
8f1b825
Compare
Contributor
Author
|
@MarcoFalke fixed. |
Member
|
ACK 8f1b82561cae2fcc78bce6ca7bab81cd9561cf14 |
Member
|
@promag Are you still working on this? If not, it can be closed. |
promag
force-pushed
the
2020-04-walletrescanreserver
branch
from
8f1b825 to
fc289b7
Compare
Contributor
Author
|
@MarcoFalke rebased. |
Member
|
ACK fc289b7 |
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 22, 2020
Summary: Backport of Core [[bitcoin/bitcoin#18601 | PR18601]] Test Plan: ninja all check-all Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7519
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple refactor to
WalletRescanReserverto use wallet reference instead of pointer.Complements #18259.