bench: Remove requirement that all benches use same testing setup #18575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
added 2 commits
April 17, 2020 10:19
This is a refactor, since they are aliases for each other
maflcko
force-pushed
the
2004-benchNoGlobalReg
branch
from
fa89091 to
fa1fdb0
Compare
Member
Author
|
Rebased, diff is smaller and easier to review now that #18673 has been merged |
This was referenced Apr 20, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 23, 2020
…ame testing setup fa1fdb0 bench: Replace ::mempool globabl with test_setup.mempool (MarcoFalke) fab1170 bench: Remove requirement that all benches use RegTestingSetup (MarcoFalke) Pull request description: The benches have always set up one global testing setup. This makes it hard to pick no testing setup at all or one with different params. Fix this by removing any global state setup from the main `bench.cpp` and leave the setup to each individual bench. One reason to have one global testing setup is to set the datadir location to a tempdir to avoid reading or writing in the default datadir location. But bitcoin#13687 should prevent this already. Top commit has no ACKs. Tree-SHA512: 7c98aea7725a20f4b9225221f4279b9e9f7257ed5c14712ad01ea80d87c3b0fed760b40f413892498bbb354a917ee02d4c575cbe8423a403b86755e8ee11f33b
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 22, 2021
Summary: > The benches have always set up one global testing setup. This makes it hard to pick no testing setup at all or one with different params. > > Fix this by removing any global state setup from the main bench.cpp and leave the setup to each individual bench. > > One reason to have one global testing setup is to set the datadir location to a tempdir to avoid reading or writing in the default datadir location. But #13687 should prevent this already. Commit fab117096446ab63d1f38c1ef6edbc94a5d4ab52 > bench: Remove requirement that all benches use RegTestingSetup Commit fa1fdb02fccd0f670f7b08ee61c249f04d0db17f > bench: Replace ::mempool globabl with test_setup.mempool > This is a refactor, since they are aliases for each other This is a backport of Core [[bitcoin/bitcoin#18575 | PR18575]] The changes in `verify_script.cpp` are not relevant to ABC. Test Plan: ninja all && src/bench/bitcoin-bench Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D9040
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benches have always set up one global testing setup. This makes it hard to pick no testing setup at all or one with different params.
Fix this by removing any global state setup from the main
bench.cppand leave the setup to each individual bench.One reason to have one global testing setup is to set the datadir location to a tempdir to avoid reading or writing in the default datadir location. But #13687 should prevent this already.