Skip to content

Conversation

@practicalswift
Copy link
Contributor

Includes:

tests: Add fuzzing harness for FeeFilterRounder
tests: Add fuzzing harness for classes/functions in checkqueue.h
tests: Add fuzzing harness for classes/functions in cuckoocache.h
tests: Add coverage of {,Incremental}DynamicUsage(const std::set<X, Y>& s) to existing fuzzer
tests: Add coverage of GetVirtualTransactionSize(...) to existing fuzzer
tests: Add fuzzing harness for AdditionOverflow(...)

See doc/fuzzing.md for information on how to fuzz Bitcoin Core.

@maflcko
Copy link
Member

maflcko commented Apr 8, 2020

ACK 283bd72

@maflcko maflcko merged commit bfef72d into bitcoin:master Apr 8, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 13, 2020
…ns in policy/fees.h, checkqueue.h and cuckoocache.h. Add fuzzing coverage.

283bd72 tests: Add coverage of {,Incremental}DynamicUsage(const std::set<X, Y>& s) to existing fuzzer (practicalswift)
bf76000 tests: Add fuzzing harness for classes/functions in cuckoocache.h (practicalswift)
57890b2 tests: Add fuzzing harness for classes/functions in checkqueue.h (practicalswift)
2df5701 tests: Add coverage of GetVirtualTransactionSize(...) to existing fuzzer (practicalswift)
7b9a2dc tests: Add fuzzing harness for AdditionOverflow(...) (practicalswift)
44fb2a5 tests: Add fuzzing harness for FeeFilterRounder (practicalswift)

Pull request description:

  Includes:

  ```
  tests: Add fuzzing harness for FeeFilterRounder
  tests: Add fuzzing harness for classes/functions in checkqueue.h
  tests: Add fuzzing harness for classes/functions in cuckoocache.h
  tests: Add coverage of {,Incremental}DynamicUsage(const std::set<X, Y>& s) to existing fuzzer
  tests: Add coverage of GetVirtualTransactionSize(...) to existing fuzzer
  tests: Add fuzzing harness for AdditionOverflow(...)
  ```

  See [`doc/fuzzing.md`](https://github.com/bitcoin/bitcoin/blob/master/doc/fuzzing.md) for information on how to fuzz Bitcoin Core.

ACKs for top commit:
  MarcoFalke:
    ACK 283bd72

Tree-SHA512: 2361edfb5c47741b22d9fb996836c5250c5a26bc5e956039ea6a0c55ba2d36c78f241d66f85bc02f5b85b9b83d5fde56a5c4702b9d1b7ac4a9a3ae391ca79eaa
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 5, 2020
Summary:
This is a backport of Core [[bitcoin/bitcoin#17634 | PR17634]] [2/2]
bitcoin/bitcoin@98fbd1c

Depends on D8281

The header `algorithm` is needed in `cuckoocache.h` for `std::find` (see [[bitcoin/bitcoin#18565 | PR18565]]). I'm not sure how Core got away with removing it for multiple months, for us it cause a compiler error.

Test Plan: `ninja && ninja check`

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D8282
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 20, 2021
…checkqueue.h and cuckoocache.h. Add fuzzing coverage.

Summary:
```
Add fuzzing harness for FeeFilterRounder
Add fuzzing harness for classes/functions in checkqueue.h
Add fuzzing harness for classes/functions in cuckoocache.h
Add coverage of {,Incremental}DynamicUsage(const std::set<X, Y>&s) to existing fuzzer
Add coverage of GetVirtualTransactionSize(...) to existing fuzzer
Add fuzzing harness for AdditionOverflow(...)
```

Backport of core [[bitcoin/bitcoin#18565 | PR18565]].

Our cuckoocache requires a class as key since D4643.

Test Plan:
  ninja bitcoin-fuzzers
  ./test/fuzz/test_runner.py <path_to_corpus>

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8987
@practicalswift practicalswift deleted the fuzzers-2020-04-07 branch April 10, 2021 19:40
kwvg added a commit to kwvg/dash that referenced this pull request Jul 6, 2022
…heckqueue.h and cuckoocache.h. Add fuzzing coverage.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants