test: refactor rpc_signrawtransaction and add logging #18545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
force-pushed
the
refactor-rpc_signrawtransaction
branch
from
66e9be8 to
5390ee1
Compare
theStack
reviewed
Apr 10, 2020
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
ACK modulo nits
Deduplication and better logging are always good 👍
For other reviewers, I suggest looking at the refactor diff with a larger number of lines of context via the -U option (at a first glance it looks like the signing part has been removed, as one doesn't see the whole newly introduced function verify_txn_with_witness_script() to the end), e.g.
git show -U20 269b664ced
to see what is distinct in each test.
jonatack
force-pushed
the
refactor-rpc_signrawtransaction
branch
from
5390ee1 to
9cdddae
Compare
Member
Author
|
Thanks for reviewing, @theStack. I've updated with both of your suggestions. |
theStack
approved these changes
Apr 12, 2020
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 15, 2021
Summary: This is a partial backport of Core [[bitcoin/bitcoin#18545 | PR18545]] bitcoin/bitcoin@9cdddae Test Plan: test/functional/test_runner.py rpc_signrawtransaction Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D8925
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to #18484, the new tests are good but bury the one non-duplicate line in each test that sets the witness script, and there is no logging in the testfile. This PR makes it easy to see what is unique to each of the new tests and adds logging.