Add fuzzer version of randomized prevector test #18529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The fuzz tests are not shipped on our website, nor are they run as part of Concept ACK on the new fuzzing harness. |
maflcko
reviewed
Apr 5, 2020
maflcko
reviewed
Apr 5, 2020
sipa
force-pushed
the
202004_prevector_fuzz
branch
from
a8c3f23 to
b1d24d1
Compare
Member
Author
|
@MarcoFalke Rebased, addressed your comments, and removed removal of the existing unit test (I've duplicated instead of creating a common shared class, as I expect the two to diverge - the existing test is much more suited as an approach for fuzzing, while we may want a few static cases instead as unit tests). |
sipa
changed the title
Member
|
ACK b1d24d1 🍬 Show signature and timestampSignature: |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Apr 13, 2020
b1d24d1 Reorder the test instructions by number (Pieter Wuille) c2ccadc Merge and generalize case 3 and case 6 (Pieter Wuille) 402ad5a Only run sanity check once at the end (Pieter Wuille) eda8309 Assert immediately rather than caching failure (Pieter Wuille) 5560845 Make a fuzzer-based copy of the prevector randomized test (Pieter Wuille) Pull request description: The current prevector test effectively randomly generates a number of operations to perform on a prevector and a normal vector, and checks consistency between the two. By converting this into a fuzzer the operations can be targetted rather than random. ACKs for top commit: MarcoFalke: ACK b1d24d1 🍬 Tree-SHA512: 2b5c62abcd5fee94f42db03400531484d98c59e7f4308e0e683c61aabcd9ce42f85c5d058d2d5e7f8221124f71d2112b6a5f3c80e5d0fdae265a70647747e92f
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 21, 2021
Summary: ``` The current prevector test effectively randomly generates a number of operations to perform on a prevector and a normal vector, and checks consistency between the two. By converting this into a fuzzer the operations can be targetted rather than random. ``` Backport of core [[bitcoin/bitcoin#18529 | PR18529]]. Test Plan: ninja bitcoin-fuzzers ./src/test/fuzz/prevector <path_to_corpus> Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D9003
maflcko
reviewed
Jul 16, 2021
| test.resize(std::max(0, std::min(30, (int)test.size() + prov.ConsumeIntegralInRange<int>(0, 4) - 2))); | ||
| break; | ||
| case 2: | ||
| test.insert(prov.ConsumeIntegralInRange<size_t>(0, test.size()), 1 + prov.ConsumeBool(), prov.ConsumeIntegral<int>()); |
Member
There was a problem hiding this comment.
post-merge question: Is there a reason to limit the number of elements inserted in this case to 1 or 2?
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 6, 2022
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jul 12, 2022
backport: bitcoin#18417, bitcoin#18521, bitcoin#18529, bitcoin#18176, bitcoin#18423, bitcoin#17926, bitcoin#18353, bitcoin#18407, bitcoin#18455, bitcoin#18565, bitcoin#18867 (fuzzing harness backports: part 2)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current prevector test effectively randomly generates a number of operations to perform on a prevector and a normal vector, and checks consistency between the two.
By converting this into a fuzzer the operations can be targetted rather than random.