Skip to content

test: Check that calling walletpasshprase does not freeze the node #18507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
maflcko wants to merge 1 commit into from
Closed

test: Check that calling walletpasshprase does not freeze the node #18507

maflcko wants to merge 1 commit into from

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Apr 2, 2020

No description provided.

@maflcko maflcko added this to the 0.20.0 milestone Apr 2, 2020
This was referenced Apr 2, 2020
Closed
Merged
jonatack
jonatack reviewed Apr 2, 2020
View reviewed changes
Copy link
Member

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Currently timing out after 60 seconds but I suppose this is for testing #18487.

test/functional/wallet_encryption.py Outdated
Copy link
Member

@jonatack jonatack Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/walletpasshprase/walletpassphrase/

@jonatack
Copy link
Member

jonatack commented Apr 2, 2020

This passes on #18487, but am seeing another error about 20% of the time:

2020-04-02T16:05:38.667000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/test_framework.py", line 112, in main
    self.run_test()
  File "test/functional/wallet_encryption.py", line 131, in run_test
    assert_raises_rpc_error(-13, "Please enter the wallet passphrase with walletpassphrase first", self.nodes[0].dumpprivkey, address)
  File "/home/jon/projects/bitcoin/bitcoin/test/functional/test_framework/util.py", line 114, in assert_raises_rpc_error
    assert try_rpc(code, message, fun, *args, **kwds), "No exception raised"
AssertionError: No exception raised

@maflcko maflcko force-pushed the 2004-qaWalletFreeze branch from fa8e523 to faae3f9 Compare April 2, 2020 16:17
@promag
Copy link
Contributor

promag commented Apr 2, 2020

I don't think this would always fail without #18487 so it doesn't prevent a regression. Maybe we should unit test that RPCRunLater waits for event callback to finish if the call was already triggered?

@maflcko maflcko removed this from the 0.20.0 milestone Apr 2, 2020
@DrahtBot DrahtBot added the Tests label Apr 2, 2020
@maflcko maflcko closed this Apr 6, 2020
@maflcko maflcko deleted the 2004-qaWalletFreeze branch April 6, 2020 20:51
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonatack jonatack jonatack left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maflcko @jonatack @promag @DrahtBot