test: listsinceblock block height checks #18420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
tested ACK 83e1d92 |
Contributor
|
Code review 83e1d92. |
ryanofsky
approved these changes
Mar 30, 2020
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
Code review ACK 83e1d92. Nice test improvements!
re: description #18420 (comment)
This is the second commit of #17535, which adds coverage for #17437.
It's great to link to other issues, but would recommend writing PR description and that doesn't require reading other pages to understand. Would suggest starting off with something like, "This PR extends listsinceblock test to check new transaction 'blockheight' field recently added in #17437. It also cleans up code in the test function without changing or removing existing checks."
Member
Author
|
Thanks @ryanofsky for the suggestion; added it to the PR description. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 31, 2020
83e1d92 test: listsinceblock block height checks (Jon Atack) Pull request description: This is the second commit of bitcoin#17535. This PR extends a listsinceblock test to check the new transaction 'blockheight' field recently added in bitcoin#17437. It also cleans up code in the test function without changing or removing existing checks. ACKs for top commit: fjahr: tested ACK 83e1d92 ryanofsky: Code review ACK 83e1d92. Nice test improvements! Tree-SHA512: 92874b49a3bc0236500495f32dfcf683e1971ca3d4c51702c69ed4ce7dfce21273754f02f93d1243d73793701d9fdf49e14b149477cd249cbbd9e4e8d5bd49f8
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jan 13, 2021
Summary: > This PR extends a listsinceblock test to check the new transaction 'blockheight' field recently added in [[bitcoin/bitcoin#17437 | PR17437]]. It also cleans up code in the test function without changing or removing existing checks. This is a backport of Core [[bitcoin/bitcoin#18420 | PR18420]] Test Plan: `ninja && test/functional/test_runner.py wallet_listsinceblock` Reviewers: #bitcoin_abc, Fabien Reviewed By: #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8895
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second commit of #17535.
This PR extends a listsinceblock test to check the new transaction 'blockheight' field recently added in #17437. It also cleans up code in the test function without changing or removing existing checks.