-
Notifications
You must be signed in to change notification settings - Fork 38.7k
tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions #18363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0059034 to
4842115
Compare
4842115 to
c9f7527
Compare
maflcko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concept ACK, but I'll wait for @laanwj or someone else with better knowledge of this area of the code to comment.
|
FWIW: The H2O repo has a very good HTTP/1.1 seed corpus which can be used to seed this fuzzer: https://github.com/h2o/h2o/tree/master/fuzz |
c4cabbf to
8f40578
Compare
|
ACK, except for the unnecessary changes. |
|
@MarcoFalke Would you mind reviewing this PR? :) |
|
Ready for merge? :) |
|
Is the feedback addressed: #18363 (comment) ? |
8f40578 to
d8814ba
Compare
|
@MarcoFalke Dropped the mechanical |
|
I don't really have a strong background in libevent and our http server, so I'll leave this with @laanwj :) |
|
@MarcoFalke He said "ACK, except for the unnecessary changes." :) |
d8814ba to
cdfb8e7
Compare
|
@MarcoFalke Feedback addressed! Ready for merge? :) |
|
ACK cdfb8e7 |
…vent's evhttp and related functions cdfb8e7 tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions (practicalswift) Pull request description: Add fuzzing harness for `HTTPRequest`, `libevent`'s `evhttp` and related functions. ACKs for top commit: laanwj: ACK cdfb8e7 Tree-SHA512: da481afed5eb3232d3f3d0583094e56050e6234223dfcb356d8567fe0616336eb1b78c5e6821325fc9767e385e5dfaf3c96f0d35ffdb67f18d74f9a9a9464e24
…ated functions Summary: ``` Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions. ``` Backport of core [[bitcoin/bitcoin#18363 | PR18363]]. Test Plan: ninja bitcoin-fuzzers ./src/test/fuzz/http_request <path__to_corpus> This should crash fairly quickly, the fix will be part of another diff. Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Differential Revision: https://reviews.bitcoinabc.org/D9000
…evhttp and related functions
backport: bitcoin#18867, bitcoin#19247, bitcoin#19222, bitcoin#18363, bitcoin#18190, bitcoin#18393, partial bitcoin#18047, bitcoin#18314, bitcoin#19143 (fuzzing harness backports: part 3)
Add fuzzing harness for
HTTPRequest,libevent'sevhttpand related functions.