Skip to content

Conversation

@practicalswift
Copy link
Contributor

Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions.

Copy link
Member

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK, but I'll wait for @laanwj or someone else with better knowledge of this area of the code to comment.

@practicalswift
Copy link
Contributor Author

FWIW: The H2O repo has a very good HTTP/1.1 seed corpus which can be used to seed this fuzzer: https://github.com/h2o/h2o/tree/master/fuzz

@practicalswift practicalswift force-pushed the fuzzers-http_request branch 2 times, most recently from c4cabbf to 8f40578 Compare March 17, 2020 19:08
@laanwj
Copy link
Member

laanwj commented Mar 19, 2020

ACK, except for the unnecessary changes.

@bitcoin bitcoin deleted a comment from one909 Mar 23, 2020
@practicalswift
Copy link
Contributor Author

@MarcoFalke Would you mind reviewing this PR? :)

@practicalswift
Copy link
Contributor Author

Ready for merge? :)

@maflcko
Copy link
Member

maflcko commented Mar 29, 2020

Is the feedback addressed: #18363 (comment) ?

@practicalswift
Copy link
Contributor Author

practicalswift commented Mar 29, 2020

@MarcoFalke Dropped the mechanical clang-format/clang-tidy commit :) Please re-review :)

@maflcko
Copy link
Member

maflcko commented Mar 29, 2020

I don't really have a strong background in libevent and our http server, so I'll leave this with @laanwj :)

@practicalswift
Copy link
Contributor Author

@MarcoFalke He said "ACK, except for the unnecessary changes." :)

@practicalswift
Copy link
Contributor Author

@MarcoFalke Feedback addressed! Ready for merge? :)

@laanwj
Copy link
Member

laanwj commented Apr 8, 2020

ACK cdfb8e7

@maflcko maflcko merged commit 661bd5d into bitcoin:master Apr 8, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Apr 13, 2020
…vent's evhttp and related functions

cdfb8e7 tests: Add fuzzing harness for HTTPRequest, libevent's evhttp and related functions (practicalswift)

Pull request description:

  Add fuzzing harness for `HTTPRequest`, `libevent`'s `evhttp` and related functions.

ACKs for top commit:
  laanwj:
    ACK cdfb8e7

Tree-SHA512: da481afed5eb3232d3f3d0583094e56050e6234223dfcb356d8567fe0616336eb1b78c5e6821325fc9767e385e5dfaf3c96f0d35ffdb67f18d74f9a9a9464e24
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Jan 21, 2021
…ated functions

Summary:
```
Add fuzzing harness for HTTPRequest, libevent's evhttp and related
functions.
```

Backport of core [[bitcoin/bitcoin#18363 | PR18363]].

Test Plan:
  ninja bitcoin-fuzzers
  ./src/test/fuzz/http_request <path__to_corpus>
This should crash fairly quickly, the fix will be part of another diff.

Reviewers: #bitcoin_abc, PiRK

Reviewed By: #bitcoin_abc, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D9000
@practicalswift practicalswift deleted the fuzzers-http_request branch April 10, 2021 19:40
kwvg added a commit to kwvg/dash that referenced this pull request Jul 15, 2022
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Jul 17, 2022
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants