Skip to content

test: Bump timeouts to avoid valgrind failures #18345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maflcko merged 1 commit into from
Mar 15, 2020
Merged

test: Bump timeouts to avoid valgrind failures #18345

maflcko merged 1 commit into from
Mar 15, 2020

Conversation

@maflcko
Copy link
Member

@maflcko maflcko commented Mar 13, 2020 •
edited
Loading

@fanquake fanquake added the Tests label Mar 13, 2020
@practicalswift
Copy link
Contributor

practicalswift commented Mar 13, 2020

ACK faffb226dad4395a2d131d7acdd5458e039fdd74

We need MSan too for maximal protection - review beg #18288 :)

@maflcko maflcko force-pushed the 2003-qaBumpTimeoutsAgain branch from faffb22 to fa19295 Compare March 15, 2020 02:17
@practicalswift
Copy link
Contributor

practicalswift commented Mar 15, 2020

ACK fa19295

@maflcko maflcko merged commit d402c1e into bitcoin:master Mar 15, 2020
@maflcko maflcko deleted the 2003-qaBumpTimeoutsAgain branch March 15, 2020 14:18
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
deadalnix pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Nov 18, 2020
@PiRK
test: Fix intermittent error in mempool_reorg
4fa05d2 
Summary:
> Also speed up tx relay while touching the file anyway.

This should fix the intermittent error `AssertionError: Mempool sync timed out:`
If it doesn't solve the issue completely, we may also need [[bitcoin/bitcoin#17770 | PR17770]], [[bitcoin/bitcoin#18345 | PR18345]] and [[bitcoin/bitcoin#18704 | PR18704]]. These 3 PRs were previous unsuccesful attempts to solve this issue by Core, maybe they are useless or maybe they are part of the solution.

This is a backport of Core [[bitcoin/bitcoin#18752 | PR18752]]

Test Plan: `ninja && test/functional/test_runner.py mempool_reorg`

Reviewers: #bitcoin_abc, majcosta

Reviewed By: #bitcoin_abc, majcosta

Subscribers: majcosta

Differential Revision: https://reviews.bitcoinabc.org/D8436
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maflcko @practicalswift @fanquake