Skip to content

doc: Fix nit in getblockchaininfo #18344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Mar 16, 2020
Merged

doc: Fix nit in getblockchaininfo #18344

laanwj merged 1 commit into from
Mar 16, 2020

Conversation

@stevenroose
Copy link
Contributor

@stevenroose stevenroose commented Mar 13, 2020

Noticed that the statistics are not always shown.

@maflcko maflcko changed the title Fix nit in getblockchaininfo doc: Fix nit in getblockchaininfo Mar 13, 2020
promag
promag reviewed Mar 15, 2020
View reviewed changes
Copy link
Contributor

@promag promag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK fb15bfd.

Relevant code

bitcoin/src/rpc/blockchain.cpp

Lines 1151 to 1161 in 67dfd18

if (ThresholdState::STARTED == thresholdState)
{
UniValue statsUV(UniValue::VOBJ);
BIP9Stats statsStruct = VersionBitsTipStatistics(consensusParams, id);
statsUV.pushKV("period", statsStruct.period);
statsUV.pushKV("threshold", statsStruct.threshold);
statsUV.pushKV("elapsed", statsStruct.elapsed);
statsUV.pushKV("count", statsStruct.count);
statsUV.pushKV("possible", statsStruct.possible);
bip9.pushKV("statistics", statsUV);
}

@laanwj
Copy link
Member

laanwj commented Mar 16, 2020

ACK fb15bfd

@laanwj laanwj merged commit a64e5be into bitcoin:master Mar 16, 2020
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Mar 16, 2020
@laanwj
Merge bitcoin#18344: doc: Fix nit in getblockchaininfo
3a277e3 
fb15bfd Fix nit in getblockchaininfo (Steven Roose)

Pull request description:

  Noticed that the statistics are not always shown.

ACKs for top commit:
  laanwj:
    ACK fb15bfd
  promag:
    ACK fb15bfd.

Tree-SHA512: bccbfdff03107d14967f6530eec0bcada7ba8eb16c61b829119533a73f2ead742a0da6a473b7962b15e25cd685c8f155506ab16d4a95b20352d3fd1b4b0164a3
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
sidhujag pushed a commit to syscoin-core/syscoin that referenced this pull request Nov 10, 2020
@laanwj
Merge bitcoin#18344: doc: Fix nit in getblockchaininfo
c1fb0a0 
fb15bfd Fix nit in getblockchaininfo (Steven Roose)

Pull request description:

  Noticed that the statistics are not always shown.

ACKs for top commit:
  laanwj:
    ACK fb15bfd
  promag:
    ACK fb15bfd.

Tree-SHA512: bccbfdff03107d14967f6530eec0bcada7ba8eb16c61b829119533a73f2ead742a0da6a473b7962b15e25cd685c8f155506ab16d4a95b20352d3fd1b4b0164a3
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@promag promag promag left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

RPC/REST/ZMQ

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@stevenroose @laanwj @promag @fanquake