[0.19] build: Allow export of environ symbols and work around rv64 toolchain issue #18175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#17569 Rebased-From: f6e4225
fanquake
reviewed
Feb 20, 2020
Member
fanquake
left a comment
fanquake
left a comment
There was a problem hiding this comment.
Is backporting either of these really required?
The changes that necessitated f6e4225 (1025476 here) are not in the 0.19 branch.
As for eafd259, the 0.19.1rc2 RISCV binaries still have GNU_STACK marked as RW, because we're still receiving it from OpenSSL:
/usr/local/Cellar/llvm/9.0.1/bin/llvm-readelf -lW bitcoind
<trim>
GNU_STACK 0x000000 0x0000000000000000 0x0000000000000000 0x000000 0x000000 RW 0x10I agree that having noexecstack applied via OpenSSL isn't clear, but it's unlikely that any further build system changes will occur in the 0.19 branch.
Member
Author
|
@laanwj Feel free to reopen if you disagree. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trivial backport of #17569