tests: Add basic fuzzing harness for CNetAddr/CService/CSubNet related functions (netaddress.h) #18047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatack
reviewed
Feb 2, 2020
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
Concept/approach ACK. Runs about 10 times faster (11.5-12k exec/s) than the asmap fuzzer for me. Why is 8bb9945 described as "temporarily" and a separate commit? (I have the same question regarding the asmap fuzzer PR as well -- thanks.)
practicalswift
force-pushed
the
fuzzers-netaddress
branch
from
bb1283e to
b36a347
Compare
practicalswift
force-pushed
the
fuzzers-netaddress
branch
from
b36a347 to
61d648d
Compare
Contributor
Author
|
@jonatack The reason for the temporary commit was to allow for easy removal in the case that tests cases was added to the qa-assets repo before the merge of this PR :) But to make things less confusing I've now squashed the two commits into one. Please re-review :) |
…d functions (netaddress.h)
practicalswift
force-pushed
the
fuzzers-netaddress
branch
from
61d648d to
815c7a6
Compare
Contributor
Author
|
Rebased! :) |
maflcko
reviewed
Mar 9, 2020
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 10, 2020
…ervice/CSubNet related functions (netaddress.h) 6590395 tests: Remove FUZZERS_MISSING_CORPORA (practicalswift) 815c7a6 tests: Add basic fuzzing harness for CNetAddr/CService/CSubNet related functions (netaddress.h) (practicalswift) Pull request description: Add basic fuzzing harness for `CNetAddr`/`CService`/`CSubNet` related functions (`netaddress.h`). To test this PR: ``` $ make distclean $ ./autogen.sh $ CC=clang CXX=clang++ ./configure --enable-fuzz \ --with-sanitizers=address,fuzzer,undefined $ make $ src/test/fuzz/netaddress … ``` Top commit has no ACKs. Tree-SHA512: 69dc0e391d56d5e9cdb818ac0ac4b69445d0195f714442a06cf662998e38b6e0bbaa635dce78df37ba797feed633e94abba4764b946c1716d392756e7809112d
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Nov 5, 2020
…d functions (netaddress.h) Summary: Backport of core [[bitcoin/bitcoin#18047 | PR18047]]. Test Plan: ninja bitcoin-fuzzers ./test/fuzz/test_runner.py <path_to_corpus> Reviewers: #bitcoin_abc, PiRK Reviewed By: PiRK Differential Revision: https://reviews.bitcoinabc.org/D8270
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
…ervice/CSubNet related functions (netaddress.h) 6590395 tests: Remove FUZZERS_MISSING_CORPORA (practicalswift) 815c7a6 tests: Add basic fuzzing harness for CNetAddr/CService/CSubNet related functions (netaddress.h) (practicalswift) Pull request description: Add basic fuzzing harness for `CNetAddr`/`CService`/`CSubNet` related functions (`netaddress.h`). To test this PR: ``` $ make distclean $ ./autogen.sh $ CC=clang CXX=clang++ ./configure --enable-fuzz \ --with-sanitizers=address,fuzzer,undefined $ make $ src/test/fuzz/netaddress … ``` Top commit has no ACKs. Tree-SHA512: 69dc0e391d56d5e9cdb818ac0ac4b69445d0195f714442a06cf662998e38b6e0bbaa635dce78df37ba797feed633e94abba4764b946c1716d392756e7809112d
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Jul 15, 2022
…e/CSubNet related functions (netaddress.h)
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Jul 17, 2022
backport: bitcoin#18867, bitcoin#19247, bitcoin#19222, bitcoin#18363, bitcoin#18190, bitcoin#18393, partial bitcoin#18047, bitcoin#18314, bitcoin#19143 (fuzzing harness backports: part 3)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic fuzzing harness for
CNetAddr/CService/CSubNetrelated functions (netaddress.h).To test this PR: