gui: Break trivial circular dependencies #18036
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
fanquake
reviewed
Jan 31, 2020
Contributor
|
Nice. Another one. Thanks utACK cdd480b484b201afa94d0f86bad04b83ac97e011 modulo fix of the |
promag
force-pushed
the
2020-01-utilitydialog
branch
2 times, most recently
from
b2fe5e2 to
02c14a6
Compare
Contributor
Author
|
Rebased with #18035 to avoid conflict, please review last commit only. |
Contributor
|
Maybe close #18035 and extend the scope here? |
promag
force-pushed
the
2020-01-utilitydialog
branch
from
02c14a6 to
8ec6210
Compare
promag
changed the title
Contributor
Author
|
@jonasschnelli Done! |
hebasto
reviewed
Jan 31, 2020
promag
force-pushed
the
2020-01-utilitydialog
branch
from
8ec6210 to
3aee10b
Compare
Contributor
|
Concept ACK: very nice to see two circular includes go. Only 14 instances left :) |
jonasschnelli
added a commit
that referenced
this pull request
Feb 1, 2020
3aee10b gui: Drop ShutdownWindow dependency to BitcoinGUI (João Barbosa) 61eb058 gui: Drop BanTableModel dependency to ClientModel (João Barbosa) Pull request description: `ShutdownWindow::showShutdownWindow` just needs a widget to center the shutdown window and to borrow its title. ACKs for top commit: hebasto: ACK 3aee10b, since previous review only suggested change `QWidget` --> `QMainWindow` jonasschnelli: utACK 3aee10b Tree-SHA512: e15cb6ee274730bd071d3d97b540c5059e5c655248d69a37c3fd00f2aacc6cfcb36b9a65755718027e15482ec8e5e85534c1dc13d0ddb4e0680df03fbf6571f2
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Apr 6, 2020
- gui: Avoid Wallet::GetBalance in WalletModel::pollBalanceChanged bitcoin#18160 - gui: Drop PeerTableModel dependency to ClientModel bitcoin#18060 - gui: Break trivial circular dependencies bitcoin#18036 - gui: Improve "Hide" button tool-tip message bitcoin#17360 - gui: Shortcut to close ModalOverlay bitcoin#17998 - gui: Remove warning "unused variable 'wallet_model'" bitcoin#17939 - refactor: Use PACKAGE_NAME in GUI modal overlay and bitcoin-wallet bitcoin#17923 - gui: remove OpenSSL PRNG seeding (Windows, Qt only) bitcoin#17151 - refactor: Remove unused defines in qt/bitcoinunits.h bitcoin#17869
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 18, 2020
Summary: Break circular dependencies "qt/bantablemodel -> qt/clientmodel -> qt/bantablemodel" Note that a dependency on QLocale was introduced in D8492. This PR seems to break an implicit include of QLocale, so it needs to be included explicitly. This is a backport of Core [[bitcoin/bitcoin#18036 | PR18036]] [1/2] Commit bitcoin/bitcoin@61eb058 Test Plan: `ninja && src/qt/bitcoin-qt` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8696
Fabcien
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Dec 18, 2020
Summary: Remove circular dependency "qt/bitcoingui -> qt/utilitydialog -> qt/bitcoingui" This concludes backport of Core [[bitcoin/bitcoin#18036 | PR18036]] [2/2] bitcoin/bitcoin@3aee10b Test Plan: `ninja && src/qt/bitcoin-qt` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D8697
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShutdownWindow::showShutdownWindowjust needs a widget to center the shutdown window and to borrow its title.