Skip to content

qt, refactor: Optimize signal-slot connections logic #17966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hebasto wants to merge 4 commits into from
Closed

qt, refactor: Optimize signal-slot connections logic #17966

hebasto wants to merge 4 commits into from

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Jan 19, 2020 •
edited
Loading

This PR:

@hebasto hebasto requested a review from promag January 19, 2020 17:41
@hebasto hebasto closed this Jan 19, 2020
@hebasto hebasto reopened this Jan 19, 2020
@hebasto hebasto mentioned this pull request Jan 19, 2020
Closed
@DrahtBot
Copy link
Contributor

DrahtBot commented Jan 19, 2020 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@fanquake fanquake removed the Tests label Jan 20, 2020
@jonasschnelli
Copy link
Contributor

jonasschnelli commented Jan 20, 2020

Nice cleanup. Concept ACK.

@hebasto hebasto force-pushed the 20200119-gui-walletframe branch from 90226fa to e0e797d Compare January 30, 2020 18:10
@hebasto
Copy link
Member Author

hebasto commented Jan 30, 2020

Rebased.

@hebasto hebasto force-pushed the 20200119-gui-walletframe branch from e0e797d to 4d7ebd2 Compare February 1, 2020 09:17
@hebasto
Copy link
Member Author

hebasto commented Feb 1, 2020

Rebased after #17937 and #18036 have been merged.

@hebasto hebasto force-pushed the 20200119-gui-walletframe branch from 4d7ebd2 to 809fd3a Compare February 5, 2020 21:27
@hebasto
Copy link
Member Author

hebasto commented Feb 5, 2020

Rebased after #18060 has been merged.

This was referenced Feb 11, 2020
Closed
Merged
@DrahtBot DrahtBot mentioned this pull request Mar 2, 2020
Closed
@DrahtBot DrahtBot mentioned this pull request Mar 20, 2020
Closed
@DrahtBot DrahtBot mentioned this pull request Apr 13, 2020
Closed
This was referenced May 4, 2020
Closed
Closed
hebasto added 2 commits May 29, 2020 14:33
@hebasto
qt: Move connections from WalletFrame to BitcoinGUI
acc1445 
This commit does not change behavior.
@hebasto
qt: Do not pass gui to WalletFrame
6258512 
This commit does not change behavior. Also it removes
bitcoingui->walletframe->bitcoingui circular dependency.
hebasto added 2 commits May 29, 2020 14:33
@hebasto
qt: Do not pass platformStyle to WalletFrame
dee2986 
This commit does not change behavior.
@hebasto
qt: Make path to showModalOverlay slot shorter
7d7cd84 
This commit does not change behavior.
@hebasto hebasto force-pushed the 20200119-gui-walletframe branch from 809fd3a to 7d7cd84 Compare May 29, 2020 11:41
@hebasto
Copy link
Member Author

hebasto commented May 29, 2020

Rebased 809fd3a -> 7d7cd84 (pr17966.04 -> pr17966.05) due to the conflict with #16432.

@hebasto
Copy link
Member Author

hebasto commented Jul 6, 2020

@jonasschnelli Mind reviewing this PR?

@fanquake
Copy link
Member

fanquake commented Jul 9, 2020

There's a Concept ACK, however no subsequent review after ~6 months and this is purely a gui/qt refactor. I'm going to suggest moving this over to https://github.com/bitcoin-core/gui.

@fanquake fanquake closed this Jul 9, 2020
@hebasto hebasto mentioned this pull request Jul 10, 2020
Merged
@hebasto hebasto deleted the 20200119-gui-walletframe branch July 10, 2020 09:51
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@promag promag Awaiting requested review from promag

1 more reviewer

@Binh0103 Binh0103 Binh0103 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

GUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hebasto @DrahtBot @jonasschnelli @fanquake @Binh0103