build: remove WINDOWS_BITS from build system #17756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer build/ship 32 bit windows executables.
Contributor
|
Concept ACK Nice to see 32 bit go |
Contributor
Gitian builds
|
Member
|
LGTM ACK abc147d In the longer run I think it makes sense to stop mentioning "64 bits" at all in user visible places, but this is the obvious change for now—wouldn't want to mess up things with registry keys and start menu entries. |
fanquake
added a commit
that referenced
this pull request
Dec 17, 2019
abc147d build: remove WINDOWS_BITS from build system (fanquake) Pull request description: We no longer build/ship 32 bit windows executables. ACKs for top commit: laanwj: LGTM ACK abc147d Tree-SHA512: 7101393cddb7e578740e4c79532dac981eb963630ce63c28dfebf0f5ecde266c1836ac0efd1fd82e6010a6151755ad2cc2b09bc2f67edd7c0c77060ac046a9cd
Member
Author
I agree. I kept this to the smallest possible, non-controversial change. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 17, 2019
abc147d build: remove WINDOWS_BITS from build system (fanquake) Pull request description: We no longer build/ship 32 bit windows executables. ACKs for top commit: laanwj: LGTM ACK abc147d Tree-SHA512: 7101393cddb7e578740e4c79532dac981eb963630ce63c28dfebf0f5ecde266c1836ac0efd1fd82e6010a6151755ad2cc2b09bc2f67edd7c0c77060ac046a9cd
MarkLTZ
added a commit
to litecoinz-core/litecoinz
that referenced
this pull request
Dec 18, 2019
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Jun 9, 2020
This reverts commit abc147d.
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
abc147d build: remove WINDOWS_BITS from build system (fanquake) Pull request description: We no longer build/ship 32 bit windows executables. ACKs for top commit: laanwj: LGTM ACK abc147d Tree-SHA512: 7101393cddb7e578740e4c79532dac981eb963630ce63c28dfebf0f5ecde266c1836ac0efd1fd82e6010a6151755ad2cc2b09bc2f67edd7c0c77060ac046a9cd
luke-jr
added a commit
to bitcoinknots/bitcoin
that referenced
this pull request
Nov 17, 2020
This reverts commit abc147d.
random-zebra
added a commit
to random-zebra/PIVX
that referenced
this pull request
Jul 19, 2021
…scriptors a7dbb27 build: add missing attributes to Win installer (Fuzzbawls) 13d0b48 nsis: Don't duplicate URL string (Fuzzbawls) 56563e5 build: remove WINDOWS_BITS from build system (fanquake) 0cb37c8 nsis: Write to correct filename in first place (Carl Dong) 7aa2823 gitian: Put things in the right place to begin with (Carl Dong) 0dcf6e6 gitian: Eliminate rename dependency (Carl Dong) ba579b9 gitian: Smaller diff with gitian-linux.yml (Carl Dong) 3b9d5e8 gitian: Fix README inclusion in archives (Carl Dong) 07c27d2 gitian: Use split-debug.sh for Win builds (Carl Dong) 9f19095 build: Add README.md to DIST target (MarcoFalke) ce80c76 build: remove mingw linker workaround from win gitian descriptor (fanquake) 37441b0 scripted-diff: gitian: Use REFERENCE_DATETIME directly. (Fuzzbawls) 966fe9a depends: remove usage of TAR_OPTIONS (fanquake) 12fd641 build: remove export GZIP from gitian descriptors (fanquake) Pull request description: This is a collection of upstream PRs focused on cleaning up the gitian descriptors (un-needed or duplicate code bits, standardizing similar actions across the descriptors, etc), and minor cleanups to supporting build system files. Included are the following upstream PRs: * bitcoin#16141 * bitcoin#16184 * bitcoin#16667 * bitcoin#17097 * bitcoin#17029 * bitcoin#17308 * bitcoin#17756 * bitcoin#18059 ACKs for top commit: furszy: Tested ACK a7dbb27 random-zebra: ACK a7dbb27 and merging... Tree-SHA512: 409d4f51adfb1c90aa8bc572fe6610596dea1293a8ca795f9071bb88bd583bd7678359ee19e34440bb0d117075ebd27f9a622247ee3dfd0cd9088e6da306a4d5
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Oct 23, 2021
abc147d build: remove WINDOWS_BITS from build system (fanquake) Pull request description: We no longer build/ship 32 bit windows executables. ACKs for top commit: laanwj: LGTM ACK abc147d Tree-SHA512: 7101393cddb7e578740e4c79532dac981eb963630ce63c28dfebf0f5ecde266c1836ac0efd1fd82e6010a6151755ad2cc2b09bc2f67edd7c0c77060ac046a9cd
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
Dec 4, 2021
abc147d build: remove WINDOWS_BITS from build system (fanquake) Pull request description: We no longer build/ship 32 bit windows executables. ACKs for top commit: laanwj: LGTM ACK abc147d Tree-SHA512: 7101393cddb7e578740e4c79532dac981eb963630ce63c28dfebf0f5ecde266c1836ac0efd1fd82e6010a6151755ad2cc2b09bc2f67edd7c0c77060ac046a9cd
UdjinM6
added a commit
to dashpay/dash
that referenced
this pull request
Dec 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer build/ship 32 bit windows executables.