test: move more utility functions into test utility library #17593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
approved these changes
Nov 25, 2019
Member
maflcko
left a comment
maflcko
left a comment
There was a problem hiding this comment.
Concept ACK
Will check if it is move-only and then merge
mzumsande
force-pushed
the
201911_test_moveutil
branch
from
3b50882 to
585f049
Compare
mzumsande
force-pushed
the
201911_test_moveutil
branch
from
585f049 to
78e283e
Compare
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
re-run ci |
Member
|
ACK 78e283e 🔧 Show signature and timestampSignature: Timestamp of file with hash |
maflcko
pushed a commit
that referenced
this pull request
Dec 16, 2019
…rary 78e283e [test] move wallet helper functions into test library (Martin Zumsande) f613e5d [test] move mining helper functions into test library (Martin Zumsande) 2cb4e8b [test] move string helper functions into test library (Martin Zumsande) Pull request description: This disbands `test/util.h` and `test/util.cpp` and moves the content into the test utility library recently created in #17542, so that all test utility functions are in one place. The content of the original files are split into three modules: 1) string helper functions go to `test/util/str` 2) mining helper functions go to the newly created `test/util/mining` 3) wallet helper functions go to the newly created `test/util/wallet` ACKs for top commit: MarcoFalke: ACK 78e283e 🔧 Tree-SHA512: f182a61e86e76c32bcb84e37f44904d3a4a9c5a321f7a8efdda5368a6623cb8b5a5384ec4f96e67f0357b0c22099f6e3ecd0ac4cb467e3fa3f3128f8d36edfb8
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Dec 16, 2019
…ity library 78e283e [test] move wallet helper functions into test library (Martin Zumsande) f613e5d [test] move mining helper functions into test library (Martin Zumsande) 2cb4e8b [test] move string helper functions into test library (Martin Zumsande) Pull request description: This disbands `test/util.h` and `test/util.cpp` and moves the content into the test utility library recently created in bitcoin#17542, so that all test utility functions are in one place. The content of the original files are split into three modules: 1) string helper functions go to `test/util/str` 2) mining helper functions go to the newly created `test/util/mining` 3) wallet helper functions go to the newly created `test/util/wallet` ACKs for top commit: MarcoFalke: ACK 78e283e 🔧 Tree-SHA512: f182a61e86e76c32bcb84e37f44904d3a4a9c5a321f7a8efdda5368a6623cb8b5a5384ec4f96e67f0357b0c22099f6e3ecd0ac4cb467e3fa3f3128f8d36edfb8
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 1, 2020
Summary: bitcoin/bitcoin@2cb4e8b --- Partial backport of Core [[bitcoin/bitcoin#17593 | PR17593]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7283
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 1, 2020
Summary: bitcoin/bitcoin@f613e5d --- Depends on D7283 Partial backport of Core [[bitcoin/bitcoin#17593 | PR17593]] Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7284
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 1, 2020
Summary: bitcoin/bitcoin@78e283e --- Depends on D7284 Concludes backport of Core [[bitcoin/bitcoin#17593 | PR17593]] Test Plan: ninja all check check-functional ./src/bench/bitcoin-bench Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7285
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
…ity library 78e283e [test] move wallet helper functions into test library (Martin Zumsande) f613e5d [test] move mining helper functions into test library (Martin Zumsande) 2cb4e8b [test] move string helper functions into test library (Martin Zumsande) Pull request description: This disbands `test/util.h` and `test/util.cpp` and moves the content into the test utility library recently created in bitcoin#17542, so that all test utility functions are in one place. The content of the original files are split into three modules: 1) string helper functions go to `test/util/str` 2) mining helper functions go to the newly created `test/util/mining` 3) wallet helper functions go to the newly created `test/util/wallet` ACKs for top commit: MarcoFalke: ACK 78e283e 🔧 Tree-SHA512: f182a61e86e76c32bcb84e37f44904d3a4a9c5a321f7a8efdda5368a6623cb8b5a5384ec4f96e67f0357b0c22099f6e3ecd0ac4cb467e3fa3f3128f8d36edfb8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disbands
test/util.handtest/util.cppand moves the content into the test utility library recently created in #17542, so that all test utility functions are in one place.The content of the original files are split into three modules:
test/util/strtest/util/miningtest/util/wallet