util: Refactor message hashing into a utility function #17557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes boilerplate code in the subclasses which otherwise only differ by the result type.
The code used to produce a message hash when signing and verifying messages was repeated in a few locations. Additionally, the "magic" text used to prefix the message before hashing is unrelated to validation. Create a utility function for this code rather than spreading it across multiple files.
The purpose of using a preamble or "magic" text as part of signing and verifying a message was not given when the code was repeated in a few locations. Make a test showing how it is used to prevent inadvertently signing a transaction.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
Author
|
Closing as this has been taken care of by #17577. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code used to produce a message hash when signing and verifying
messages was repeated in a few locations. Additionally, the "magic" text
used to prefix the message before hashing is unrelated to validation.
Create a utility function for this code rather than spreading it across
multiple files.
For prior discussion, see #17399 (comment).
The topmost three commits are for this PR. The remaining are from #17399, which this is based on. Please review that before this PR.