test: add block height test to listsinceblock.py #17535
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
reviewed
Nov 20, 2019
ariard
left a comment
ariard
left a comment
There was a problem hiding this comment.
ACK 38e94bc modulo fixing only comment.
I think you can also harden wallet_reorgsrestore, wallet_listtransactions with block height assertions.
jonatack
force-pushed
the
rpc-wallet-blockheight-followups
branch
from
38e94bc to
da0fd46
Compare
jonatack
force-pushed
the
rpc-wallet-blockheight-followups
branch
5 times, most recently
from
30eeb56 to
d289074
Compare
promag
reviewed
Nov 22, 2019
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
ACK d28907423344a6bafb09ebd422a20cd11ff0cf41, I think 27450e0 could be squashed in ecbd8a2 or d289074.
and correct the header docstring.
jonatack
force-pushed
the
rpc-wallet-blockheight-followups
branch
from
d289074 to
5abe488
Compare
Member
Author
|
Thanks for reviewing, @promag! I took your suggestions and squashed the commit. |
Member
Author
@ariard thank you, I will look at those in a follow-up. @practicalswift, @MarcoFalke, any further suggestions here? |
maflcko
reviewed
Dec 6, 2019
jonatack
force-pushed
the
rpc-wallet-blockheight-followups
branch
from
5abe488 to
9501a27
Compare
Member
Author
|
Updated the release notes commit with @MarcoFalke's suggestion and rebased; no other changes. |
This was referenced Mar 9, 2020
maflcko
pushed a commit
that referenced
this pull request
Mar 30, 2020
83e1d92 test: listsinceblock block height checks (Jon Atack) Pull request description: This is the second commit of #17535. This PR extends a listsinceblock test to check the new transaction 'blockheight' field recently added in #17437. It also cleans up code in the test function without changing or removing existing checks. ACKs for top commit: fjahr: tested ACK 83e1d92 ryanofsky: Code review ACK 83e1d92. Nice test improvements! Tree-SHA512: 92874b49a3bc0236500495f32dfcf683e1971ca3d4c51702c69ed4ce7dfce21273754f02f93d1243d73793701d9fdf49e14b149477cd249cbbd9e4e8d5bd49f8
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 31, 2020
83e1d92 test: listsinceblock block height checks (Jon Atack) Pull request description: This is the second commit of bitcoin#17535. This PR extends a listsinceblock test to check the new transaction 'blockheight' field recently added in bitcoin#17437. It also cleans up code in the test function without changing or removing existing checks. ACKs for top commit: fjahr: tested ACK 83e1d92 ryanofsky: Code review ACK 83e1d92. Nice test improvements! Tree-SHA512: 92874b49a3bc0236500495f32dfcf683e1971ca3d4c51702c69ed4ce7dfce21273754f02f93d1243d73793701d9fdf49e14b149477cd249cbbd9e4e8d5bd49f8
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #17437.
Add block height test, expected fields tests, logging, and correct header docstring in
listsinceblock.py, and improve the release notes.