-
Notifications
You must be signed in to change notification settings - Fork 38.8k
ci: Travis support for PowerPC64 #17402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Nice find. However, given that it is not documented, it might go away or break any time and we shouldn't expect travis to provide any support for it. |
|
@MarcoFalke I can add |
As if anyone would do that |
|
Also according to #6466 we were looking for a |
|
I agree that if it was big endian it would've been nicer. |
|
Concept ACK Very nice find! :) |
We use the Ubuntu Bionic libc on all builds, no? So at least that shouldn't matter. |
|
You mean when distributing binaries, right? |
|
The ci system is running (at least on travis) in ubuntu:bionic docker containers. |
I tend to agree. Adding a big-endian build / test (irrespective of platform) would be great. PPC LE is worth testing on intermittently, but don't think it needs to run for every PR and commit (I made a similar argument for RISC-V in #17089). |
|
Don't get me wrong, I appreciate the work you put in here and I am going to steal it for my projects (e.g. intermittent tests as suggested by @laanwj), but it might not be the best fit for the Bitcoin Core repo. |
|
I guess I agree, about the times. But this just makes me wonder if travis is hurting us in the long run. Anyway, that's unrelated to this PR(i'll see if I have time to look into serious infrastructure (I think this is already a serious enough project to have serious infra)). |
|
It is possible to send them money to speed it up for us (#16148 (comment)). However, that will also slow it down for "local" travis testing in forks. |
Well a bad craftsman blames his tools. Yes, travis is problematic sometimes, but also our test suite is very much on the heavy side. Both the build and tests somehow take very long compared to other projects. If it means thorough testing that's good, of course. But maybe it'd be nice to have a subset of fast tests that we can run as often on as many platforms as possible. Maybe foregoing for ex. depends builds. |
I still somewhat blame Travis (i.e. Using a robust Jenkins like server everything is parallel in it's own spots/machine so new jobs don't make the tests longer). But you're right, maybe a good goal is to start figuring out what takes so much time and how can we fix that. |
Without cache it is compile time (due to boost and serialize.h).
Yes, see e.g. #17401 and #17307.
Yes, see e.g. #15858 or #16613.
Yes (we already do for normal compiles), but it is not picked up by depends: #17103 |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
@MarcoFalke Am I dreaming or are they also supporting s390x which is BE? EDIT: Definitely Big Endian :) |
da1f153 Add s390x tests to travis (Elichai Turkel) 2fa65e0 Add ci script to install on s390x (Elichai Turkel) Pull request description: Discovered this as part of #17402 and a conversation with gmaxwell. You can see here that the platform is indeed BE: https://travis-ci.org/elichai/bitcoin/jobs/616656410#L36 This closes #6466 ACKs for top commit: MarcoFalke: ACK da1f153 Tree-SHA512: e7e94e54e220257d91b24fddc79eab2bcaaadf0b2d1e7e6872d9757808ab2541728f00b1f3ab7e343305c0e7d91bb48a17a3f9621f6fff6c9fe6cde6682de408
| Needs rebase |
da1f153 Add s390x tests to travis (Elichai Turkel) 2fa65e0 Add ci script to install on s390x (Elichai Turkel) Pull request description: Discovered this as part of bitcoin#17402 and a conversation with gmaxwell. You can see here that the platform is indeed BE: https://travis-ci.org/elichai/bitcoin/jobs/616656410#L36 This closes bitcoin#6466 ACKs for top commit: MarcoFalke: ACK da1f153 Tree-SHA512: e7e94e54e220257d91b24fddc79eab2bcaaadf0b2d1e7e6872d9757808ab2541728f00b1f3ab7e343305c0e7d91bb48a17a3f9621f6fff6c9fe6cde6682de408
|
I don't see a good reason to leave this open. |
da1f153 Add s390x tests to travis (Elichai Turkel) 2fa65e0 Add ci script to install on s390x (Elichai Turkel) Pull request description: Discovered this as part of bitcoin#17402 and a conversation with gmaxwell. You can see here that the platform is indeed BE: https://travis-ci.org/elichai/bitcoin/jobs/616656410#L36 This closes bitcoin#6466 ACKs for top commit: MarcoFalke: ACK da1f153 Tree-SHA512: e7e94e54e220257d91b24fddc79eab2bcaaadf0b2d1e7e6872d9757808ab2541728f00b1f3ab7e343305c0e7d91bb48a17a3f9621f6fff6c9fe6cde6682de408
Apparently travis has powerpc64 support even though it's undocumented.
I found a couple of caveats though:
depends(fanquake tried debugging and it looks like it can't recognize the platform).ppc64le/ubuntu:18.04instead oflibrary/ubuntu:18.04(this is also maintained by Docker themselves https://github.com/docker-library/official-images#architectures-other-than-amd64)