Fix input size assertion in wallet_bumpfee.py #17322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theStack
approved these changes
Nov 10, 2019
Contributor
theStack
left a comment
theStack
left a comment
There was a problem hiding this comment.
ACK 1ac553c3ab613dea73462be496803d2ee0489d67
Member
|
What about renaming both to the same name? e.g. |
Member
Author
IIRC it made it easier for me to think about the test as I wrote it, but if others find that clearer I can do that too |
instagibbs
force-pushed
the
w_bp_assert
branch
from
1ac553c to
38516f9
Compare
Member
Author
|
In the interest of a quicker merge of this clear test bug, took Marco's suggestion |
Member
|
Sorry, I think the previous solution was also fine. Just forgot about this. |
maflcko
pushed a commit
that referenced
this pull request
Nov 15, 2019
38516f9 Fix input size assertion in wallet_bumpfee.py (Gregory Sanders) Pull request description: I was investigating a curious error for #17290 and realized that this check should have caught that error earlier in the test. The loop is intended to ensure that only a single input exists the entire time until the change output disappears, a single additional bump occurs, then it leaves the loop. Top commit has no ACKs. Tree-SHA512: 1d2d6ef535ec2c55f516ee5de11352386ceac6bedaabc6842229a486d9f28d35310ad5f57bfcc1f1e654fc397ecff29ec33256f9b3da897500b7e1635004b63a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating a curious error for #17290 and realized that this check should have caught that error earlier in the test.
The loop is intended to ensure that only a single input exists the entire time until the change output disappears, a single additional bump occurs, then it leaves the loop.