Skip to content

Remove unused styles on Windows from gitian qt build #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Sep 7, 2012
Merged

Remove unused styles on Windows from gitian qt build #1726

laanwj merged 1 commit into from
Sep 7, 2012

Conversation

@laanwj
Copy link
Member

@laanwj laanwj commented Aug 26, 2012

Keeps the "windows", "windowsxp", "windowsvista" styles.

Reduces the size of a static bitcoin-qt.exe by ~400 kB.

@luke-jr
Copy link
Member

luke-jr commented Aug 26, 2012

Should bump the version number too (eg, qt-win32-4.7.4-gitian.zip => qt-win32-4.7.4-gitian-r1.zip).

@laanwj
Copy link
Member Author

laanwj commented Aug 26, 2012

Done

Diapolo
Diapolo reviewed Aug 26, 2012
View reviewed changes
contrib/gitian-descriptors/qt-win32.yml Outdated
Copy link

@Diapolo Diapolo Aug 26, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After -no-javascript-jit there is an unneeded space, which you could remove. And btw. now I know where the Qt static build is coming from ^^ -static. I have 2 additional switches in my local configure line, which are -no-dsp -no-vcproj. As far as I remember they are only needed for MSVC support.

Edit: And shouldn't it read -no-opengl instead of -opengl no?

Edit 2: Sorry for that many edits, but I tried the -no-feature-style-cde on Windows and I need to supply -no-style-cde for configure to work. Could be a change with Qt 4.8.2 but I wanted to mention it at least :).

@Diapolo
Copy link

Diapolo commented Aug 26, 2012

Nice small find :).

@laanwj
Copy link
Member Author

laanwj commented Aug 27, 2012

Are you sure?

-no-style-XXX didn't work here, even causes an option parse error in configure, though it is mentioned in the online documentation: http://doc.qt.nokia.com/4.7-snapshot/configure-options.html . no-style-XXX options are no longer mentioned in the configure documentation (configure --help) and the configure bash script that is used on unix-like systems.

-no-feature-style-XXX, however works... both in Qt 4.7.4 and Qt 4.8.1, in cross-compile. This may be a difference with configure.exe that you're using to configure on Windows.

Edit: now I'm sure of this: -no-dsp and no-vcproj don't even exist in configure. The -opengl no seems to work, as Qt OpenGL is not built.

@Diapolo
Copy link

Diapolo commented Aug 27, 2012

Can for sure be a difference between configure and configure.exe and if it works everything is fine :).
But at least the -no-opengl seems correct, when you use configure --help you should be able to verify that.

@laanwj
Copy link
Member Author

laanwj commented Aug 27, 2012

Yep, I've verified, -no-opengl seems to be interchangable with -opengl no.

@Diapolo
Copy link

Diapolo commented Aug 27, 2012

Good to know :).

@laanwj
Remove unused styles on Windows from gitian qt build
e598b5b 
Keeps the "windows", "windowsxp", "windowsvista" styles.

Reduces the size of a static bitcoin-qt.exe by ~400 kB.
@BitcoinPullTester
Copy link

BitcoinPullTester commented Aug 30, 2012

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/e598b5b5c2343bcb08bcf804249bdb67180baa41 for binaries and test log.

@gavinandresen
Copy link
Contributor

gavinandresen commented Sep 5, 2012

ACK. Should we pull this for 0.7rc2 ?

@Diapolo
Copy link

Diapolo commented Sep 5, 2012

The pull makes sense and I also used the switches in my own builds and they work (and do not harm bitcoin-qt.exe for me), so I'll vote ACK for 0.7rc2.

@laanwj
Copy link
Member Author

laanwj commented Sep 5, 2012

I think it's safe to pull this for rc2. Though it means we all have to rebuild qt for the next release.

@gavinandresen
Copy link
Contributor

gavinandresen commented Sep 5, 2012

missed it by THAT MUCH ||

laanwj added a commit that referenced this pull request Sep 7, 2012
@laanwj
Merge pull request #1726 from laanwj/2012_08_gitian_qt_styles
b9a4aaa 
Remove unused styles on Windows from gitian qt build
@laanwj laanwj merged commit b9a4aaa into bitcoin:master Sep 7, 2012
@laanwj laanwj deleted the 2012_08_gitian_qt_styles branch April 9, 2014 14:18
owlhooter pushed a commit to owlhooter/mazacoin-new that referenced this pull request Oct 10, 2018
@schinzelh @UdjinM6
bump to 0.12.3.0 (bitcoin#1726)
ccbd527
owlhooter pushed a commit to owlhooter/mazacoin-new that referenced this pull request Oct 10, 2018
@UdjinM6
De-bump to 0.12.2.2 (bitcoin#1768)
f9f28e7 
* Revert "bump to 0.12.3.0 (bitcoin#1726)"

This reverts commit ccbd527.

* bump to 0.12.2.2
KolbyML pushed a commit to KolbyML/bitcoin that referenced this pull request Dec 5, 2020
@furszy
Merge bitcoin#1815: Make CBlock a vector of shared_ptr of CTransactions
7b2b9d0 
911e31c Make CBlock::vtx a vector of shared_ptr<CTransaction> (furszy)
9d27b75 Add deserializing constructors to CTransaction and CMutableTransaction (Pieter Wuille)
5f90940 Add serialization for unique_ptr and shared_ptr (Pieter Wuille)

Pull request description:

  Inspired on bitcoin#9125 (with many more adaptations), preparation for bitcoin#8580. Ant work 🐜

  Establishing the bases for the work, we will need to continue migrating `CTransaction` to `std::shared_ptr<const CTransaction>` where is possible. Example bitcoin#8126 (can find more in bitcoin#1726 list).

  TODO:
  * back port final `CTransactionRef` implementation commit.

  EDIT:
  This is now depending on bitcoin#1816 .

ACKs for top commit:
  random-zebra:
    ACK 911e31c
  Fuzzbawls:
    ACK 911e31c

Tree-SHA512: 61d937aba7dce4ac0867496e7f81ae8351dcdd60b4e72c4f0ed58152a7e556bf455836c766bc97bbca331227e5deed92fa5ce609fa63bb9cb71600b430dc4405
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@laanwj @luke-jr @Diapolo @BitcoinPullTester @gavinandresen