Skip to content

rpc: Add missing deque include to fix build #17249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Oct 26, 2019
Merged

rpc: Add missing deque include to fix build #17249

laanwj merged 1 commit into from
Oct 26, 2019

Conversation

@jbeich
Copy link
Contributor

@jbeich jbeich commented Oct 25, 2019

Regressed by boostorg/filesystem@9a14c37d6f95. See error log.

httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
    std::deque<std::unique_ptr<WorkItem>> queue;
    ~~~~~^

@jbeich
http: add missing header bootlegged by boost < 1.72
a592913 
httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
    std::deque<std::unique_ptr<WorkItem>> queue;
    ~~~~~^
@laanwj
Copy link
Member

laanwj commented Oct 25, 2019

ACK a592913
std::deque is used in that file so it should be included, boost or not.

@maflcko maflcko changed the title Unbreak build with boost 1.72 rpc: Add missing deque include to fix build Oct 25, 2019
@maflcko
Copy link
Member

maflcko commented Oct 25, 2019

Renamed title

@maflcko maflcko added this to the 0.19.0 milestone Oct 25, 2019
@jbeich jbeich mentioned this pull request Oct 25, 2019
Merged
laanwj added a commit that referenced this pull request Oct 26, 2019
@laanwj
Merge #17249: rpc: Add missing deque include to fix build
3f87574 
a592913 http: add missing header bootlegged by boost < 1.72 (Jan Beich)

Pull request description:

  Regressed by boostorg/filesystem@9a14c37d6f95. See [error log](https://github.com/bitcoin/bitcoin/files/3772177/bitcoin-0.18.1.log).

  ```c++
  httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
      std::deque<std::unique_ptr<WorkItem>> queue;
      ~~~~~^
  ```

ACKs for top commit:
  laanwj:
    ACK a592913

Tree-SHA512: fb0aee6a698c7aaa6a73baad7adc4f891be573af0d3cf6f4f59bc825afe5c0bc439c668077ff1990a6135522a0533a1a867430eebad28f0ade93fd79a95e179b
@laanwj laanwj merged commit a592913 into bitcoin:master Oct 26, 2019
laanwj pushed a commit that referenced this pull request Oct 26, 2019
@jbeich @laanwj
http: add missing header bootlegged by boost < 1.72
8082b38 
httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
    std::deque<std::unique_ptr<WorkItem>> queue;
    ~~~~~^

Github-Pull: #17249
Rebased-From: a592913
Tree-SHA512: 47ca773676a3f181bb265af30df6ca83669ffbb2dc79ce7c1ffd6f2d110df8406c2f73daddbcb1c038661472a1be93f46e9d3b8c3d2f33fe484f5774070e59ae
HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Nov 17, 2019
@jbeich
http: add missing header bootlegged by boost < 1.72
c156abe 
httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
    std::deque<std::unique_ptr<WorkItem>> queue;
    ~~~~~^

Github-Pull: bitcoin#17249
Rebased-From: a592913
Tree-SHA512: 47ca773676a3f181bb265af30df6ca83669ffbb2dc79ce7c1ffd6f2d110df8406c2f73daddbcb1c038661472a1be93f46e9d3b8c3d2f33fe484f5774070e59ae
@MarkLTZ MarkLTZ mentioned this pull request Apr 4, 2020
Closed
@garretlaxton garretlaxton mentioned this pull request Aug 3, 2020
Merged
@Bushstar Bushstar mentioned this pull request Nov 2, 2020
Closed
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Nov 14, 2020
@laanwj @UdjinM6
Merge bitcoin#17249: rpc: Add missing deque include to fix build
565d326 
a592913 http: add missing header bootlegged by boost < 1.72 (Jan Beich)

Pull request description:

  Regressed by boostorg/filesystem@9a14c37d6f95. See [error log](https://github.com/bitcoin/bitcoin/files/3772177/bitcoin-0.18.1.log).

  ```c++
  httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
      std::deque<std::unique_ptr<WorkItem>> queue;
      ~~~~~^
  ```

ACKs for top commit:
  laanwj:
    ACK a592913

Tree-SHA512: fb0aee6a698c7aaa6a73baad7adc4f891be573af0d3cf6f4f59bc825afe5c0bc439c668077ff1990a6135522a0533a1a867430eebad28f0ade93fd79a95e179b
UdjinM6 added a commit to dashpay/dash that referenced this pull request Nov 17, 2020
@UdjinM6 @laanwj
Backport bitcoin#17249: rpc: Add missing deque include to fix build (#…
fa4d993 
…3815)

a592913 http: add missing header bootlegged by boost < 1.72 (Jan Beich)

Pull request description:

  Regressed by boostorg/filesystem@9a14c37d6f95. See [error log](https://github.com/bitcoin/bitcoin/files/3772177/bitcoin-0.18.1.log).

  ```c++
  httpserver.cpp:74:10: error: no template named 'deque' in namespace 'std'
      std::deque<std::unique_ptr<WorkItem>> queue;
      ~~~~~^
  ```

ACKs for top commit:
  laanwj:
    ACK a592913

Tree-SHA512: fb0aee6a698c7aaa6a73baad7adc4f891be573af0d3cf6f4f59bc825afe5c0bc439c668077ff1990a6135522a0533a1a867430eebad28f0ade93fd79a95e179b

Co-authored-by: Wladimir J. van der Laan <[email protected]>
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

RPC/REST/ZMQ

Projects

None yet

Milestone

0.19.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jbeich @laanwj @maflcko