gui: Add Windows taskbar progress #17213

luke-jr · 2019-10-21T22:32:53Z

Rebase of #14137
Closes: #14134

DrahtBot · 2019-10-22T02:18:21Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#17740 (build: remove configure checks for win libraries we don't link against by fanquake)
#16883 (WIP: Qt: add QML based mobile GUI by icota)
#15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
#14920 (Build: enable -Wdocumentation via isystem by Empact)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj · 2019-10-22T11:11:11Z

Concept ACK

laanwj · 2019-10-23T11:10:32Z

src/qt/bitcoingui.cpp

I don't think this is the place to do setWindow, every time setNumBlocks is called, move it to the initialization maybe?

Dunno, this apparently works as-is at least.

(I don't run Windows, so any major changes might be better off with someone else taking over the PR.)

laanwj · 2019-10-27T11:16:22Z

it fails the Travis compile:

compiling qwinjumplist.cpp

compiling qwinthumbnailtoolbar.cpp

compiling .moc/release/moc_qwintaskbarprogress.cpp

compiling .moc/release/moc_qwinthumbnailtoolbutton.cpp

compiling qwintaskbarbutton.cpp

qwinjumplist.cpp: In function ‘QString createArguments(const QStringList&)’:

qwinjumplist.cpp:99:66: error: invalid use of incomplete type ‘class QRegularExpression’

         tmp.replace(QRegularExpression(QLatin1String("(\\\\*)\"")), QLatin1String("\\1\\1\\\""));

                                                                  ^

In file included from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/qstring.h:1:0,

                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/../../src/corelib/kernel/qobject.h:47,

                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/qobject.h:1,

                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/../../src/corelib/animation/qabstractanimation.h:43,

                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/qabstractanimation.h:1,

                 from /home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/QtCore:5,

                 from ../../include/QtWinExtras/QtWinExtrasDepends:3:

/home/travis/build/bitcoin/bitcoin/depends/work/build/x86_64-w64-mingw32/qt/5.9.8-9cd2cbc4308/qtbase/include/QtCore/../../src/corelib/tools/qstring.h:80:7: note: forward declaration of ‘class QRegularExpression’

 class QRegularExpression;

       ^~~~~~~~~~~~~~~~~~

Looks like you're going to have to enable the regular expressions module for this…

luke-jr · 2019-10-27T13:26:55Z

Or disable qwinjumplist, which this doesn't even use.

luke-jr · 2019-10-27T13:32:29Z

I don't understand why gitian succeeds, but not Travis...

maflcko · 2019-10-27T13:52:47Z

Gitian fails for the same reason

luke-jr · 2019-10-27T17:54:42Z

Ah, saw win32 builds above, but missed that it was just master...

luke-jr · 2019-10-28T00:19:16Z

For now, sed'd out the qwinjumplist stuff since it's completely unused.

luke-jr · 2019-10-29T00:08:21Z

@DrahtBot What's the point of the side-by-side when they're not the same on each side?

And why did the last build not even attempt?

DrahtBot · 2019-10-30T11:46:26Z

Gitian builds

File	commit `6a97e8a` (master)	commit 5d1962100da67257da5fc00b29825c0ccae0cfd6 (master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`5c2038572887ff66...`	`bb1dc8c999b76fde...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`49ff162cec697356...`	`cfa64b8461042810...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`bf5d5326ce1728d7...`	`5f13b49a9def1c7f...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`3f99ab4bd36646d8...`	`a6d72caa9c1f3fc3...`
bitcoin-0.19.99-i686-pc-linux-gnu-debug.tar.gz	`974681b2edd08059...`	`b51441d7c48fe639...`
bitcoin-0.19.99-i686-pc-linux-gnu.tar.gz	`3ed00c6bc92fae48...`	`5cc7160ccd8c73ef...`
bitcoin-0.19.99-osx-unsigned.dmg	`b29d0f99f1ac90fb...`	`f40205af4255c76c...`
bitcoin-0.19.99-osx64.tar.gz	`6629eda6528a0119...`	`761c91aa042310d6...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`4dd3873e05461e09...`	`720d51d999b271d1...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`030765a62624bf71...`	`2f52674e060554fa...`
bitcoin-0.19.99-win64-debug.zip	`ab2432399bb456e4...`	`63010ef28bbe0747...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`d02c501496a8b7f2...`	`9f6b0cc2b7a01052...`
bitcoin-0.19.99-win64.zip	`a5fb8508007170a7...`	`b808b6fda2fdcf4b...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`f5ee1164ab6a761b...`	`a4bb5dc4eaf375f8...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`84e4b287e5cacc9c...`	`90f4370e8c675302...`
bitcoin-0.19.99.tar.gz	`c57314f1b9f55435...`	`1da6f333330365f7...`
bitcoin-core-linux-0.20-res.yml	`05e1dbc1920ed5d7...`	`762aa0525ed705cc...`
bitcoin-core-osx-0.20-res.yml	`cbe866cb3ba41569...`	`a08562a88c403425...`
bitcoin-core-win-0.20-res.yml	`01dad4120e3d63ee...`	`737631691e50525c...`
linux-build.log	`3889b7f85e54145f...`	`81e135693a420bab...`
osx-build.log	`5d9969211f8c99f3...`	`bd4e838e8410d388...`
win-build.log	`097a984b037bd1d1...`	`6b98c2ce1fc2aff3...`
bitcoin-core-linux-0.20-res.yml.diff		`a4b8f6b9f8401f87...`
bitcoin-core-osx-0.20-res.yml.diff		`6b52537b10d571a6...`
bitcoin-core-win-0.20-res.yml.diff		`753e95e370c32e48...`
linux-build.log.diff		`7040af6d72191777...`
osx-build.log.diff		`dcb46da0249c1203...`
win-build.log.diff		`e3df2bc12e188d74...`

maflcko · 2019-10-30T12:30:51Z

@luke-jr How about that table? It might be more readable

luke-jr · 2019-10-30T14:35:56Z

Looks much nicer. Might make the .diffs two-column (if markdown supports it)

jonasschnelli · 2019-11-04T19:33:19Z

Concept ACK
Too bad this requires new dependencies and a bunch of ifdefs

laanwj · 2019-11-06T14:06:38Z

configure.ac

     AC_CHECK_LIB([shlwapi],      [main],, AC_MSG_ERROR(libshlwapi missing))
     AC_CHECK_LIB([iphlpapi],      [main],, AC_MSG_ERROR(libiphlpapi missing))
     AC_CHECK_LIB([crypt32],      [main],, AC_MSG_ERROR(libcrypt32 missing))
+     AC_CHECK_LIB([dwmapi],      [main],, AC_MSG_ERROR(libdwmapi missing))


Do you know what is the first release of windows to have dwmapi? Is this a recent addition? (if it's windows 7 or older it's fine)

https://docs.microsoft.com/en-us/windows/win32/api/dwmapi/nf-dwmapi-dwmsetwindowattribute suggests at least Vista has it.

DrahtBot · 2020-01-24T08:42:14Z

Needs rebase

fanquake · 2020-02-26T01:08:47Z

Concept ~0. I've closed my original issue (#14134), and don't really think that this change and the additional dependencies is really worthwhile.

luke-jr · 2020-02-26T03:00:54Z

Closing due to lack of interest

fanquake added GUI Windows labels Oct 21, 2019

luke-jr force-pushed the win_taskbar_progress branch from 24fac38 to 4936a6b Compare October 22, 2019 00:52

laanwj added Feature Needs gitian build labels Oct 22, 2019

laanwj reviewed Oct 23, 2019

View reviewed changes

DrahtBot removed the Needs gitian build label Oct 24, 2019

laanwj mentioned this pull request Oct 27, 2019

qt: Add privacy to the Overview page #16432

Merged

maflcko added the Needs gitian build label Oct 27, 2019

luke-jr force-pushed the win_taskbar_progress branch from 4936a6b to cac7c37 Compare October 28, 2019 00:18

gui: Add Windows taskbar progress

a932d13

luke-jr force-pushed the win_taskbar_progress branch from cac7c37 to a932d13 Compare October 28, 2019 16:44

DrahtBot removed the Needs gitian build label Oct 28, 2019

maflcko added the Needs gitian build label Oct 28, 2019

DrahtBot removed the Needs gitian build label Oct 28, 2019

bitcoin deleted a comment from DrahtBot Oct 29, 2019

maflcko added the Needs gitian build label Oct 29, 2019

bitcoin deleted a comment from DrahtBot Oct 29, 2019

DrahtBot removed the Needs gitian build label Oct 30, 2019

laanwj reviewed Nov 6, 2019

View reviewed changes

DrahtBot added the Needs rebase label Jan 24, 2020

luke-jr closed this Feb 26, 2020

fanquake mentioned this pull request Apr 9, 2020

Bugfix: devtools/symbol-check: Check PE libraries case-insensitively #18490

Closed

hebasto mentioned this pull request May 20, 2021

test: Use Regex Search in Apptests bitcoin-core/gui#337

Merged

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

gui: Add Windows taskbar progress #17213

gui: Add Windows taskbar progress #17213

Uh oh!

Conversation

luke-jr commented Oct 21, 2019 • edited by fanquake Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

laanwj commented Oct 22, 2019

Uh oh!

laanwj Oct 23, 2019

Choose a reason for hiding this comment

Uh oh!

luke-jr Oct 23, 2019

Choose a reason for hiding this comment

Uh oh!

laanwj commented Oct 27, 2019

Uh oh!

luke-jr commented Oct 27, 2019

Uh oh!

luke-jr commented Oct 27, 2019

Uh oh!

maflcko commented Oct 27, 2019

Uh oh!

luke-jr commented Oct 27, 2019

Uh oh!

luke-jr commented Oct 28, 2019

Uh oh!

luke-jr commented Oct 29, 2019

Uh oh!

DrahtBot commented Oct 30, 2019

Gitian builds

Uh oh!

maflcko commented Oct 30, 2019

Uh oh!

luke-jr commented Oct 30, 2019

Uh oh!

jonasschnelli commented Nov 4, 2019

Uh oh!

laanwj Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

luke-jr Nov 6, 2019

Choose a reason for hiding this comment

Uh oh!

DrahtBot commented Jan 24, 2020

Uh oh!

fanquake commented Feb 26, 2020

Uh oh!

luke-jr commented Feb 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

luke-jr commented Oct 21, 2019 •

edited by fanquake

Loading

DrahtBot commented Oct 22, 2019 •

edited

Loading