tests: Fix fs_tests for unknown locales #17158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix by removing "L" as suggested by meeDamian in bitcoin#14948 (comment) Co-Authored-By: [email protected] Github-Pull: bitcoin#17086 Rebased-From: d48f664
Member
|
Please, don't create manual backport PRs for trivial things that can be cherry-picked automatically. Adding a "Needs backport" tag should be enough, they will be included and collected in backport PRs. |
carnhofdaki
force-pushed
the
cdk/0.19-fix_fs_tests
branch
from
c90a42e to
bd9d40d
Compare
Contributor
Author
@laanwj OK, thank you, I did not know the process. |
Member
|
No problem for this time! just that, if everyone does this for everything you'd get a blow up (N branches * N PRs). So it's something to reserve for non-trivial backports, in general 😄 |
laanwj
added a commit
that referenced
this pull request
Oct 16, 2019
bd9d40d tests: Fix fs_tests for unknown locales (Daki Carnhof) Pull request description: Backporting to `0.19` as suggested in #17086 (comment) Fix by removing "L" as suggested by meeDamian in #14948 (comment) Co-Authored-By: [email protected] Top commit has no ACKs. Tree-SHA512: cb73c475560d156034d240c77dfd704526cfb148bcecf302079f1f9b6984117da71f018e1c70a165caed90be48482cb9c4939b001477a44f562fc0c11cb6ede7
carnhofdaki
added a commit
to carnhofdaki/bitcoin
that referenced
this pull request
Jan 6, 2020
See laanwj's comment in bitcoin#17158 bitcoin#17158 (comment) Co-Authored-By: Wladimir J. van der Laan <[email protected]> Co-Authored-By: Hennadii Stepanov <[email protected]> Co-Authored-By: João Barbosa <[email protected]> Co-Authored-By: Michael <[email protected]> Co-Authored-By: Luke Dashjr <[email protected]>
maflcko
pushed a commit
that referenced
this pull request
Mar 11, 2020
2a6bce4 doc: Add a note about backporting (Carnhof Daki) Pull request description: See laanwj's comment in #17158 #17158 (comment) Top commit has no ACKs. Tree-SHA512: ac5248a796050ce1a5bd0718955f941f6a3c025e192599948f12566eb55296079404b999676b9a2c8fe10616fc8334698dfa415af0fb4db6c98038d52218af1f
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Mar 11, 2020
2a6bce4 doc: Add a note about backporting (Carnhof Daki) Pull request description: See laanwj's comment in bitcoin#17158 bitcoin#17158 (comment) Top commit has no ACKs. Tree-SHA512: ac5248a796050ce1a5bd0718955f941f6a3c025e192599948f12566eb55296079404b999676b9a2c8fe10616fc8334698dfa415af0fb4db6c98038d52218af1f
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Apr 17, 2020
See laanwj's comment in bitcoin#17158 bitcoin#17158 (comment) Co-Authored-By: Wladimir J. van der Laan <[email protected]> Co-Authored-By: Hennadii Stepanov <[email protected]> Co-Authored-By: João Barbosa <[email protected]> Co-Authored-By: Michael <[email protected]> Co-Authored-By: Luke Dashjr <[email protected]>
van-orton
pushed a commit
to BitgesellOfficial/bitgesell
that referenced
this pull request
Oct 30, 2020
See laanwj's comment in #17158 bitcoin/bitcoin#17158 (comment) Co-Authored-By: Wladimir J. van der Laan <[email protected]> Co-Authored-By: Hennadii Stepanov <[email protected]> Co-Authored-By: João Barbosa <[email protected]> Co-Authored-By: Michael <[email protected]> Co-Authored-By: Luke Dashjr <[email protected]>
sidhujag
pushed a commit
to syscoin-core/syscoin
that referenced
this pull request
Nov 10, 2020
2a6bce4 doc: Add a note about backporting (Carnhof Daki) Pull request description: See laanwj's comment in bitcoin#17158 bitcoin#17158 (comment) Top commit has no ACKs. Tree-SHA512: ac5248a796050ce1a5bd0718955f941f6a3c025e192599948f12566eb55296079404b999676b9a2c8fe10616fc8334698dfa415af0fb4db6c98038d52218af1f
backpacker69
pushed a commit
to peercoin/peercoin
that referenced
this pull request
Mar 28, 2021
See laanwj's comment in #17158 bitcoin/bitcoin#17158 (comment) Co-Authored-By: Wladimir J. van der Laan <[email protected]> Co-Authored-By: Hennadii Stepanov <[email protected]> Co-Authored-By: João Barbosa <[email protected]> Co-Authored-By: Michael <[email protected]> Co-Authored-By: Luke Dashjr <[email protected]>
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
2a6bce4 doc: Add a note about backporting (Carnhof Daki) Pull request description: See laanwj's comment in bitcoin#17158 bitcoin#17158 (comment) Top commit has no ACKs. Tree-SHA512: ac5248a796050ce1a5bd0718955f941f6a3c025e192599948f12566eb55296079404b999676b9a2c8fe10616fc8334698dfa415af0fb4db6c98038d52218af1f
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 14, 2021
2a6bce4 doc: Add a note about backporting (Carnhof Daki) Pull request description: See laanwj's comment in bitcoin#17158 bitcoin#17158 (comment) Top commit has no ACKs. Tree-SHA512: ac5248a796050ce1a5bd0718955f941f6a3c025e192599948f12566eb55296079404b999676b9a2c8fe10616fc8334698dfa415af0fb4db6c98038d52218af1f
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting to
0.19as suggested in #17086 (comment)Fix by removing "L" as suggested by meeDamian in
#14948 (comment)
Co-Authored-By: [email protected]