Skip to content

Chainparams: Decouple AllowSetMockTime from MineBlocksOnDemand #17106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtimon wants to merge 4 commits into from
Closed

Chainparams: Decouple AllowSetMockTime from MineBlocksOnDemand #17106

jtimon wants to merge 4 commits into from

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Oct 11, 2019 •
edited by fanquake
Loading

Even if a test chain doesn't MineBlocksOnDemand (aka consensus.fPowNoRetargeting = false), it may make sense to allow the rpc call setmocktime for that chain.

For example, it could be allowed by default for testnet3 (aka "test" on bip70).
Or at least this is what I think MarcoFalke wants from our last conversation on IRC.
For more context see #16770 (comment)

As a bonus, unlike consensus.fPowNoRetargeting, the new field m_allow_set_mocktime gets fully out of consensus code in the sense that people "greping" from consensus/params.h don't need to necessarily look at rpc call setmocktime in rpc/misc.cpp if that's not what they're looking for.
One less read to Consensus::Params.
Not sure if that last part makes sense to anyone else but me as reasons to get this merged.

@jtimon jtimon mentioned this pull request Oct 11, 2019
Closed
@DrahtBot
Copy link
Contributor

DrahtBot commented Oct 11, 2019 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #17037 (Testschains: Many regtests with different genesis and default datadir by jtimon)
  • #17032 (Tests: Chainparams: Make regtest almost fully customizable by jtimon)
  • #16411 (BIP-325: Signet support by kallewoof)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@maflcko
Copy link
Member

maflcko commented Oct 11, 2019

Concept ACK. I'd like to be able to set mocktime for my testnet3 node. Haven't looked at the implementation.

@jtimon
Copy link
Contributor Author

jtimon commented Feb 4, 2020

I wrote this PR for you @MarcoFalke . I don't have particular interest in it.
Since you don't seem specially interested either, I'm closing for now due to lack of interest.
I can reopen later if you're interested again and want to review.

@jtimon jtimon closed this Feb 4, 2020
@maflcko
Copy link
Member

maflcko commented Feb 18, 2020

Ah sorry, I forgot about this. Nonetheless something similar has just been merged as 930d837

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

RPC/REST/ZMQ Tests Validation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jtimon @DrahtBot @maflcko