gui: rename debug window #17096

Zero-1729 · 2019-10-10T13:32:50Z

Edit: I have now limited the change in this PR to only renaming the window title from Debug Window to Node Window. Check this comment for more details.

This PR is in response to #17082, which aims to rename the Debug window title to a more user friendly term; Node window.

Closes #17082

hebasto · 2019-10-10T13:40:40Z

Concept ACK.

hebasto · 2019-10-10T13:42:28Z

Could scripted diff be used for renaming commits?

promag

Concept ACK, agree with the scripted diff.

src/qt/rpcconsole.cpp

Zero-1729 · 2019-10-10T14:21:57Z

Sorry, the ci tests failed because I seemed to have left debugwindow.ui instead of changing it to nodewindow.ui in src/Makefile.qt.include.

Zero-1729 · 2019-10-10T15:07:32Z

Are there any more changes/edits I need to make?

DrahtBot · 2019-10-10T16:11:30Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

laanwj · 2019-10-10T17:50:38Z

I think it makes sense to separate the change in user facing name (in a separate PR) from the internal refactoring to change the class name. These can be discussed / bike shedded seperately.

promag · 2019-10-10T17:55:27Z

Agree with @laanwj. Also, maybe we can make the current tab the window title and so we don't have to decide for a new name?

Zero-1729 · 2019-10-10T18:24:29Z

I think it makes sense to separate the change in user facing name (in a separate PR) from the internal refactoring to change the class name. These can be discussed / bike shedded seperately.

Fair enough, I guess I could squash the commits into a single commit (gui: rename debug window); with only the initial commit, along with the revert from this commit, making this PR only the user facing change.

Then maybe open a separate PR later, with the internal class change and file renames, assuming this PR is merged.

Zero-1729 · 2019-10-10T19:20:35Z

Agree with @laanwj. Also, maybe we can make the current tab the window title and so we don't have to decide for a new name?

@promag would that be changing the window title of NodeWidget (or RPCConsole) whenever a tab is set? Explicitly setting the window title to tab text, so {tab_name} Window, i.e: Information Window, Console Window, etc.

E.g:

Console Tab:

Is this what you mean? Or am I missing something?

Zero-1729 · 2019-10-16T18:41:35Z

The changes made in this PR are too much, so I have squashed them all to only include the UI facing changes (i.e., the original gui: rename debug window commit), as per @laanwj's suggestion. Limiting this PR to the user facing change(s) only (i.e. the renaming of the window title from Debug window to Node window). That way this would remain a simple PR, instead of a super PR.

Also, with respect to @promag's suggestion, about making the window title the current tab name, I have created a separate branch with the changes included, alongside the internal class change from RPCConsole to NodeWidget, file renames, etc. That way, assuming those changes are requested, a new PR can easily be opened.

jonasschnelli

utACK b5d6aceaae878cf1b0abaf039ceb82c0e65ec246 - trivial change. Only user facing name change.

Zero-1729 · 2019-11-16T18:00:21Z

@jonasschnelli I just cloned the branch locally and built it from source, all the tests in src/test/test_bitcoin-qt were successful. 👍

The window title properly displays "Node window".

Zero-1729 · 2019-11-22T00:21:41Z

Are there any other checks or changes that need to be done?

src/qt/bitcoingui.cpp

promag · 2019-11-22T00:36:02Z

Also, with respect to @promag's suggestion, about making the window title the current tab name, I have created a separate branch with the changes included, alongside the internal class change from RPCConsole to NodeWidget, file renames, etc. That way, assuming those changes are requested, a new PR can easily be opened.

Oh thanks for the consideration!

Zero-1729 · 2019-11-23T21:06:02Z

@promag are there any more updates?

fanquake · 2019-11-23T23:01:00Z

@Zero-1729 You can squash your commits.

Zero-1729 · 2019-11-24T00:19:05Z

@fanquake squashed 👍

Zero-1729 · 2019-12-19T10:19:28Z

Are there any more updates I need to make to the current changes?

src/qt/bitcoingui.cpp

- Renamed 'Debug window' to a more user friendly term - 'Node window' - in the window title and tray menu. fixes bitcoin#17082

hebasto

ACK 44f15cf, tested on Linux Mint 19.3:

Zero-1729 · 2020-01-13T18:10:20Z

I now realize I can't cancel the review request I mistakenly made to @promag a while back, as I lack the permissions. He should just ignore the request so I don't waste his time, especially since @hebasto has ACKed the changes.

theStack

ACK 44f15cf, tested on Linux (Lubuntu 16.04):

44f15cf gui: renamed 'debug window' to 'node window' (Zero) Pull request description: **Edit**: I have now limited the change in this PR to only renaming the window title from `Debug Window` to `Node Window`. Check [this comment](#17096 (comment)) for more details. This PR is in response to #17082, which aims to rename the `Debug window` title to a more user friendly term; `Node window`. Closes #17082 ACKs for top commit: hebasto: ACK 44f15cf, tested on Linux Mint 19.3: theStack: ACK 44f15cf, tested on Linux (Lubuntu 16.04): Tree-SHA512: 9fc73f2e67badb38525c550ce4c313288858b3fde30ef17fee85230be5bf31cf94408c699265b5e1256dfed60f8d04f48927d9b2831ba9f25498b98e6fa7180f

44f15cf gui: renamed 'debug window' to 'node window' (Zero) Pull request description: **Edit**: I have now limited the change in this PR to only renaming the window title from `Debug Window` to `Node Window`. Check [this comment](bitcoin#17096 (comment)) for more details. This PR is in response to bitcoin#17082, which aims to rename the `Debug window` title to a more user friendly term; `Node window`. Closes bitcoin#17082 ACKs for top commit: hebasto: ACK 44f15cf, tested on Linux Mint 19.3: theStack: ACK bitcoin@44f15cf, tested on Linux (Lubuntu 16.04): Tree-SHA512: 9fc73f2e67badb38525c550ce4c313288858b3fde30ef17fee85230be5bf31cf94408c699265b5e1256dfed60f8d04f48927d9b2831ba9f25498b98e6fa7180f

Fix intro dialog labels when the prune button is toggled (bitcoin#17453) Rename debug window (bitcoin#17096) Add close window shortcut (bitcoin#15768) Add privacy to the Overview page (bitcoin#16432) Remove WalletView and BitcoinGUI circular dependency (bitcoin#17937) Force set nPruneSize in QSettings after the intro dialog (bitcoin#17696)

promag · 2020-09-20T21:26:41Z

@Zero-1729 sorry missed your review request.

Zero-1729 · 2020-09-23T13:52:07Z

@promag no worries 👍.

44f15cf gui: renamed 'debug window' to 'node window' (Zero) Pull request description: **Edit**: I have now limited the change in this PR to only renaming the window title from `Debug Window` to `Node Window`. Check [this comment](bitcoin#17096 (comment)) for more details. This PR is in response to bitcoin#17082, which aims to rename the `Debug window` title to a more user friendly term; `Node window`. Closes bitcoin#17082 ACKs for top commit: hebasto: ACK 44f15cf, tested on Linux Mint 19.3: theStack: ACK bitcoin@44f15cf, tested on Linux (Lubuntu 16.04): Tree-SHA512: 9fc73f2e67badb38525c550ce4c313288858b3fde30ef17fee85230be5bf31cf94408c699265b5e1256dfed60f8d04f48927d9b2831ba9f25498b98e6fa7180f

Summary: 44f15cfdcfc64d5a0c36fded39e4aef49415b11b gui: renamed 'debug window' to 'node window' (Zero) Pull request description: **Edit**: I have now limited the change in this PR to only renaming the window title from `Debug Window` to `Node Window`. Check [this comment](bitcoin/bitcoin#17096 (comment)) for more details. This PR is in response to #17082, which aims to rename the `Debug window` title to a more user friendly term; `Node window`. Closes #17082 Backport of Core [[bitcoin/bitcoin#17096 | PR17096]] Test Plan: Verify new string names in `bitcoin-qt` Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8523

fanquake added the GUI label Oct 10, 2019

promag reviewed Oct 10, 2019

View reviewed changes

src/qt/rpcconsole.cpp Show resolved Hide resolved

maflcko reviewed Oct 10, 2019

View reviewed changes

src/qt/rpcconsole.cpp Outdated Show resolved Hide resolved

fanquake requested a review from jonasschnelli October 10, 2019 16:13

DrahtBot added the Needs rebase label Oct 15, 2019

Zero-1729 force-pushed the rename-debug-window branch from d665d2a to b5d6ace Compare October 16, 2019 18:18

DrahtBot removed the Needs rebase label Oct 16, 2019

jonasschnelli approved these changes Nov 16, 2019

View reviewed changes

MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Nov 17, 2019

[gui] Rename debug window (bitcoin#17096)

91021bf

promag reviewed Nov 22, 2019

View reviewed changes

src/qt/bitcoingui.cpp Outdated Show resolved Hide resolved

Zero-1729 requested a review from promag November 23, 2019 14:25

Zero-1729 force-pushed the rename-debug-window branch from 75a6346 to 5c4a9a9 Compare November 24, 2019 00:15

hebasto reviewed Jan 5, 2020

View reviewed changes

src/qt/bitcoingui.cpp Outdated Show resolved Hide resolved

gui: renamed 'debug window' to 'node window'

44f15cf

- Renamed 'Debug window' to a more user friendly term - 'Node window' - in the window title and tray menu. fixes bitcoin#17082

Zero-1729 force-pushed the rename-debug-window branch from 5c4a9a9 to 44f15cf Compare January 6, 2020 19:34

hebasto approved these changes Jan 7, 2020

View reviewed changes

theStack approved these changes Jan 22, 2020

View reviewed changes

jonasschnelli merged commit 44f15cf into bitcoin:master Jan 27, 2020

MarkLTZ mentioned this pull request Apr 4, 2020

Bitcoin PR tracking litecoinz-core/litecoinz#14

Closed

bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022

gui: rename debug window #17096

gui: rename debug window #17096

Uh oh!

Conversation

Zero-1729 commented Oct 10, 2019 • edited by fanquake Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented Oct 10, 2019

Uh oh!

hebasto commented Oct 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Zero-1729 commented Oct 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zero-1729 commented Oct 10, 2019

Uh oh!

DrahtBot commented Oct 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Conflicts

Uh oh!

laanwj commented Oct 10, 2019

Uh oh!

promag commented Oct 10, 2019

Uh oh!

Zero-1729 commented Oct 10, 2019

Uh oh!

Zero-1729 commented Oct 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zero-1729 commented Oct 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonasschnelli left a comment

Choose a reason for hiding this comment

Uh oh!

Zero-1729 commented Nov 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zero-1729 commented Nov 22, 2019

Uh oh!

Uh oh!

promag commented Nov 22, 2019

Uh oh!

Zero-1729 commented Nov 23, 2019

Uh oh!

fanquake commented Nov 23, 2019

Uh oh!

Zero-1729 commented Nov 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zero-1729 commented Dec 19, 2019

Uh oh!

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Zero-1729 commented Jan 13, 2020

Uh oh!

theStack left a comment

Choose a reason for hiding this comment

Uh oh!

promag commented Sep 20, 2020

Uh oh!

Zero-1729 commented Sep 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Zero-1729 commented Oct 10, 2019 •

edited by fanquake

Loading

hebasto commented Oct 10, 2019 •

edited

Loading

Zero-1729 commented Oct 10, 2019 •

edited

Loading

DrahtBot commented Oct 10, 2019 •

edited

Loading

Zero-1729 commented Oct 10, 2019 •

edited

Loading

Zero-1729 commented Oct 16, 2019 •

edited

Loading

Zero-1729 commented Nov 16, 2019 •

edited

Loading

Zero-1729 commented Nov 24, 2019 •

edited

Loading