qt: Fix text display when state of prune button is changed #17035

cvengler · 2019-10-03T00:32:57Z

Currently there is this bug when enabling and disabling pruning: The intro screen isn't updated when something is changing.

This fixes the storage message in the top.
Here is a video of this fix
~~Unfortunately it doesn't fix the required storage amount, I will be working on this next.~~ Done!
This needs to get into 0.19 as well

promag

Concept ACK.

src/qt/intro.cpp

hebasto

Unfortunately it doesn't fix the required storage amount, I will be working on this next.

I tend to Approach NACK. The full problem solution, with the required storage amount is fixed, is welcome.

src/qt/intro.cpp

cvengler · 2019-10-06T04:50:21Z

@hebasto Done

hebasto

It seems commits need to be squashed in two ones:

introduce pruneWasNotSet member
all the rest

src/qt/intro.cpp

src/qt/intro.h

hebasto · 2019-10-06T14:30:52Z

src/qt/intro.h

ui->prune->isChecked() is accessible here. bool is_pruned parameter seems redundant.

Oh yeah, it is just a remaining of the first version of this patch

cvengler · 2019-10-06T17:07:30Z

Squashing done

src/qt/intro.h

hebasto · 2019-10-06T17:52:34Z

Approach ACK 727f86f3a75051daaeb81cb3984574c06eb62449, tested on Linux Mint 19.2.

Nit: #17035 (comment)

Commit 727f86f3a75051daaeb81cb3984574c06eb62449 message "... It also removes a useless boolean added before" is a hint ;) Why to introduce a variable in a commit to remove it in the next one?

It does not work if disk space is insufficient and -prune=0 or -noprune is passed as an command-line option (it could be leave for the following PRs, IMO).

EDIT: The "qt: Update the required space message when the prune box is checked" commit (727f86f3a75051daaeb81cb3984574c06eb62449) should deal with both ui->prune->setChecked() and pruneTarget. The latter is ignored now ;)

cvengler · 2019-10-07T00:03:41Z

@hebasto

EDIT: The "qt: Update the required space message when the prune box is checked" commit (727f86f) should deal with both ui->prune->setChecked() and pruneTarget. The latter is ignored now ;)

I removed this message completely because a variable rename wasn't the real point of this commit

hebasto · 2019-10-07T17:08:22Z

As I wrote:

... should deal with both ui->prune->setChecked() and pruneTarget. The latter is ignored now ;)

More details are in the screenshot:

If pruneTarget is set to 2 GB, amount 3 GB of stored data is obviously incorrect.

cvengler · 2019-10-07T19:56:41Z

@hebasto Sure, what is with the chainstate?

jonasschnelli · 2019-10-08T09:52:41Z

Tested a bit, something seems incorrect. If I start with -prune=2000 I'll get a text "Approx 7GB" while when I start without -prune, I'll get 4GB as size warning.

I know this is not the place to discuss that, but why have we chosen 2GB as prune target instead of the minimum of 550MB?

promag · 2019-10-09T09:42:43Z

If I start with -prune=2000 I'll get a text "Approx 7GB" while when I start without -prune, I'll get 4GB as size warning.

I confirm this behavior, setting -prune on command line and setting in the UI should give the same approximation?

cvengler · 2019-10-09T15:28:41Z

@promag @jonasschnelli
I might xe wrong but this is a feature and not a bug. It is because the chainstate size is also being incremented to the required amount of storage. When you prune with 550MB your bitcoin folder will still be around 4-5GB huge and not 550MB

cvengler · 2019-10-09T15:29:41Z

See Line 361:

requiredSpace += m_chain_state_size;

cvengler · 2019-10-14T15:29:16Z

Push

hebasto · 2019-10-15T08:09:18Z

Tested this PR on top of the current master (dcc6408).

src/qt/bitcoin-qt -chain=test -prune=2000

That is correct, as 5 GB is a sum of pruned blockchain size (2 GB) and chainstate size (3 GB).

src/qt/bitcoin-qt -chain=test

That is wrong, as 2 GB is the default pruned blockchain size, and chainstate size is skipped.

@promag

I confirm this behavior, setting -prune on command line and setting in the UI should give the same approximation?

Yes, they should.

cvengler · 2019-10-15T14:06:43Z

Ok, will work on specific chain selection now

cvengler · 2019-10-16T14:14:45Z

@hebasto Fixed, squashed and ready for merge

hebasto · 2019-10-17T11:08:30Z

Tested 9ab3876b43d45e8d742adcad996537b2dcbacff3 on Linux Mint 19.2:

$ git log -1
commit 7fabf14f9556c6d56219f9c835d78a458d862ad5 (HEAD -> pr17035-20191017)
Merge: 46d6930f8 9ab3876b4
Author: Emil Engler <[email protected]>
Date:   Wed Oct 16 21:36:43 2019 +0000

    Merge 9ab3876b43d45e8d742adcad996537b2dcbacff3 into 46d6930f8c7ba7cbcd7d86dd5d0117642fcbc819

$ src/qt/bitcoin-qt -prune=42000

cvengler · 2019-10-17T11:38:28Z

@hebasto Fixed and tested heavily

src/qt/intro.cpp

src/qt/intro.h

cvengler · 2019-10-17T16:13:23Z

@hebasto Updated

hebasto · 2019-10-17T16:31:23Z

src/qt/intro.cpp

This is inconsistent with

bitcoin/src/init.cpp

Lines 386 to 388 in ec3ed5a

gArgs.AddArg("-prune=<n>", strprintf("Reduce storage requirements by enabling pruning (deleting) of old blocks. This allows the pruneblockchain RPC to be called to delete specific blocks, and enables automatic pruning of old blocks if a target size in MiB is provided. This mode is incompatible with -txindex and -rescan. "

"Warning: Reverting this setting requires re-downloading the entire blockchain. "

"(default: 0 = disable pruning blocks, 1 = allow manual pruning via RPC, >=%u = automatically prune block files to stay under the specified target size in MiB)", MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);

Ok, then I will change everything to Mebibyte

MiB is indeed consistent with other places, but you should also change uint64_t GB_BYTES{1000000000} to uint64_t GiB_BYTES{1073741824}. But that impacts the settings screen. Probably better to leave this change for another PR.

Instead of doing ad-hoc calculations everywhere, I'd strongly encourage using the following well-defined PruneGBtoMiB and PruneMiBtoGB functions (from #15936) for this:

bitcoin/src/qt/optionsmodel.h

Lines 24 to 25 in 0ab41dd

static inline int64_t PruneGBtoMiB(int gb) { return gb * GB_BYTES / 1024 / 1024; }

static inline int PruneMiBtoGB(int64_t mib) { return (mib * 1024 * 1024 + GB_BYTES - 1) / GB_BYTES; }

This would increase readability and prevent bugs and let us be sure when we migrate this setting out of qsettings that round trips between units work will correctly (e.g. 3GB -> 2861 MiB -> 3GB not 2GB)

MiB is indeed consistent with other places, but you should also change uint64_t GB_BYTES{1000000000} to uint64_t GiB_BYTES{1073741824}. But that impacts the settings screen. Probably better to leave this change for another PR.

I'm not sure what the goal of this change would be, and would definitely think it should be done as separately from this PR. ~~The existing conversions in this PR as of f3108a0 look correct to me~~, and I'd expect normal users to be more familiar with GB than GiB. Also if a user sees a GiB value and mistakenly interprets it as a GB value their node will use more storage than expected and maybe lead to problems.

EDIT: f3108a0 does actually have some buggy conversions I missed the first pass, see #17035 (review), but this tangential to the point about wanting to stick to GB instead of switching to GiB.

cvengler · 2019-10-17T17:55:42Z

@hebasto Fixed, however it will now round down if you prune, this should be correct behavior because it's now a slightly different unit

Sjors

Concept ACK. I don't think the original behavior is a bug, but this PR does make things more clear. The intro dialog explained how much space is needed without pruning, and then offers to reduce that if you do prune. It's nice that it now updates the amounts and colors.

"GB needed for full chain" needs to be " GB needed for pruned chain" when prune is checked.

I suggest quashing these commits. Perhaps start with a commit that introduces setSizeWarningLabel and adds member variables, but doesn't change behavior. That way it's more clear what behavior you're changing.

Sjors · 2019-10-22T14:25:34Z

src/qt/intro.cpp

Move to start of function, otherwise storageRequiresMsg will have the wrong amount.

Nope, see L352-354

Not sure what's to see there?

Everywhere it says 3 GB it should say 5 GB; 2 GB pruning + 3 GB chainstate (m_assumed_chain_state_size).

This has never been a very precise number because 3 GB more or less didn't matter, but with pruning we should show the correct numbers.

Oh now I understand what you mean.
Will work on that tomorrow

@ryanofsky These functions are not existent in my branch.
Should I copy them?

@ryanofsky These functions are not existent in my branch.
Should I copy them?

Yes, that's why I linked to my branch.

This fixes the bug of the required amount of storage in the intro screen

cvengler · 2019-10-22T15:02:46Z

Squashed

Sjors · 2019-10-22T16:26:56Z

src/qt/intro.cpp

+    QString storageRequiresMsg = QObject::tr("At least %1 GB of data will be stored in this directory, and it will grow over time.");
+    if (ui->prune->isChecked()) {
+        uint64_t prunedGBs = std::ceil(m_prune_target * 1024 * 1024 / GB_BYTES);
+        if (prunedGBs <= requiredSpace) {


This should check prunedGBs + m_chain_state_size <= requiredSpace (assuming you add m_chain_state_size to requiredSpace earlier).

ryanofsky · 2019-10-22T16:09:15Z

src/qt/intro.cpp

-        tr("The wallet will also be stored in this directory.")
-    );
+    setSizeWarningLabel();
+    m_prune_target = m_prune_target ? m_prune_target / 1024 : 2;


This is doing a conversion from MiB to GiB not GB. Also it is rounding down instead of up, which means round trips between two units are not stable. (Maybe not a problem for this PR since it is a one-time conversion, but definitely a problem for #12833 and #15936 which need consistent repeatable conversions.)

Would suggest:

Renaming this variable from m_prune_target to m_prune_target_gb to be clear about units it is supposed to contain.

Switching a temporary int64_t prune_target_mib variable above to hold the -prune value.

Changing this line to m_prune_target_gb = prune_target_mib ? PruneMiBtoGB(prune_target_mib) : 2 using the PruneGBtoMiB function below (orignally from interfaces: Expose settings.json methods to GUI #15936)

bitcoin/src/qt/optionsmodel.h

Lines 24 to 25 in 0ab41dd

static inline int64_t PruneGBtoMiB(int gb) { return gb * GB_BYTES / 1024 / 1024; }

static inline int PruneMiBtoGB(int64_t mib) { return (mib * 1024 * 1024 + GB_BYTES - 1) / GB_BYTES; }

ryanofsky · 2019-10-22T16:31:26Z

src/qt/intro.cpp

+    requiredSpace = m_blockchain_size;
+    QString storageRequiresMsg = QObject::tr("At least %1 GB of data will be stored in this directory, and it will grow over time.");
+    if (ui->prune->isChecked()) {
+        uint64_t prunedGBs = std::ceil(m_prune_target * 1024 * 1024 / GB_BYTES);


Maybe I'm misunderstanding the flow, but it seems like there a bug here. This code is trying to convert m_prune_target from mib to gb when m_prune_target would already contain gib after running the code in the constructor.

cvengler · 2019-10-22T19:45:19Z

@Sjors @ryanofsky
Will patch your changes into the code tomorrow. So this can finally get merged...
Thanks for your reviews!

ryanofsky · 2019-10-22T20:17:49Z

So this can finally get merged

Most of the reviews on the high-priority list are older than this, for some perspective: https://github.com/bitcoin/bitcoin/projects/8. More reviewers -> faster merges, of course.

Sjors · 2019-10-23T08:25:06Z

I don't think it's necessary to hold back the next release candidate for this. It can go into v0.19.1 if it doesn't make the cut.

cvengler · 2019-10-23T13:09:47Z

@Sjors There is still one and a half week, thats probably enough time

Sjors · 2019-10-23T13:26:37Z

@emilengler there's no official timetable. Usually we decide during the IRC meeting to ship a new release candidate when it looks like the most important bugs are squashed. Then we wait another week or so, and do another release candidate if new bugs were found. Otherwise the last candidate becomes the final version.

laanwj · 2019-10-24T11:40:39Z

I don't regard this as a blocker for the release either. IMO we'll cut rc2 without this. It would be nice to have, but it seems to be slightly controversial whether this is the right solution, has unaddressed comments, and it has garnered no ACKs yet.

…oggled 4f7127d gui: Make Intro consistent with prune checkbox (Hennadii Stepanov) 4824a7d gui: Add Intro::UpdateFreeSpaceLabel() (Hennadii Stepanov) daa3f3f refactor: Add Intro::UpdatePruneLabels() (Hennadii Stepanov) e4caa82 refactor: Replace static variable with data member (Hennadii Stepanov) 2bede28 util: Add PruneGBtoMiB() function (Hennadii Stepanov) e35e4b2 util: Add PruneMiBtoGB() function (Hennadii Stepanov) Pull request description: On master (a6f6333) and on 0.19.0.1 the intro dialog with prune enabled (checkbox "Discard blocks..." is checked) provides a user with wrong info about the required disk space: ![DeepinScreenshot_bitcoin-qt_20191208112228](https://user-images.githubusercontent.com/32963518/70387510-8daab400-19ae-11ea-9338-29add9c31118.png) Also the paragraph "If you have chosen to limit..." is missed. --- With this PR when prune checkbox is toggled, the related text labels and the amount of required space shown are updated (previously they were only updated when the data directory was updated): ![Screenshot from 2019-12-08 11-34-53](https://user-images.githubusercontent.com/32963518/70387542-eed28780-19ae-11ea-9565-49d8a64b2f33.png) --- This PR is an alternative to #17035. **ryanofsky**'s [suggestion](#17035 (comment)) also has been implemented. ACKs for top commit: emilengler: ACK 4f7127d Sjors: tACK 4f7127d ryanofsky: Code review ACK 4f7127d. It seems like there are a few visible changes here: jonasschnelli: utACK 4f7127d Tree-SHA512: fa0bbdcfafde97d7906cda066cbd4608b936a71cae1b4cda3ee3aa2eed3a9795f279f14c6b1b4997278e094db891c7d3bb695368ba0882347aa42165a86e5172

…on is toggled 4f7127d gui: Make Intro consistent with prune checkbox (Hennadii Stepanov) 4824a7d gui: Add Intro::UpdateFreeSpaceLabel() (Hennadii Stepanov) daa3f3f refactor: Add Intro::UpdatePruneLabels() (Hennadii Stepanov) e4caa82 refactor: Replace static variable with data member (Hennadii Stepanov) 2bede28 util: Add PruneGBtoMiB() function (Hennadii Stepanov) e35e4b2 util: Add PruneMiBtoGB() function (Hennadii Stepanov) Pull request description: On master (a6f6333) and on 0.19.0.1 the intro dialog with prune enabled (checkbox "Discard blocks..." is checked) provides a user with wrong info about the required disk space: ![DeepinScreenshot_bitcoin-qt_20191208112228](https://user-images.githubusercontent.com/32963518/70387510-8daab400-19ae-11ea-9338-29add9c31118.png) Also the paragraph "If you have chosen to limit..." is missed. --- With this PR when prune checkbox is toggled, the related text labels and the amount of required space shown are updated (previously they were only updated when the data directory was updated): ![Screenshot from 2019-12-08 11-34-53](https://user-images.githubusercontent.com/32963518/70387542-eed28780-19ae-11ea-9565-49d8a64b2f33.png) --- This PR is an alternative to bitcoin#17035. **ryanofsky**'s [suggestion](bitcoin#17035 (comment)) also has been implemented. ACKs for top commit: emilengler: ACK 4f7127d Sjors: tACK 4f7127d ryanofsky: Code review ACK 4f7127d. It seems like there are a few visible changes here: jonasschnelli: utACK 4f7127d Tree-SHA512: fa0bbdcfafde97d7906cda066cbd4608b936a71cae1b4cda3ee3aa2eed3a9795f279f14c6b1b4997278e094db891c7d3bb695368ba0882347aa42165a86e5172

…s toggled Summary: 4f7127d1e3a51f0f55d42a08439c516dcc8d1a26 gui: Make Intro consistent with prune checkbox (Hennadii Stepanov) 4824a7d36cf47e766865e0fefe952ec860eb82dd gui: Add Intro::UpdateFreeSpaceLabel() (Hennadii Stepanov) daa3f3fa9071a229275dd6a1b8445237ddc3fa97 refactor: Add Intro::UpdatePruneLabels() (Hennadii Stepanov) e4caa82a03df5c6a6d5d29f34ab006d732c6dac1 refactor: Replace static variable with data member (Hennadii Stepanov) 2bede28cd9ec638d8bb32c187ccf12d89345218e util: Add PruneGBtoMiB() function (Hennadii Stepanov) e35e4b2ba052c9a533626286026dbe0a2d546c5b util: Add PruneMiBtoGB() function (Hennadii Stepanov) Pull request description: On master (a6f6333ba253cda83221ee529810cacf930e413f) and on 0.19.0.1 the intro dialog with prune enabled (checkbox "Discard blocks..." is checked) provides a user with wrong info about the required disk space: ![DeepinScreenshot_bitcoin-qt_20191208112228](https://user-images.githubusercontent.com/32963518/70387510-8daab400-19ae-11ea-9338-29add9c31118.png) Also the paragraph "If you have chosen to limit..." is missed. --- With this PR when prune checkbox is toggled, the related text labels and the amount of required space shown are updated (previously they were only updated when the data directory was updated): ![Screenshot from 2019-12-08 11-34-53](https://user-images.githubusercontent.com/32963518/70387542-eed28780-19ae-11ea-9565-49d8a64b2f33.png) --- This PR is an alternative to #17035. **ryanofsky**'s [suggestion](bitcoin/bitcoin#17035 (comment)) also has been implemented. --- Backport of Core [[bitcoin/bitcoin#17453 | PR17453]] Depends on D8913 Test Plan: ninja all check check-functional ./src/qt/bitcoin-qt -choosedatadir check that correct information is provided, whether prune checkbox is ticked or not Reviewers: #bitcoin_abc, PiRK Reviewed By: #bitcoin_abc, PiRK Subscribers: PiRK Differential Revision: https://reviews.bitcoinabc.org/D8914

fanquake added the GUI label Oct 3, 2019

maflcko added this to the 0.19.0 milestone Oct 3, 2019

maflcko added Needs backport labels Oct 3, 2019

promag reviewed Oct 3, 2019

View reviewed changes

src/qt/intro.cpp Outdated Show resolved Hide resolved

src/qt/intro.cpp Outdated Show resolved Hide resolved

DrahtBot removed the Needs gitian build label Oct 4, 2019

bitcoin deleted a comment from DrahtBot Oct 4, 2019

hebasto reviewed Oct 5, 2019

View reviewed changes

src/qt/intro.cpp Outdated Show resolved Hide resolved

src/qt/intro.cpp Outdated Show resolved Hide resolved

hebasto reviewed Oct 5, 2019

View reviewed changes

src/qt/intro.cpp Outdated Show resolved Hide resolved

cvengler requested a review from promag October 6, 2019 04:51

hebasto requested changes Oct 6, 2019

View reviewed changes

src/qt/intro.cpp Outdated Show resolved Hide resolved

src/qt/intro.h Outdated Show resolved Hide resolved

hebasto reviewed Oct 6, 2019

View reviewed changes

src/qt/intro.h Outdated Show resolved Hide resolved

hebasto requested changes Oct 17, 2019

View reviewed changes

src/qt/intro.cpp Outdated Show resolved Hide resolved

src/qt/intro.h Outdated Show resolved Hide resolved

hebasto reviewed Oct 17, 2019

View reviewed changes

Sjors suggested changes Oct 22, 2019

View reviewed changes

qt: Fix text display when state of prune button is changed

f3108a0

This fixes the bug of the required amount of storage in the intro screen

Sjors reviewed Oct 22, 2019

View reviewed changes

ryanofsky reviewed Oct 22, 2019

View reviewed changes

laanwj modified the milestones: 0.19.0, 0.19.1 Oct 25, 2019

cvengler closed this Nov 11, 2019

cvengler deleted the 2019-10-qt-intro-prune-text-update-fix branch November 11, 2019 16:28

hebasto mentioned this pull request Nov 12, 2019

gui: Fix intro dialog labels when the prune button is toggled #17453

Merged

fanquake removed the Needs backport (0.19) label Nov 14, 2019

fanquake removed this from the 0.19.1 milestone Nov 14, 2019

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

	gArgs.AddArg("-prune=<n>", strprintf("Reduce storage requirements by enabling pruning (deleting) of old blocks. This allows the pruneblockchain RPC to be called to delete specific blocks, and enables automatic pruning of old blocks if a target size in MiB is provided. This mode is incompatible with -txindex and -rescan. "
	"Warning: Reverting this setting requires re-downloading the entire blockchain. "
	"(default: 0 = disable pruning blocks, 1 = allow manual pruning via RPC, >=%u = automatically prune block files to stay under the specified target size in MiB)", MIN_DISK_SPACE_FOR_BLOCK_FILES / 1024 / 1024), ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS);

	static inline int64_t PruneGBtoMiB(int gb) { return gb * GB_BYTES / 1024 / 1024; }
	static inline int PruneMiBtoGB(int64_t mib) { return (mib * 1024 * 1024 + GB_BYTES - 1) / GB_BYTES; }

qt: Fix text display when state of prune button is changed #17035

qt: Fix text display when state of prune button is changed #17035

Uh oh!

Conversation

cvengler commented Oct 3, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hebasto left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cvengler commented Oct 6, 2019

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hebasto Oct 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cvengler commented Oct 6, 2019

Uh oh!

Uh oh!

hebasto commented Oct 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cvengler commented Oct 7, 2019

Uh oh!

hebasto commented Oct 7, 2019

Uh oh!

cvengler commented Oct 7, 2019

Uh oh!

jonasschnelli commented Oct 8, 2019

Uh oh!

promag commented Oct 9, 2019

Uh oh!

cvengler commented Oct 9, 2019

Uh oh!

cvengler commented Oct 9, 2019

Uh oh!

cvengler commented Oct 14, 2019

Uh oh!

hebasto commented Oct 15, 2019

Uh oh!

cvengler commented Oct 15, 2019

Uh oh!

cvengler commented Oct 16, 2019

Uh oh!

hebasto commented Oct 17, 2019

Uh oh!

cvengler commented Oct 17, 2019

Uh oh!

Uh oh!

Uh oh!

cvengler commented Oct 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sjors Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ryanofsky Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

cvengler commented Oct 3, 2019 •

edited

Loading

hebasto left a comment •

edited

Loading

hebasto Oct 6, 2019 •

edited

Loading

hebasto commented Oct 6, 2019 •

edited

Loading

Sjors Oct 22, 2019 •

edited

Loading

ryanofsky Oct 22, 2019 •

edited

Loading

Sjors Oct 22, 2019 •

edited

Loading

Sjors Oct 22, 2019 •

edited

Loading

ryanofsky Oct 22, 2019 •

edited

Loading