gui: only call getOrCreateWallet if wallet interface pointer not null #16955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids early call to loadwallet crashing bitcoin-qt (bitcoin#16937)
promag
reviewed
Sep 24, 2019
| { | ||
| m_handler_load_wallet = m_node.handleLoadWallet([this](std::unique_ptr<interfaces::Wallet> wallet) { | ||
| getOrCreateWallet(std::move(wallet)); | ||
| if (wallet) getOrCreateWallet(std::move(wallet)); |
Contributor
There was a problem hiding this comment.
In what case wallet is null?
Contributor
There was a problem hiding this comment.
See line 95 in qt/walletcontroller.cpp
There it checks if the wallet is empty even though it isn't null (I think).
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
Okay. Care to elaborate?
Contributor
There was a problem hiding this comment.
Sorry, forgot to update this, see #16963.
Note that conceptually you are being notified about a new wallet, it should exist! Also this change hides a more severe problem which is explained in my PR.
Contributor
Author
There was a problem hiding this comment.
Thanks, closing this now in favour of #16963.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid early call to
loadwalletcrashing bitcoin-qt. Meant to fix #16937.