test: Add generatetodescriptor RPC #16943
Conversation
|
This has also been requested by @harding (https://twitter.com/hrdng/status/1101924904990056448). And everyone who liked that tweet, obviously. |
maflcko
force-pushed
the
1909-rpcMiningDescriptor
branch
from
fa20684 to
fa64e2d
Compare
|
concept ACK |
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
|
I'm a bit ambivalent about extending the internal miner after so much effort over time to reduce it or even get rid of it. But if this helps testing, sure, concept ACK. |
|
tested ACK |
maflcko
force-pushed
the
1909-rpcMiningDescriptor
branch
from
fa64e2d to
fada009
Compare
src/rpc/mining.cpp
Outdated
There was a problem hiding this comment.
As it is test-only, it should probably be hidden from the normal help.
There was a problem hiding this comment.
generatetoaddress isn't hidden, so I used the same. Otherwise it would also be missing from the gui-autocomplete.
|
Needs update after #17192, I guess. |
maflcko
force-pushed
the
1909-rpcMiningDescriptor
branch
from
fada009 to
fa144e6
Compare
|
Rebased for |
|
ACK fa144e6 |
fa144e6 rpc: Add generatetodescriptor (MarcoFalke) Pull request description: The existing `generatetoaddress` RPC can only generate to scriptPubKeys that can be represented by an address. However, raw scripts (such as `OP_TRUE`) or P2PK can not be represented by an address, which complicates testing. ACKs for top commit: laanwj: ACK fa144e6 Tree-SHA512: aee934ab7e33f07c81f3b4c8ec23e7b6ddf63a1f4b86051af0bd76b75d8da1f51627cc682e5c6e42582340ca576bbf8ff724bdd43f87128ccecfa91e52d30ae7
Summary: ``` The existing generatetoaddress RPC can only generate to scriptPubKeys that can be represented by an address. However, raw scripts (such as OP_TRUE) or P2PK can not be represented by an address, which complicates testing. ``` Backport of core [[bitcoin/bitcoin#16943 | PR16943]]. Depends on D7983. Test Plan: ninja all check-all Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7984
6 participants
The existing
generatetoaddressRPC can only generate to scriptPubKeys that can be represented by an address. However, raw scripts (such asOP_TRUE) or P2PK can not be represented by an address, which complicates testing.