test: Add notes on how to generate data/wallets/high_minversion #16845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
promag
reviewed
Sep 15, 2019
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Code review ACK, instructions LGTM.
fanquake
approved these changes
Sep 16, 2019
Member
fanquake
left a comment
fanquake
left a comment
There was a problem hiding this comment.
ACK fabe4304f484f6da7e7ac3d28921d1ceb7ac93d6
maflcko
force-pushed
the
1909-docTestGenWalletDataHighMinVersion
branch
from
fabe430 to
2222c96
Compare
ryanofsky
approved these changes
Sep 16, 2019
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Sep 16, 2019
…high_minversion 2222c96 test: Add notes on how to generate data/wallets/high_minversion (MarcoFalke) Pull request description: I forgot to do this in bitcoin#16796 ACKs for top commit: ryanofsky: ACK 2222c96 Tree-SHA512: 5f24ffa641b97eac4febad42ade7228b14fa72335c918a10880c5dec86a3ecc3075a31526f275188e07fea95b8e2c6320c64f716099f604b00e13d5366fcee37
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 16, 2019
…high_minversion 2222c96 test: Add notes on how to generate data/wallets/high_minversion (MarcoFalke) Pull request description: I forgot to do this in bitcoin#16796 ACKs for top commit: ryanofsky: ACK 2222c96 Tree-SHA512: 5f24ffa641b97eac4febad42ade7228b14fa72335c918a10880c5dec86a3ecc3075a31526f275188e07fea95b8e2c6320c64f716099f604b00e13d5366fcee37
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 21, 2020
…_minversion Summary: Add instructions related to creating test data introduced in [[bitcoin/bitcoin#16976 | PR16976]] (D7053) This is a backport of Core [[bitcoin/bitcoin#16845 | PR16845]] Test Plan: Proof-reading Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Subscribers: Fabien Differential Revision: https://reviews.bitcoinabc.org/D8016
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 1, 2021
…high_minversion 2222c96 test: Add notes on how to generate data/wallets/high_minversion (MarcoFalke) Pull request description: I forgot to do this in bitcoin#16796 ACKs for top commit: ryanofsky: ACK 2222c96 Tree-SHA512: 5f24ffa641b97eac4febad42ade7228b14fa72335c918a10880c5dec86a3ecc3075a31526f275188e07fea95b8e2c6320c64f716099f604b00e13d5366fcee37
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 11, 2021
…high_minversion 2222c96 test: Add notes on how to generate data/wallets/high_minversion (MarcoFalke) Pull request description: I forgot to do this in bitcoin#16796 ACKs for top commit: ryanofsky: ACK 2222c96 Tree-SHA512: 5f24ffa641b97eac4febad42ade7228b14fa72335c918a10880c5dec86a3ecc3075a31526f275188e07fea95b8e2c6320c64f716099f604b00e13d5366fcee37
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to do this in #16796