Refactor rawtransaction_util's SignTransaction to separate prevtx parsing #16798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsing be separate
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
ryanofsky
approved these changes
Sep 4, 2019
Contributor
There was a problem hiding this comment.
utACK 39034f1. No change since previously reviewed b49bbb939be92a67ff77c3f7bca5bb94dd141906, #16341 (review) other than rebase with no conflicts.
Member
|
ACK 39034f1 Show signature and timestampSignature: Timestamp of file with hash |
Member
|
utACK 39034f1 |
fanquake
added a commit
that referenced
this pull request
Sep 7, 2019
…ate prevtx parsing 39034f1 Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate (Andrew Chow) Pull request description: Currently the `SignTransaction` function has to handle both the actual signing and parsing of previous transaction data. This PR splits it so that `SignTransaction` only handles the signing itself and adds a `ParsePrevouts` function which handles parsing the prevtx information. This allows for `SignTransaction` to just take any `SigningProvider`. Split from #16341 ACKs for top commit: MarcoFalke: ACK 39034f1 instagibbs: utACK 39034f1 ryanofsky: utACK 39034f1. No change since previously reviewed b49bbb939be92a67ff77c3f7bca5bb94dd141906, #16341 (review) other than rebase with no conflicts. Tree-SHA512: 09f7733e90691766bfb5cf0f20e913dbf270bd3b51abdcad966b24d110e562ed85fd3d0d1d7bbea61f903340060052ec73c4817b09aee0dc1f3916d781a9e40c
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Sep 10, 2019
…o separate prevtx parsing 39034f1 Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate (Andrew Chow) Pull request description: Currently the `SignTransaction` function has to handle both the actual signing and parsing of previous transaction data. This PR splits it so that `SignTransaction` only handles the signing itself and adds a `ParsePrevouts` function which handles parsing the prevtx information. This allows for `SignTransaction` to just take any `SigningProvider`. Split from bitcoin#16341 ACKs for top commit: MarcoFalke: ACK 39034f1 instagibbs: utACK bitcoin@39034f1 ryanofsky: utACK 39034f1. No change since previously reviewed b49bbb939be92a67ff77c3f7bca5bb94dd141906, bitcoin#16341 (review) other than rebase with no conflicts. Tree-SHA512: 09f7733e90691766bfb5cf0f20e913dbf270bd3b51abdcad966b24d110e562ed85fd3d0d1d7bbea61f903340060052ec73c4817b09aee0dc1f3916d781a9e40c
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Aug 5, 2020
…parate prevtx parsing Summary: Refactor rawtransaction_util's SignTransaction to have previous tx parsing be separate (Andrew Chow) Pull request description: Currently the `SignTransaction` function has to handle both the actual signing and parsing of previous transaction data. This PR splits it so that `SignTransaction` only handles the signing itself and adds a `ParsePrevouts` function which handles parsing the prevtx information. This allows for `SignTransaction` to just take any `SigningProvider`. Split from #16341 --- Backport of Core [[bitcoin/bitcoin#16798 | PR16798]] Depends on D7114 Test Plan: ninja check check-functional Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7118
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 22, 2020
Summary: The param coins to SignTransaction is final and can thus not be extended (as suggested by the doc). This was changed in [[bitcoin/bitcoin#16798 | PR16798]] where ParsePrevouts was extracted from SignTransaction. This is a backport of Core [[bitcoin/bitcoin#16900 | PR16900]] Test Plan: `ninja && ninja check` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8053
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
SignTransactionfunction has to handle both the actual signing and parsing of previous transaction data. This PR splits it so thatSignTransactiononly handles the signing itself and adds aParsePrevoutsfunction which handles parsing the prevtx information.This allows for
SignTransactionto just take anySigningProvider.Split from #16341