qt: Replace deprecated QSignalMapper by lambda expressions #16706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QSignalMapper class is obsolete since Qt 5.10.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
Member
|
QSignalMapper has actually been un-deprecated, see QSignalMapper deprecation and Un-deprecate QSignalMapper. However Concept ACK assuming there's no change in behaviour and the new code is still compatible with Qt |
Member
Author
I didn't know about that. Thank you. From Un-deprecate QSignalMapper:
FWIW, this PR is a part of my work on warnings raised during compiling on Bionic against Qt 5.13. |
Contributor
|
Concept ACK -- more readable and less code |
promag
reviewed
Aug 25, 2019
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
Concept ACK.
Are the style changes really necessary? I'd prefer just dropping QSignalMapper.
The QSignalMapper class is obsolete since Qt 5.10.
hebasto
force-pushed
the
20190824-obsolete-qsignalmapper
branch
from
c4e40a4 to
0912134
Compare
Member
Author
Done. |
Contributor
|
Concept ACK |
Contributor
|
Gitian builds for commit db67101 (master):
Gitian builds for commit e05543dbcf87fb9c057d9c652835d85c25a2cb3e (master and this pull):
|
laanwj
added a commit
that referenced
this pull request
Aug 29, 2019
0912134 qt: Remove QSignalMapper from TransactionView (Hennadii Stepanov) 9e0c1d6 qt: Remove QSignalMapper from RPCConsole (Hennadii Stepanov) Pull request description: The [`QSignalMapper`](https://doc.qt.io/qt-5/qsignalmapper.html) class has been [deprecated](https://doc-snapshots.qt.io/qt5-5.10/obsoleteclasses.html) since Qt 5.10. This PR replaces it by lambdas and does not change behavior. ACKs for top commit: jonasschnelli: utACK 0912134 Tree-SHA512: 0c102d5cab4adc8b6252f72e07123ac87c65434c88cada3e72816ecea8fc4803f15b9c050fb5e1c7e8a96f709265521fd6813ab1890dbf5634032f7ee0d50675
Member
|
Post merge ACK. This totally gets rid of the flood of warnings on macOs with QT 5.13 from homebrew. It's also shorter and more readable. Tested that external explorer links still work, as well as banning peers. Building with depends (QT 5.9.7) also works, though this still throws trillions of (unrelated) warnings. |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 29, 2019
…xpressions 0912134 qt: Remove QSignalMapper from TransactionView (Hennadii Stepanov) 9e0c1d6 qt: Remove QSignalMapper from RPCConsole (Hennadii Stepanov) Pull request description: The [`QSignalMapper`](https://doc.qt.io/qt-5/qsignalmapper.html) class has been [deprecated](https://doc-snapshots.qt.io/qt5-5.10/obsoleteclasses.html) since Qt 5.10. This PR replaces it by lambdas and does not change behavior. ACKs for top commit: jonasschnelli: utACK 0912134 Tree-SHA512: 0c102d5cab4adc8b6252f72e07123ac87c65434c88cada3e72816ecea8fc4803f15b9c050fb5e1c7e8a96f709265521fd6813ab1890dbf5634032f7ee0d50675
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 12, 2020
Summary: ``` The QSignalMapper class has been deprecated since Qt 5.10. This PR replaces it by lambdas and does not change behavior. ``` Backport of core [[bitcoin/bitcoin#16706 | PR16706]]. Test Plan: With Qt >= 5.10 and <= 5.13 ninja all check Check the warnings are gone Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7887
barton2526
added a commit
to barton2526/Gridcoin-Research
that referenced
this pull request
Jun 24, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 4, 2021
kwvg
added a commit
to kwvg/dash
that referenced
this pull request
Nov 11, 2021
pravblockc
pushed a commit
to pravblockc/dash
that referenced
this pull request
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
QSignalMapperclass has been deprecated since Qt 5.10.This PR replaces it by lambdas and does not change behavior.