Skip to content

Conversation

@fanquake
Copy link
Member

This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (#6900).
However, it should no longer be required, as we have switched to Bionic (#13171) and that
has a far newer version of binutils.

Original discussion: #6900
binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

@maflcko
Copy link
Member

maflcko commented Aug 21, 2019

Fails with

Options used to compile and link:
  with wallet   = yes
  with gui / qt = yes
    with bip70  = yes
    with qr     = yes
  with zmq      = yes
  with test     = yes
    with prop   = no
    with fuzz   = no
  with bench    = no
  with upnp     = yes
  use asm       = yes
  sanitizers    = 
  debug enabled = no
  gprof enabled = no
  werror        = no

  target os     = windows
  build os      = 

  CC            = x86_64-w64-mingw32-gcc
  CFLAGS        = -pipe -O2 -O2 -g
  CPPFLAGS      =   -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -I/home/ubuntu/build/bitcoin/depends/x86_64-w64-mingw32/share/../include/  -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -D_MT -DWIN32 -D_WINDOWS -DBOOST_THREAD_USE_LIB -D_WIN32_WINNT=0x0601 -D_FILE_OFFSET_BITS=64
  CXX           = x86_64-w64-mingw32-g++ -std=c++11
  CXXFLAGS      =   -fstack-reuse=none -Wstack-protector -fstack-protector-all     -pipe -O2 -O2 -g -fvisibility=hidden
  LDFLAGS       = -pthread  -Wl,--dynamicbase -Wl,--nxcompat -Wl,--high-entropy-va -pie  -L/home/ubuntu/build/bitcoin/depends/x86_64-w64-mingw32/share/../lib 
  ARFLAGS       = cr

+ make -j1
Making all in src
make[1]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
make[2]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
  CXX      support/libbitcoinconsensus_la-cleanse.lo
  CXX      crypto/libbitcoinconsensus_la-aes.lo
  CXX      crypto/libbitcoinconsensus_la-chacha_poly_aead.lo
  CXX      crypto/libbitcoinconsensus_la-chacha20.lo
  CXX      crypto/libbitcoinconsensus_la-hkdf_sha256_32.lo
  CXX      crypto/libbitcoinconsensus_la-hmac_sha256.lo
  CXX      crypto/libbitcoinconsensus_la-hmac_sha512.lo
  CXX      crypto/libbitcoinconsensus_la-poly1305.lo
  CXX      crypto/libbitcoinconsensus_la-ripemd160.lo
  CXX      crypto/libbitcoinconsensus_la-sha1.lo
  CXX      crypto/libbitcoinconsensus_la-sha256.lo
  CXX      crypto/libbitcoinconsensus_la-sha512.lo
  CXX      crypto/libbitcoinconsensus_la-siphash.lo
  CXX      crypto/libbitcoinconsensus_la-sha256_sse4.lo
  CXX      libbitcoinconsensus_la-arith_uint256.lo
  CXX      consensus/libbitcoinconsensus_la-merkle.lo
  CXX      consensus/libbitcoinconsensus_la-tx_check.lo
  CXX      libbitcoinconsensus_la-hash.lo
  CXX      primitives/libbitcoinconsensus_la-block.lo
  CXX      primitives/libbitcoinconsensus_la-transaction.lo
  CXX      libbitcoinconsensus_la-pubkey.lo
  CXX      script/libbitcoinconsensus_la-bitcoinconsensus.lo
  CXX      script/libbitcoinconsensus_la-interpreter.lo
  CXX      script/libbitcoinconsensus_la-script.lo
  CXX      script/libbitcoinconsensus_la-script_error.lo
  CXX      libbitcoinconsensus_la-uint256.lo
  CXX      util/libbitcoinconsensus_la-strencodings.lo
make[3]: Entering directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src/secp256k1'
gcc -I. -g -O2 -Wall -Wextra -Wno-unused-function -c src/gen_context.c -o gen_context.o
gcc -g -O2 -Wall -Wextra -Wno-unused-function  gen_context.o -o gen_context
./gen_context
  CC       src/libsecp256k1_la-secp256k1.lo
  CCLD     libsecp256k1.la
libtool: warning: undefined symbols not allowed in x86_64-w64-mingw32 shared libraries; building static only
/usr/bin/x86_64-w64-mingw32-ar: `u' modifier ignored since `D' is the default (see `U')
make[3]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src/secp256k1'
  CXXLD    libbitcoinconsensus.la
/usr/bin/x86_64-w64-mingw32-ar: `u' modifier ignored since `D' is the default (see `U')
  CXX      bitcoind-bitcoind.o
In file included from ./util/system.h:21:0,
                 from ./init.h:11,
                 from bitcoind.cpp:14:
./logging.h:63:22: error: ‘mutex’ in namespace ‘std’ does not name a type
         mutable std::mutex m_cs;                   // Can not use Mutex from sync.h because in debug mode it would cause a deadlock when a potential deadlock was detected
                      ^~~~~
In file included from ./util/system.h:21:0,
                 from ./init.h:11,
                 from bitcoind.cpp:14:
./logging.h: In member function ‘bool BCLog::Logger::Enabled() const’:
./logging.h:97:34: error: ‘mutex’ is not a member of ‘std’
             std::lock_guard<std::mutex> scoped_lock(m_cs);
                                  ^~~~~
./logging.h:97:34: error: ‘mutex’ is not a member of ‘std’
./logging.h:97:39: error: template argument 1 is invalid
             std::lock_guard<std::mutex> scoped_lock(m_cs);
                                       ^
./logging.h:97:53: error: ‘m_cs’ was not declared in this scope
             std::lock_guard<std::mutex> scoped_lock(m_cs);
                                                     ^~~~
In file included from ./util/system.h:22:0,
                 from ./init.h:11,
                 from bitcoind.cpp:14:
./sync.h: At global scope:
./sync.h:107:44: error: ‘recursive_mutex’ is not a member of ‘std’
 using RecursiveMutex = AnnotatedMixin<std::recursive_mutex>;
                                            ^~~~~~~~~~~~~~~
./sync.h:107:44: error: ‘recursive_mutex’ is not a member of ‘std’
./sync.h:107:59: error: template argument 1 is invalid
 using RecursiveMutex = AnnotatedMixin<std::recursive_mutex>;
                                                           ^
./sync.h:108:29: error: ‘recursive_mutex’ is not a member of ‘std’
 typedef AnnotatedMixin<std::recursive_mutex> CCriticalSection;
                             ^~~~~~~~~~~~~~~
./sync.h:108:29: error: ‘recursive_mutex’ is not a member of ‘std’
./sync.h:108:44: error: template argument 1 is invalid
 typedef AnnotatedMixin<std::recursive_mutex> CCriticalSection;
                                            ^
./sync.h:111:29: error: ‘mutex’ is not a member of ‘std’
 typedef AnnotatedMixin<std::mutex> Mutex;
                             ^~~~~
./sync.h:111:29: error: ‘mutex’ is not a member of ‘std’
./sync.h:111:34: error: template argument 1 is invalid
 typedef AnnotatedMixin<std::mutex> Mutex;
                                  ^
./sync.h:214:10: error: ‘condition_variable’ in namespace ‘std’ does not name a type
     std::condition_variable condition;
          ^~~~~~~~~~~~~~~~~~
./sync.h:215:10: error: ‘mutex’ in namespace ‘std’ does not name a type
     std::mutex mutex;
          ^~~~~
./sync.h: In member function ‘void CSemaphore::wait()’:
./sync.h:223:31: error: ‘mutex’ is not a member of ‘std’
         std::unique_lock<std::mutex> lock(mutex);
                               ^~~~~
./sync.h:223:31: error: ‘mutex’ is not a member of ‘std’
./sync.h:223:36: error: template argument 1 is invalid
         std::unique_lock<std::mutex> lock(mutex);
                                    ^
./sync.h:223:43: error: ‘mutex’ was not declared in this scope
         std::unique_lock<std::mutex> lock(mutex);
                                           ^~~~~
./sync.h:223:43: note: suggested alternative: ‘Mutex’
         std::unique_lock<std::mutex> lock(mutex);
                                           ^~~~~
                                           Mutex
./sync.h:224:9: error: ‘condition’ was not declared in this scope
         condition.wait(lock, [&]() { return value >= 1; });
         ^~~~~~~~~
./sync.h: In member function ‘bool CSemaphore::try_wait()’:
./sync.h:230:30: error: ‘mutex’ is not a member of ‘std’
         std::lock_guard<std::mutex> lock(mutex);
                              ^~~~~
./sync.h:230:30: error: ‘mutex’ is not a member of ‘std’
./sync.h:230:35: error: template argument 1 is invalid
         std::lock_guard<std::mutex> lock(mutex);
                                   ^
./sync.h:230:42: error: ‘mutex’ was not declared in this scope
         std::lock_guard<std::mutex> lock(mutex);
                                          ^~~~~
./sync.h:230:42: note: suggested alternative: ‘Mutex’
         std::lock_guard<std::mutex> lock(mutex);
                                          ^~~~~
                                          Mutex
./sync.h: In member function ‘void CSemaphore::post()’:
./sync.h:240:34: error: ‘mutex’ is not a member of ‘std’
             std::lock_guard<std::mutex> lock(mutex);
                                  ^~~~~
./sync.h:240:34: error: ‘mutex’ is not a member of ‘std’
./sync.h:240:39: error: template argument 1 is invalid
             std::lock_guard<std::mutex> lock(mutex);
                                       ^
./sync.h:240:46: error: ‘mutex’ was not declared in this scope
             std::lock_guard<std::mutex> lock(mutex);
                                              ^~~~~
./sync.h:240:46: note: suggested alternative: ‘Mutex’
             std::lock_guard<std::mutex> lock(mutex);
                                              ^~~~~
                                              Mutex
./sync.h:243:9: error: ‘condition’ was not declared in this scope
         condition.notify_one();
         ^~~~~~~~~
./sync.h: In substitution of ‘template<class MutexArg> using DebugLock = UniqueLock<typename std::remove_reference<typename std::remove_pointer<_Tp>::type>::type> [with MutexArg = int]’:
./util/system.h:287:9:   required from here
./sync.h:177:113: error: ‘std::remove_reference<int>::type {aka int}’ is not a class, struct, or union type
 using DebugLock = UniqueLock<typename std::remove_reference<typename std::remove_pointer<MutexArg>::type>::type>;
                                                                                                                 ^
./util/system.h: In member function ‘void ArgsManager::ClearArgs()’:
./sync.h:182:104: error: expression list treated as compound expression in initializer [-fpermissive]
 #define LOCK(cs) DebugLock<decltype(cs)> PASTE2(criticalblock, __COUNTER__)(cs, #cs, __FILE__, __LINE__)
                                                                                                        ^
./util/system.h:287:9: note: in expansion of macro ‘LOCK’
         LOCK(cs_args);
         ^
Makefile:10694: recipe for target 'bitcoind-bitcoind.o' failed
make[2]: *** [bitcoind-bitcoind.o] Error 1
make[2]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
Makefile:13149: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/home/ubuntu/build/bitcoin/distsrc-x86_64-w64-mingw32/src'
Makefile:774: recipe for target 'all-recursive' failed
make: *** [all-recursive] Error 1

Copy link
Member

@theuni theuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept ACK.

@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 24, 2019

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.

This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (bitcoin#6900).
However, it should no longer be required, as we have switched to Bionic (bitcoin#13171), and that
has a far newer version of binutils.

binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192
@fanquake fanquake force-pushed the remove_mingw_linker_workaround branch from ac85e81 to bd3f5a9 Compare September 23, 2019 00:42
@DrahtBot
Copy link
Contributor

Gitian builds for commit 13377b7 (master):

Gitian builds for commit 2cfaf8bbd8d0a5a42ed8c0762aff98b3ebf6f155 (master and this pull):

@bitcoin bitcoin deleted a comment from DrahtBot Sep 23, 2019
@dongcarl
Copy link
Contributor

Performing a Gitian build on bd3f5a9 right now if anyone wants to compare.

@maflcko
Copy link
Member

maflcko commented Sep 23, 2019

Eh? DrahtBot did a build on 2cfaf8b and it didn't even start. (Or for some other reason didn't produce a win-build.log)

@maflcko
Copy link
Member

maflcko commented Sep 24, 2019

Aw sorry 🤦‍♂️. Looks like this time it worked.

@laanwj
Copy link
Member

laanwj commented Sep 25, 2019

What is the status of this?

@maflcko
Copy link
Member

maflcko commented Sep 25, 2019

ACK bd3f5a9

Show signature and timestamp

Signature:

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

ACK bd3f5a90ecd6de40516141b23b0861dbba0b31b6
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUjb6Qv+Jda+FAxquHn1EbKNQAjfQw203BOxP7LiHD+Ot/x3yJD6OVpH6kaK25yZ
OPqIJnkypvXJKRxjFVsQJ+vX46scSds2XMh5newn+at4tNxxm1dsWcbnCiLbP2vw
7TCLY51yu84/qGH45vAT4oq9VIninEm2joB2AyklkFqmbSeFutbdII6KNCQ2flzV
kcVubISckkfH0YVWuPn226AM7/n0ngeP8jE9c5CB25ISkEOVatGDLngj9CeARH8Q
LUjuCK0hbx0/vG9Xm6I4fDWNs5TGl0NH2jYjZUpjLoVUsm9L4s0xej8WB13QU642
VvRX6ZSsuf1im+2FSbtgbN+h6jlXN0rEodxXZqJ0i6FB1mGtajwgH+pW6/68bEXH
5ODcGrCvcNfmjQvvGAo411cwlT2NfFOJVNpBoegmx8zPjoaf9BKW3xJXNihP0bMe
5uwm3HpZfpKrJdK7MXALfZ/HLNKdItz2JKjCi5x6uPhi0wHtjjAOThpeloPnc7o8
zgnRDWSy
=rcs4
-----END PGP SIGNATURE-----

Timestamp of file with hash 90e31459a25983012aabe70c185b6812d7ef8b09395071eab003f7376b37a810 -

@maflcko
Copy link
Member

maflcko commented Sep 25, 2019

Ok, I am confused.

For commit 7b2a788d911e5c3f5aeb36dba5a03827428e800b (master+this pull) it failed:

scratch/gitian/bitcoin-binaries/7b2a788d911e5c3f5aeb36dba5a03827428e800b/win-build.log

@maflcko
Copy link
Member

maflcko commented Sep 25, 2019

Does anyone have any results (apart from @DrahtBot, whose results were inconclusive)

@dongcarl @fanquake

@maflcko
Copy link
Member

maflcko commented Sep 25, 2019

Also fails for commit bd3f5a9

@dongcarl
Copy link
Contributor

@MarcoFalke Here are my results for bd3f5a9

ef63c5ce021cf4d16b6ee148f7886ab2af50d415560dd1f7117e5f56743b72a4  bitcoin-0.18.99-win-unsigned.tar.gz
919038118da38a28a0a4d391c0c56cd53d32d5470bed1d6984134d514cb2ae13  bitcoin-0.18.99-win64-debug.zip
4f525a8cc5852b1db4c5d98d218117f153eccc722f1bc69394dc9412c7ac417c  bitcoin-0.18.99-win64-setup-unsigned.exe
4aa2e0c4f32fcca6c557f2581aaf7578f271fe329264e090305d504223e62dcf  bitcoin-0.18.99-win64.zip
c7d72ac57753ffda64d88760d3e4c9bba1904faec342bf64150eb992dc9a003b  src/bitcoin-0.18.99.tar.gz
04ea46d6543ac225ebbf3e5896a2779f4389d9472ec30ec785e437e88a1da548  bitcoin-core-win-0.19-res.yml

@maflcko
Copy link
Member

maflcko commented Sep 25, 2019

Which virtualization are you using (lxc, kvm, podman, docker, bare metal, ...)?

@maflcko
Copy link
Member

maflcko commented Sep 25, 2019

Also, how many compile threads and is the result stable for you?

@dongcarl
Copy link
Contributor

Here's what I used:

env USE_DOCKER=1 ./bin/gbuild -j48 -m 32768 --commit bitcoin=bd3f5a90ecd6de40516141b23b0861dbba0b31b6 --url bitcoin=https://github.com/fanquake/bitcoin.git ~/src/bitcoin/fanquake/remove_mingw_linker_workaround/contrib/gitian-descriptors/gitian-win.yml

I'll try it again to see if result is stable!

@dongcarl
Copy link
Contributor

Everything important seems to match except the res.yml:

ef63c5ce021cf4d16b6ee148f7886ab2af50d415560dd1f7117e5f56743b72a4  bitcoin-0.18.99-win-unsigned.tar.gz
919038118da38a28a0a4d391c0c56cd53d32d5470bed1d6984134d514cb2ae13  bitcoin-0.18.99-win64-debug.zip
4f525a8cc5852b1db4c5d98d218117f153eccc722f1bc69394dc9412c7ac417c  bitcoin-0.18.99-win64-setup-unsigned.exe
4aa2e0c4f32fcca6c557f2581aaf7578f271fe329264e090305d504223e62dcf  bitcoin-0.18.99-win64.zip
c7d72ac57753ffda64d88760d3e4c9bba1904faec342bf64150eb992dc9a003b  src/bitcoin-0.18.99.tar.gz
5fb863503148b130fe4e7b217b588840aa67f1701588068eeb76b6837b4ea545  bitcoin-core-win-0.19-res.yml

@maflcko
Copy link
Member

maflcko commented Sep 25, 2019

Thanks, I'll debug some more maybe tomorrow

@fanquake fanquake deleted the remove_mingw_linker_workaround branch October 14, 2019 13:40
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Oct 15, 2019
…itian descriptor

bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake)

Pull request description:

  This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (bitcoin#6900).
  However, it should no longer be required, as we have switched to Bionic (bitcoin#13171) and that
  has a far newer version of binutils.

  Original discussion: bitcoin#6900
  binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

ACKs for top commit:
  MarcoFalke:
    ACK bd3f5a9
  theuni:
    ACK bd3f5a9
  laanwj:
    ACK bd3f5a9

Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c
hebasto added a commit to hebasto/bitcoin that referenced this pull request Mar 22, 2020
This commit removes the directory that has not been used since bitcoin#16667.
hebasto added a commit to hebasto/bitcoin that referenced this pull request Apr 7, 2020
This commit removes the directory that is no longer used since bitcoin#16667.
MarkLTZ added a commit to litecoinz-core/litecoinz that referenced this pull request Apr 10, 2020
hebasto added a commit to hebasto/bitcoin that referenced this pull request Apr 11, 2020
This commit removes the directory that is no longer used since bitcoin#16667.
hebasto added a commit to hebasto/bitcoin that referenced this pull request Apr 17, 2020
This commit removes the directory that is no longer used since bitcoin#16667.
luke-jr pushed a commit to luke-jr/bitcoin that referenced this pull request May 14, 2020
This commit removes the directory that is no longer used since bitcoin#16667.

Github-Pull: bitcoin#18556
Rebased-From: 2aa48ed
random-zebra added a commit to random-zebra/PIVX that referenced this pull request Jul 19, 2021
…scriptors

a7dbb27 build: add missing attributes to Win installer (Fuzzbawls)
13d0b48 nsis: Don't duplicate URL string (Fuzzbawls)
56563e5 build: remove WINDOWS_BITS from build system (fanquake)
0cb37c8 nsis: Write to correct filename in first place (Carl Dong)
7aa2823 gitian: Put things in the right place to begin with (Carl Dong)
0dcf6e6 gitian: Eliminate rename dependency (Carl Dong)
ba579b9 gitian: Smaller diff with gitian-linux.yml (Carl Dong)
3b9d5e8 gitian: Fix README inclusion in archives (Carl Dong)
07c27d2 gitian: Use split-debug.sh for Win builds (Carl Dong)
9f19095 build: Add README.md to DIST target (MarcoFalke)
ce80c76 build: remove mingw linker workaround from win gitian descriptor (fanquake)
37441b0 scripted-diff: gitian: Use REFERENCE_DATETIME directly. (Fuzzbawls)
966fe9a depends: remove usage of TAR_OPTIONS (fanquake)
12fd641 build: remove export GZIP from gitian descriptors (fanquake)

Pull request description:

  This is a collection of upstream PRs focused on cleaning up the gitian descriptors (un-needed or duplicate code bits, standardizing similar actions across the descriptors, etc), and minor cleanups to supporting build system files.

  Included are the following upstream PRs:
  * bitcoin#16141
  * bitcoin#16184
  * bitcoin#16667
  * bitcoin#17097
  * bitcoin#17029
  * bitcoin#17308
  * bitcoin#17756
  * bitcoin#18059

ACKs for top commit:
  furszy:
    Tested ACK a7dbb27
  random-zebra:
    ACK a7dbb27 and merging...

Tree-SHA512: 409d4f51adfb1c90aa8bc572fe6610596dea1293a8ca795f9071bb88bd583bd7678359ee19e34440bb0d117075ebd27f9a622247ee3dfd0cd9088e6da306a4d5
furszy pushed a commit to furszy/bitcoin-core that referenced this pull request Sep 2, 2021
This commit removes the directory that is no longer used since bitcoin#16667.
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Sep 9, 2021
…itian descriptor

bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake)

Pull request description:

  This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (dashpay#6900).
  However, it should no longer be required, as we have switched to Bionic (bitcoin#13171) and that
  has a far newer version of binutils.

  Original discussion: bitcoin#6900
  binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

ACKs for top commit:
  MarcoFalke:
    ACK bd3f5a9
  theuni:
    ACK bd3f5a9
  laanwj:
    ACK bd3f5a9

Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c
UdjinM6 pushed a commit to UdjinM6/dash that referenced this pull request Oct 5, 2021
…itian descriptor

bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake)

Pull request description:

  This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (dashpay#6900).
  However, it should no longer be required, as we have switched to Bionic (bitcoin#13171) and that
  has a far newer version of binutils.

  Original discussion: bitcoin#6900
  binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

ACKs for top commit:
  MarcoFalke:
    ACK bd3f5a9
  theuni:
    ACK bd3f5a9
  laanwj:
    ACK bd3f5a9

Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c
pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021
…itian descriptor

bd3f5a9 build: remove mingw linker workaround from win gitian descriptor (fanquake)

Pull request description:

  This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (dashpay#6900).
  However, it should no longer be required, as we have switched to Bionic (bitcoin#13171) and that
  has a far newer version of binutils.

  Original discussion: bitcoin#6900
  binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

ACKs for top commit:
  MarcoFalke:
    ACK bd3f5a9
  theuni:
    ACK bd3f5a9
  laanwj:
    ACK bd3f5a9

Tree-SHA512: 01a5789994decf8cdedf7aaa0a449d2100a77e2e6b422d6b9dd5a4ac3e2e0b538c3d43aae4a1c3713614782f3c6b09d8d8bb21c20e86ce3c1734183dedd02d0c
Fabcien pushed a commit to Bitcoin-ABC/bitcoin-abc that referenced this pull request Dec 1, 2021
Summary:
> This workaround was added as part of the switch to gitian building using Ubuntu 14.04 (#6900).
> However, it should no longer be required, as we have switched to Bionic (#13171), and that
> has a far newer version of binutils.
>
> binutils patch: https://sourceware.org/bugzilla/show_bug.cgi?id=16192

Bitcoin ABC now uses Debian Buster, which has an even more recent version of binutils (2.31 vs 2.30).

This is a backport of [[bitcoin/bitcoin#16667 | core#16667]]

Depends on D10584

Test Plan: @bot gitian-win

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D10587
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants