[0.17] abort when attempting to fund a transaction above -maxtxfee #16639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2019
Contributor
|
Concept ACK. |
FundTransaction calls GetMinimumFee which, when the fee rate is absurdly high, quietly reduced the fee to -maxtxfee. Becaue an absurdly high fee rate is usually the result of a fat finger, aborting seems safer behavior. Github-Pull: bitcoin#16257 Rebased-From: 806b005
Sjors
force-pushed
the
2019/08/backport_max_fee
branch
from
0f69436 to
42a716c
Compare
Github-Pull: bitcoin#16322 Rebased-From: 5c1b971
Sjors
force-pushed
the
2019/08/backport_max_fee
branch
from
42a716c to
0e7c746
Compare
Member
Author
|
Manually added |
Member
|
ACK 0e7c746 |
laanwj
added a commit
that referenced
this pull request
Sep 12, 2019
…e -maxtxfee 0e7c746 wallet: Fix -maxtxfee check by moving it to CWallet::CreateTransaction (João Barbosa) e9adb96 [wallet] abort when attempting to fund a transaction above maxtxfee (Sjors Provoost) Pull request description: Backport #16257. Cherry-picked from the 0.18 backport in #16414, but without the [wip] messages and without the last commit (which adds a test in a file that didn't exist in 0.17). ACKs for top commit: laanwj: ACK 0e7c746 Tree-SHA512: a0fd603518487854be0b3815f34a8dabd2ed258850c032b08894a7c55cb135df5d3c103f76c5294e8065fec6d610e064acf01d24c77f02eaf996698a1e45d512
Member
Author
|
Thanks. Note that 0.18 backport is still open in #16414 |
fanquake
added a commit
to fanquake/bitcoin
that referenced
this pull request
Sep 13, 2019
This uses the wording from the release-notes in master.
laanwj
added a commit
that referenced
this pull request
Sep 13, 2019
fb9bade doc: integrate release notes from #16639 (fanquake) Pull request description: This uses the wording from the release-notes currently [in master](https://github.com/bitcoin/bitcoin/blob/master/doc/release-notes.md#wallet). ACKs for top commit: laanwj: ACK fb9bade Tree-SHA512: 1a8938c01cba2605ad3d8f6219499d118bf944ff354858e10e4ba55ea0dfd212f3104f38e21cb57e6dc891480775c972a4156f91a7572acc579e89fce35c912d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #16257.
Cherry-picked from the 0.18 backport in #16414, but without the [wip] messages and without the last commit (which adds a test in a file that didn't exist in 0.17).