Skip to content

Conversation

@fanquake
Copy link
Member

Initial preparations for a 0.17.2 release. Needs a look over by laanwj (especially translations). Also need to check that everyone that should be included in the release notes has been included.

#15445 is the last open 0.17.2 milestone tagged PR. I'm not sure that it's a requirement though.

@fanquake fanquake added this to the 0.17.2 milestone Aug 17, 2019
@fanquake fanquake requested a review from laanwj August 17, 2019 06:32
@Sjors
Copy link
Member

Sjors commented Aug 17, 2019

If possible, I'd like to include #16639

@laanwj
Copy link
Member

laanwj commented Aug 19, 2019

Concept ACK, haven't checked the translation changes in detail but looks good to me on first glance

@GChuf
Copy link
Contributor

GChuf commented Aug 21, 2019

Translations for 0.17 cleaned and updated on transifex.
Be advised, some translations were merged. There were also some translations which were just duplicates and didn't add anything when merging them. The result is less language files, which are in turn more complete.

p.s. I'd still like to further tidy up the translation on transifex, but i'm waiting for laanwj's answer. It's a mess with duplicates everywhere, and translations for locales instead of languages in some cases. Cleaning up further for 0.17 and 0.18 would only make a bigger mess on transifex since I can't move 0.14, 0.15 and 0.16 versions around.

@fanquake fanquake force-pushed the 0-17-2-release-prep branch from e8e0ed9 to 0bd04c5 Compare August 27, 2019 00:37
@fanquake
Copy link
Member Author

I've updated this to pull the latest Transifex changes for 0.17.

Cleaning up further for 0.17 and 0.18 would only make a bigger mess on transifex since I can't move 0.14, 0.15 and 0.16 versions around.

I'd suggest just concentrating on the upcoming 0.19 release. "Cleaning up" anything more for 0.17 and even 0.18 is going to be low impact

@GChuf
Copy link
Contributor

GChuf commented Aug 27, 2019

"Cleaning up" anything more for 0.17 and even 0.18 is going to be low impact

I'm well aware of that, I wasn't going to clean the older translations, just move some of them from locales to languages - since I can't do that, moving languages around can make a mess on transifex. Languages which appeared to be complete (100% translated in every branch) would then be only ~80% translated, even though 017x and 018x would be at 100%. I'd rather move all translations together, so that the older translations stay on transifex as examples.

///

I took a quick look at the translations, it seems that the bitcoin_si.ts is wrong - the translations are in another language. I already fixed it on transifex. Please either remove the file or pull the translations from transifex again if it's not too much work.

@laanwj
Copy link
Member

laanwj commented Aug 29, 2019

since I can't move 0.14, 0.15 and 0.16 versions around.

Please don't spend time on those versions, their translations will never end up in a release anymore. Only the last two major releases have active translation, and I agree with @fanquake that it only makes sense to focus on the latest release (now 0.18, translations will open for 0.19 in a few days) for major changes.

Copy link
Member

@laanwj laanwj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0bd04c5

laanwj added a commit that referenced this pull request Aug 29, 2019
0bd04c5 doc: update release notes for 0.17.2 (fanquake)
6b42df8 qt: 0.17.2 translation update (fanquake)
c56c9ad doc: update manpages for 0.17.2 (fanquake)
b4472f5 build: bump version to 0.17.2 (fanquake)

Pull request description:

  Initial preparations for a 0.17.2 release. Needs a look over by laanwj (especially translations). Also need to check that everyone that should be included in the release notes has been included.

  #15445 is the last open [0.17.2 milestone](https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Apr+milestone%3A0.17.2) tagged PR. I'm not sure that it's a requirement though.

ACKs for top commit:
  laanwj:
    ACK 0bd04c5

Tree-SHA512: b9017b2372f13188b69d90b3c08ce24abefff55afcbdadd405e47de4c1ba33add90b14222e773f5baa661027703a5285c30a463ff76f35a9b83e0d029f65bdbc
@laanwj laanwj merged commit 0bd04c5 into bitcoin:0.17 Aug 29, 2019
@laanwj
Copy link
Member

laanwj commented Aug 29, 2019

but i'm waiting for laanwj's answer

Sorry, answer to what are you waiting for?

@GChuf
Copy link
Contributor

GChuf commented Aug 29, 2019

@laanwj sorry if I wasn't clear enough. I'm not spending time on 0.14 - 0.16.
I'd just like to tidy up translations on transifex and move translations from locales to languages ((cs_CZ) to (cs) for example), because we don't need a locale for czech language.
To do this in a clean way, I'd also have to move 0.14-0.16 translations around (or just delete them), which I can't at the moment.

I was asking you for permissions/credentials to do that, but I can't exactly remember when and where.
I've also sent you a message on transifex a while ago, asking for coordinator/reviewer role for slovenian language (si) and (si_SI) (account name gasper.cefarin).

I've already done a lot of cleaning and some reorganizing on traqnsifex- you'll see the bump in edited/translated words on transifex dashboard for August.

@laanwj
Copy link
Member

laanwj commented Aug 29, 2019

@GChuf OK, I don't really have control over the transifex organization to deal out credentials AFAIK, apart from making people "maintainer". The person who created it, "seone" seems to have gone MIA, maybe @luke-jr knows more. I do not have access to the "team" pages, for example.

Maybe for the next version it'd make sense to move to a new transifex organization.

Edit: I should be able to add/delete resources though, so will try to delete those old versions.

@laanwj
Copy link
Member

laanwj commented Aug 29, 2019

I've managed to remove the 0.14-0.16 resources. As for the other questions, see #16754.

@fanquake fanquake deleted the 0-17-2-release-prep branch January 22, 2020 11:29
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants