B: Get rid of Params().RequireStandard() #16527
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
jtimon
changed the title
jtimon
force-pushed
the
b19-chainparams-no-requirestd
branch
from
ce380b9 to
1dc2536
Compare
Contributor
Author
|
Rebased |
jtimon
force-pushed
the
b19-chainparams-no-requirestd
branch
from
1dc2536 to
5a5df16
Compare
jtimon
force-pushed
the
b19-chainparams-no-requirestd
branch
from
5a5df16 to
b11d740
Compare
Contributor
Author
|
Decoupled from #16524 |
Member
|
This means that non std txs aren't propagated on testnet, so tend to NACK |
Contributor
Author
|
Well, only if users don't set acceptnonstdtxn=1, we could say it in the release notes. |
Member
|
It makes sense to default to |
Contributor
Author
|
Closing for now due to lack of interest. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #16524Alternative to #16526
This goes further and just like in #16524 it removes the different defaults for each chain.
In my opinion, one thing is to want to prevent people from shooting themselves in the food like AllowAcceptNonstd()/IsTestChain() allows for mainnet and a very different one is having per chain defaults for each parameter.
testnet3 and regtest users will now need to modify their config files, at most, in the following way:
I don't think that's much to ask from the advanced users regtest and testnet users are supposed to be.
Maybe this is different for testnet3, I would like to hear why.