Skip to content

A: Chainparams: Rename RequireStandard() to DefaultAcceptNonstd() #16526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jtimon wants to merge 1 commit into from
Closed

A: Chainparams: Rename RequireStandard() to DefaultAcceptNonstd() #16526

jtimon wants to merge 1 commit into from

Conversation

@jtimon
Copy link
Contributor

@jtimon jtimon commented Aug 1, 2019 •
edited
Loading

Alternative to #16527

Just a rename, shouldn't change functionality.
Can be considered bik-shedding, but I believe the resulting code is more clear, less negations.

Rename related to #16770

@jtimon jtimon mentioned this pull request Aug 1, 2019
Closed
@DrahtBot
Copy link
Contributor

DrahtBot commented Aug 1, 2019 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #17037 (Testschains: Many regtests with different genesis and default datadir by jtimon)
  • #17032 (Tests: Chainparams: Make regtest almost fully customizable by jtimon)
  • #16770 (Chainparams: Rename IsTestChain() to AllowAcceptNonstd() by jtimon)
  • #16527 (B: Get rid of Params().RequireStandard() by jtimon)
  • #8994 (Testchains: Introduce custom chain whose constructor... by jtimon)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@jtimon jtimon changed the title Refactor: Chainparams: readability A: Refactor: Chainparams: readability Aug 1, 2019
@jtimon jtimon force-pushed the b19-chainparams-no-istestchain branch from 9a1b078 to 086ba64 Compare August 7, 2019 02:46
@jtimon
Copy link
Contributor Author

jtimon commented Aug 7, 2019

Rebased

@jtimon jtimon force-pushed the b19-chainparams-no-istestchain branch from 086ba64 to 61c0731 Compare August 7, 2019 07:49
@jtimon jtimon force-pushed the b19-chainparams-no-istestchain branch from 61c0731 to 3094a33 Compare August 31, 2019 16:34
@jtimon
Copy link
Contributor Author

jtimon commented Aug 31, 2019

Decoupled from #16524

@jtimon jtimon changed the title A: Refactor: Chainparams: readability A: Chainparams: Rename RequireStandard() to DefaultAcceptNonstd() Aug 31, 2019
@jtimon jtimon mentioned this pull request Sep 13, 2019
Closed
@luke-jr
Copy link
Member

luke-jr commented Oct 8, 2019

Don't think this is worth it.

@jtimon
Copy link
Contributor Author

jtimon commented Oct 9, 2019

Since I seem to be alone in considering:

    fRequireStandard = !gArgs.GetBoolArg("-acceptnonstdtxn", chainparams.DefaultAcceptNonstd());

much more readable than

    fRequireStandard = !gArgs.GetBoolArg("-acceptnonstdtxn", !chainparams.RequireStandard());

just by having one less negation...closing

@jtimon jtimon closed this Oct 9, 2019
@maflcko
Copy link
Member

maflcko commented Oct 9, 2019

I like it, but yeah shrug

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Refactoring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jtimon @DrahtBot @luke-jr @maflcko @fanquake