build: skip deploying plugins we dont use in macdeployqtplus #16477

fanquake · 2019-07-28T03:12:45Z

I frequently run make deploy while testing on macOS to get a properly light themed .app. With a brew installed Qt, this currently results in a pretty bloated executable:

branch	.app size	.dmg size	`make deploy` time
master (`febf3a8`)	235mb	86mb	38s
This PR (da98f6d470d236c027b7eb8b5f5552fdca04e803)	51mb	21mb	22s

Similar change to dd367ff.

                         'QtGui.framework'],
  'pluginPath': '/usr/local/opt/qt/plugins',
  'qtPath': '/usr/local/opt/qt'}
-[('platforminputcontexts', 'libqtvirtualkeyboardplugin.dylib'),
- ('geoservices', 'libqtgeoservices_esri.dylib'),
- ('geoservices', 'libqtgeoservices_mapboxgl.dylib'),
- ('geoservices', 'libqtgeoservices_nokia.dylib'),
- ('geoservices', 'libqtgeoservices_itemsoverlay.dylib'),
- ('geoservices', 'libqtgeoservices_osm.dylib'),
- ('geoservices', 'libqtgeoservices_mapbox.dylib'),
- ('sceneparsers', 'libgltfsceneexport.dylib'),
- ('sceneparsers', 'libgltfsceneimport.dylib'),
- ('platforms', 'libqwebgl.dylib'),
+[('platforms', 'libqwebgl.dylib'),
  ('platforms', 'libqoffscreen.dylib'),
  ('platforms', 'libqminimal.dylib'),
  ('platforms', 'libqcocoa.dylib'),
  ('platformthemes', 'libqxdgdesktopportal.dylib'),
- ('printsupport', 'libcocoaprintersupport.dylib'),
- ('webview', 'libqtwebview_webengine.dylib'),
- ('webview', 'libqtwebview_darwin.dylib'),
- ('geometryloaders', 'libdefaultgeometryloader.dylib'),
- ('geometryloaders', 'libgltfgeometryloader.dylib'),
  ('styles', 'libqmacstyle.dylib'),
- ('canbus', 'libqttinycanbus.dylib'),
- ('canbus', 'libqtpassthrucanbus.dylib'),
- ('canbus', 'libqtvirtualcanbus.dylib'),
- ('canbus', 'libqtpeakcanbus.dylib'),
  ('bearer', 'libqgenericbearer.dylib'),
- ('imageformats', 'libqgif.dylib'),
- ('imageformats', 'libqwbmp.dylib'),
- ('imageformats', 'libqwebp.dylib'),
- ('imageformats', 'libqico.dylib'),
- ('imageformats', 'libqmacheif.dylib'),
- ('imageformats', 'libqjpeg.dylib'),
- ('imageformats', 'libqtiff.dylib'),
- ('imageformats', 'libqicns.dylib'),
- ('imageformats', 'libqtga.dylib'),
- ('imageformats', 'libqmacjp2.dylib'),
- ('texttospeech', 'libqtexttospeech_speechosx.dylib'),
- ('generic', 'libqtuiotouchplugin.dylib'),
- ('renderplugins', 'libscene2d.dylib'),
- ('gamepads', 'libdarwingamepad.dylib'),
- ('virtualkeyboard', 'libqtvirtualkeyboard_thai.dylib'),
- ('virtualkeyboard', 'libqtvirtualkeyboard_openwnn.dylib'),
- ('virtualkeyboard', 'libqtvirtualkeyboard_hangul.dylib'),
- ('virtualkeyboard', 'libqtvirtualkeyboard_pinyin.dylib'),
- ('virtualkeyboard', 'libqtvirtualkeyboard_tcime.dylib')]
+ ('generic', 'libqtuiotouchplugin.dylib')]

promag · 2019-07-28T13:09:28Z

Concept ACK, nice.

phonon is no longer a part of Qt as of version 5

fanquake · 2019-07-29T01:37:13Z

Updated to skip more plugins, including virtualkeyboard and imageformats.

laanwj · 2019-07-29T12:11:34Z

Huh, it's interesting how no longer referencing dynamic libraries results in such a change in executable size. Do they all get included in the app image?

fanquake · 2019-07-30T01:54:29Z

Huh, it's interesting how no longer referencing dynamic libraries results in such a change in executable size. Do they all get included in the app image?

Yep the macdeployqtplus script copies .framework and .dylib files into the Bitcoin-Qt.app bundle. Using master, with Qt 5.13.0 installed via brew, that ends up looking like the below. QtWebEngineCore.framework is to blame for most of the bloat..

/Volumes/Bitcoin-Core/Bitcoin-Qt.app/Contents/Frameworks:

166M	QtWebEngineCore.framework
5.8M	QtCore.framework
5.6M	QtWidgets.framework
5.3M	QtGui.framework
4.2M	QtQml.framework
4.0M	QtQuick.framework
2.5M	Qt3DRender.framework
1.7M	libcrypto.1.0.0.dylib
1.7M	QtLocation.framework
1.3M	libdb_cxx-4.8.dylib
1.3M	QtNetwork.framework
788K	QtVirtualKeyboard.framework
636K	Qt3DExtras.framework
492K	QtPositioning.framework
476K	QtDBus.framework
416K	QtWebEngine.framework
404K	Qt3DInput.framework
396K	Qt3DCore.framework
392K	libzmq.5.dylib
308K	QtPrintSupport.framework
228K	libevent-2.1.6.dylib
220K	QtSerialBus.framework
212K	QtSql.framework
172K	Qt3DQuick.framework
160K	QtWebSockets.framework
128K	QtWebChannel.framework
120K	QtGamepad.framework
112K	QtPositioningQuick.framework
100K	Qt3DQuickScene2D.framework
 92K	libboost_filesystem.dylib
 88K	QtWebView.framework
 88K	QtSerialPort.framework
 84K	libboost_thread-mt.dylib
 60K	Qt3DLogic.framework
 52K	QtTextToSpeech.framework
 40K	libqrencode.4.dylib
 36K	libboost_chrono-mt.dylib
 36K	QtConcurrent.framework
 16K	libevent_pthreads-2.1.6.dylib
8.0K	libboost_system.dylib

/Volumes/Bitcoin-Core/Bitcoin-Qt.app/Contents/PlugIns:

5.3M	geoservices
4.9M	platforms
3.0M	virtualkeyboard
1.7M	imageformats
392K	sceneparsers
204K	styles
184K	canbus
140K	geometryloaders
104K	webview
 80K	generic
 68K	platformthemes
 64K	gamepads
 52K	platforminputcontexts
 52K	bearer
 44K	texttospeech
 44K	renderplugins
 28K	printsupport

laanwj · 2019-07-30T13:36:25Z

That's … the worst of both worlds.
Concept ACK anyway

DrahtBot · 2019-07-30T16:12:14Z

Gitian builds for commit 68da549 (master):

57f7c8c6cc0a37383ad50f02afa2fb34... bitcoin-0.18.99-aarch64-linux-gnu-debug.tar.gz
792cf3027d09a10829d01b6e53c28c4b... bitcoin-0.18.99-aarch64-linux-gnu.tar.gz
f5d9edbaae9596f64da19c531cc4b67b... bitcoin-0.18.99-arm-linux-gnueabihf-debug.tar.gz
d10b6b7f78a4df2fc332e07709682777... bitcoin-0.18.99-arm-linux-gnueabihf.tar.gz
579aac6400f2fd95ebc5b2b3a4019d0a... bitcoin-0.18.99-i686-pc-linux-gnu-debug.tar.gz
9310859339a7cc5fce17fc7294d79564... bitcoin-0.18.99-i686-pc-linux-gnu.tar.gz
9f97557afbdb447627511b3f5200afb6... bitcoin-0.18.99-osx-unsigned.dmg
567b98436a8197a0eabfbc757bcd36bc... bitcoin-0.18.99-osx64.tar.gz
09788321842e830b74c74a2e8eb221bb... bitcoin-0.18.99-riscv64-linux-gnu-debug.tar.gz
7c0af48f29513d707f9a3acc90692138... bitcoin-0.18.99-riscv64-linux-gnu.tar.gz
c476f0bc071f21310a0d51e53508d602... bitcoin-0.18.99-win64-debug.zip
853a0719767ebecd244a2f535eeaa050... bitcoin-0.18.99-win64-setup-unsigned.exe
846e82ab0df1217a7ad7438800082c9e... bitcoin-0.18.99-win64.zip
b165b45760975a8dcf4e2b626bff6859... bitcoin-0.18.99-x86_64-linux-gnu-debug.tar.gz
f7e0d0c8799a7a6b2904318e61c0245e... bitcoin-0.18.99-x86_64-linux-gnu.tar.gz
b1bd383e62f3879da536c366db77dada... bitcoin-0.18.99.tar.gz
c2289106b2c04bc7922151ba75031713... bitcoin-core-linux-0.19-res.yml
ef5bec416f7b3011ef758905e687e8ce... bitcoin-core-osx-0.19-res.yml
b5be1fb6f106c061e3643bf8253b73ba... bitcoin-core-win-0.19-res.yml
24de35161c3f1279e53440995ad21e70... linux-build.log
c9b32df6b7be7ea58d034b7645db2ec6... osx-build.log
a010f0b6e52ad5aba4cb0e3ff392a87c... win-build.log

Gitian builds for commit e5c174621ec8e85ab95055bb1846cb16ea8c548f (master and this pull):

ea346dcdbe06751cab8001c76e5617db... bitcoin-0.18.99-aarch64-linux-gnu-debug.tar.gz
9fe614110b2e5c277378b0c09200dd51... bitcoin-0.18.99-aarch64-linux-gnu.tar.gz
851b47fba3ad8d63981e9e24b7535262... bitcoin-0.18.99-arm-linux-gnueabihf-debug.tar.gz
916b9d9841836553fdd1313192c5d66c... bitcoin-0.18.99-arm-linux-gnueabihf.tar.gz
09794da114ab58f20949140aebeb254d... bitcoin-0.18.99-i686-pc-linux-gnu-debug.tar.gz
547974ef127b92ec09154c70428c405f... bitcoin-0.18.99-i686-pc-linux-gnu.tar.gz
76c62057d6408fd98d1b5838e21b0746... bitcoin-0.18.99-osx-unsigned.dmg
1cfe2e7de38a1d26c61cca355b81a80c... bitcoin-0.18.99-osx64.tar.gz
b90bd9c4424199b2f68e2596564e9737... bitcoin-0.18.99-riscv64-linux-gnu-debug.tar.gz
c8540e21a809a8a5eca7381c2baccaa3... bitcoin-0.18.99-riscv64-linux-gnu.tar.gz
b2c5e995c7aee895e9077af0d5ce8d91... bitcoin-0.18.99-win64-debug.zip
f95f441f29cf130502dab2a45f7cb74b... bitcoin-0.18.99-win64-setup-unsigned.exe
c991ffee8d73d8ddf99cda0e69261285... bitcoin-0.18.99-win64.zip
d92c2917e5fae61d074742fc5aaccab5... bitcoin-0.18.99-x86_64-linux-gnu-debug.tar.gz
c2be53da2d6bd4be22ad6af787247f8a... bitcoin-0.18.99-x86_64-linux-gnu.tar.gz
d4a369b1ec16cc690c8754db0a7a5341... bitcoin-0.18.99.tar.gz
b121a4ba496126385cdeabe289e33de8... bitcoin-core-linux-0.19-res.yml
404e77444b735397bbfe02594e3de709... bitcoin-core-linux-0.19-res.yml.diff
ac478e2127f66508ba1ec4fd03f7bf2b... bitcoin-core-osx-0.19-res.yml
a02b356f6f575228c7b506dfede85098... bitcoin-core-osx-0.19-res.yml.diff
451b5f8dee8b8377f546a9f141ca8fa4... bitcoin-core-win-0.19-res.yml
36e6bf7ed3275888b48898cd4767a403... bitcoin-core-win-0.19-res.yml.diff
7df48573da0baf50f1bc47b2f92a02e8... linux-build.log
1f60ccd4fa73331e9e90b5d7f649e72a... linux-build.log.diff
9dfbcdf165c3e2bbdb90630d09183e21... osx-build.log
58be430e9a5c57295a5c124a5cce6e7f... osx-build.log.diff
2f944c319fa09f513f19bf127e94a418... win-build.log
1b046d67aa4bdcfca6ba179ed8a98e89... win-build.log.diff

laanwj · 2019-07-31T07:23:24Z

ACK 1ac7b7f (purely Python code review and the fact that this passes travis, cannot run this on a mac)

With all the PRs shaving bits off Qt, it would be nice to have a document about what are all the different places a library needs to be added in case someone does want to add a qt module dependency.

hebasto · 2019-08-27T14:37:02Z

Concept ACK.

dongcarl · 2019-09-09T18:06:19Z

tested ACK 1ac7b7f

Tested that the dmg built correctly, Bitcoin Core ran, and the various pages of the GUI looks like they're working.

…tplus 1ac7b7f scripts: filter more qt plugins we don't use in macdeployqtplus (fanquake) 57cdd06 scripts: misc cleanups in macdeployqtplus (fanquake) 51729a4 scripts: use format() in macdeployqtplus (fanquake) 1c37e81 scripts: add type annotations to macdeployqtplus (fanquake) Pull request description: I frequently run `make deploy` while testing on macOS to get a properly light themed .app. With a brew installed Qt, this currently results in a pretty bloated executable: | branch | .app size | .dmg size | `make deploy` time | | ------- | --------- | --------- | --------------------- | | master (febf3a8) | 235mb | 86mb | 38s | | This PR (da98f6d470d236c027b7eb8b5f5552fdca04e803) | 51mb | 21mb | 22s | Similar change to dd367ff. ```diff 'QtGui.framework'], 'pluginPath': '/usr/local/opt/qt/plugins', 'qtPath': '/usr/local/opt/qt'} -[('platforminputcontexts', 'libqtvirtualkeyboardplugin.dylib'), - ('geoservices', 'libqtgeoservices_esri.dylib'), - ('geoservices', 'libqtgeoservices_mapboxgl.dylib'), - ('geoservices', 'libqtgeoservices_nokia.dylib'), - ('geoservices', 'libqtgeoservices_itemsoverlay.dylib'), - ('geoservices', 'libqtgeoservices_osm.dylib'), - ('geoservices', 'libqtgeoservices_mapbox.dylib'), - ('sceneparsers', 'libgltfsceneexport.dylib'), - ('sceneparsers', 'libgltfsceneimport.dylib'), - ('platforms', 'libqwebgl.dylib'), +[('platforms', 'libqwebgl.dylib'), ('platforms', 'libqoffscreen.dylib'), ('platforms', 'libqminimal.dylib'), ('platforms', 'libqcocoa.dylib'), ('platformthemes', 'libqxdgdesktopportal.dylib'), - ('printsupport', 'libcocoaprintersupport.dylib'), - ('webview', 'libqtwebview_webengine.dylib'), - ('webview', 'libqtwebview_darwin.dylib'), - ('geometryloaders', 'libdefaultgeometryloader.dylib'), - ('geometryloaders', 'libgltfgeometryloader.dylib'), ('styles', 'libqmacstyle.dylib'), - ('canbus', 'libqttinycanbus.dylib'), - ('canbus', 'libqtpassthrucanbus.dylib'), - ('canbus', 'libqtvirtualcanbus.dylib'), - ('canbus', 'libqtpeakcanbus.dylib'), ('bearer', 'libqgenericbearer.dylib'), - ('imageformats', 'libqgif.dylib'), - ('imageformats', 'libqwbmp.dylib'), - ('imageformats', 'libqwebp.dylib'), - ('imageformats', 'libqico.dylib'), - ('imageformats', 'libqmacheif.dylib'), - ('imageformats', 'libqjpeg.dylib'), - ('imageformats', 'libqtiff.dylib'), - ('imageformats', 'libqicns.dylib'), - ('imageformats', 'libqtga.dylib'), - ('imageformats', 'libqmacjp2.dylib'), - ('texttospeech', 'libqtexttospeech_speechosx.dylib'), - ('generic', 'libqtuiotouchplugin.dylib'), - ('renderplugins', 'libscene2d.dylib'), - ('gamepads', 'libdarwingamepad.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_thai.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_openwnn.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_hangul.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_pinyin.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_tcime.dylib')] + ('generic', 'libqtuiotouchplugin.dylib')] ``` ACKs for top commit: laanwj: ACK 1ac7b7f (purely Python code review and the fact that this passes travis, cannot run this on a mac) dongcarl: tested ACK 1ac7b7f Tree-SHA512: 5974eeaf7229bb5bde2b283c1331ec57ee87f624db146401f6b77dee4ee5502e0bd669958a46205f10398a371f8e6c91ddacb9f0e1943f9f7d042fb6de7957a8

…deployqtplus 1ac7b7f scripts: filter more qt plugins we don't use in macdeployqtplus (fanquake) 57cdd06 scripts: misc cleanups in macdeployqtplus (fanquake) 51729a4 scripts: use format() in macdeployqtplus (fanquake) 1c37e81 scripts: add type annotations to macdeployqtplus (fanquake) Pull request description: I frequently run `make deploy` while testing on macOS to get a properly light themed .app. With a brew installed Qt, this currently results in a pretty bloated executable: | branch | .app size | .dmg size | `make deploy` time | | ------- | --------- | --------- | --------------------- | | master (febf3a8) | 235mb | 86mb | 38s | | This PR (da98f6d470d236c027b7eb8b5f5552fdca04e803) | 51mb | 21mb | 22s | Similar change to dd367ff. ```diff 'QtGui.framework'], 'pluginPath': '/usr/local/opt/qt/plugins', 'qtPath': '/usr/local/opt/qt'} -[('platforminputcontexts', 'libqtvirtualkeyboardplugin.dylib'), - ('geoservices', 'libqtgeoservices_esri.dylib'), - ('geoservices', 'libqtgeoservices_mapboxgl.dylib'), - ('geoservices', 'libqtgeoservices_nokia.dylib'), - ('geoservices', 'libqtgeoservices_itemsoverlay.dylib'), - ('geoservices', 'libqtgeoservices_osm.dylib'), - ('geoservices', 'libqtgeoservices_mapbox.dylib'), - ('sceneparsers', 'libgltfsceneexport.dylib'), - ('sceneparsers', 'libgltfsceneimport.dylib'), - ('platforms', 'libqwebgl.dylib'), +[('platforms', 'libqwebgl.dylib'), ('platforms', 'libqoffscreen.dylib'), ('platforms', 'libqminimal.dylib'), ('platforms', 'libqcocoa.dylib'), ('platformthemes', 'libqxdgdesktopportal.dylib'), - ('printsupport', 'libcocoaprintersupport.dylib'), - ('webview', 'libqtwebview_webengine.dylib'), - ('webview', 'libqtwebview_darwin.dylib'), - ('geometryloaders', 'libdefaultgeometryloader.dylib'), - ('geometryloaders', 'libgltfgeometryloader.dylib'), ('styles', 'libqmacstyle.dylib'), - ('canbus', 'libqttinycanbus.dylib'), - ('canbus', 'libqtpassthrucanbus.dylib'), - ('canbus', 'libqtvirtualcanbus.dylib'), - ('canbus', 'libqtpeakcanbus.dylib'), ('bearer', 'libqgenericbearer.dylib'), - ('imageformats', 'libqgif.dylib'), - ('imageformats', 'libqwbmp.dylib'), - ('imageformats', 'libqwebp.dylib'), - ('imageformats', 'libqico.dylib'), - ('imageformats', 'libqmacheif.dylib'), - ('imageformats', 'libqjpeg.dylib'), - ('imageformats', 'libqtiff.dylib'), - ('imageformats', 'libqicns.dylib'), - ('imageformats', 'libqtga.dylib'), - ('imageformats', 'libqmacjp2.dylib'), - ('texttospeech', 'libqtexttospeech_speechosx.dylib'), - ('generic', 'libqtuiotouchplugin.dylib'), - ('renderplugins', 'libscene2d.dylib'), - ('gamepads', 'libdarwingamepad.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_thai.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_openwnn.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_hangul.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_pinyin.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_tcime.dylib')] + ('generic', 'libqtuiotouchplugin.dylib')] ``` ACKs for top commit: laanwj: ACK 1ac7b7f (purely Python code review and the fact that this passes travis, cannot run this on a mac) dongcarl: tested ACK 1ac7b7f Tree-SHA512: 5974eeaf7229bb5bde2b283c1331ec57ee87f624db146401f6b77dee4ee5502e0bd669958a46205f10398a371f8e6c91ddacb9f0e1943f9f7d042fb6de7957a8

Summary: ``` I frequently run make deploy while testing on macOS to get a properly light themed .app. With a brew installed Qt, this currently results in a pretty bloated executable: branch .app size .dmg size make deploy time master (febf3a8) 235mb 86mb 38s This PR (da98f6d) 51mb 21mb 22s Similar change to dd367ff. 'QtGui.framework'], 'pluginPath': '/usr/local/opt/qt/plugins', 'qtPath': '/usr/local/opt/qt'} -[('platforminputcontexts', 'libqtvirtualkeyboardplugin.dylib'), - ('geoservices', 'libqtgeoservices_esri.dylib'), - ('geoservices', 'libqtgeoservices_mapboxgl.dylib'), - ('geoservices', 'libqtgeoservices_nokia.dylib'), - ('geoservices', 'libqtgeoservices_itemsoverlay.dylib'), - ('geoservices', 'libqtgeoservices_osm.dylib'), - ('geoservices', 'libqtgeoservices_mapbox.dylib'), - ('sceneparsers', 'libgltfsceneexport.dylib'), - ('sceneparsers', 'libgltfsceneimport.dylib'), - ('platforms', 'libqwebgl.dylib'), +[('platforms', 'libqwebgl.dylib'), ('platforms', 'libqoffscreen.dylib'), ('platforms', 'libqminimal.dylib'), ('platforms', 'libqcocoa.dylib'), ('platformthemes', 'libqxdgdesktopportal.dylib'), - ('printsupport', 'libcocoaprintersupport.dylib'), - ('webview', 'libqtwebview_webengine.dylib'), - ('webview', 'libqtwebview_darwin.dylib'), - ('geometryloaders', 'libdefaultgeometryloader.dylib'), - ('geometryloaders', 'libgltfgeometryloader.dylib'), ('styles', 'libqmacstyle.dylib'), - ('canbus', 'libqttinycanbus.dylib'), - ('canbus', 'libqtpassthrucanbus.dylib'), - ('canbus', 'libqtvirtualcanbus.dylib'), - ('canbus', 'libqtpeakcanbus.dylib'), ('bearer', 'libqgenericbearer.dylib'), - ('imageformats', 'libqgif.dylib'), - ('imageformats', 'libqwbmp.dylib'), - ('imageformats', 'libqwebp.dylib'), - ('imageformats', 'libqico.dylib'), - ('imageformats', 'libqmacheif.dylib'), - ('imageformats', 'libqjpeg.dylib'), - ('imageformats', 'libqtiff.dylib'), - ('imageformats', 'libqicns.dylib'), - ('imageformats', 'libqtga.dylib'), - ('imageformats', 'libqmacjp2.dylib'), - ('texttospeech', 'libqtexttospeech_speechosx.dylib'), - ('generic', 'libqtuiotouchplugin.dylib'), - ('renderplugins', 'libscene2d.dylib'), - ('gamepads', 'libdarwingamepad.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_thai.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_openwnn.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_hangul.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_pinyin.dylib'), - ('virtualkeyboard', 'libqtvirtualkeyboard_tcime.dylib')] + ('generic', 'libqtuiotouchplugin.dylib')] ``` Backport of core [[bitcoin/bitcoin#16477 | PR16477]]. Test Plan: On OSX: ninja osx-dmg On my machine the DMG was ~89MB and is now ~21MB. Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Subscribers: deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7964

a68c7d5 depends: mac_alias 2.2.0 (fanquake) d8e2baf doc: Add explicit macdeployqtplus dependencies install step (Hennadii Stepanov) 013305d macdeploy: use Python 3.6 (fanquake) faf77c3 macdeploy: remove runHDIUtil in favor of directly calling subprocess.run (fanquake) 8bcfd58 macdeploy: remove existing PIVX-Core.dmg if present (fanquake) 023d3ca macdeploy: move qt_conf to where it's used (fanquake) 7cdb5bb macdeploy: consolidate .DS_Store generation (fanquake) 4da04d7 macdeploy: assume plistlib is available (fanquake) 56ab77a macdeploy: have a single level of logging output (fanquake) d111cdf macdeploy: remove add-resources argument (fanquake) 4312410 macdeploy: remove codesigning argument (fanquake) c2ee635 build: automatically determine macOS translations (fanquake) 1c44ecf scripts: filter more qt plugins we don't use in macdeployqtplus (fanquake) c854f78 scripts: misc cleanups in macdeployqtplus (fanquake) a3873ea scripts: use format() in macdeployqtplus (fanquake) a65bea5 scripts: add type annotations to macdeployqtplus (fanquake) ba179e5 build: Drop macports support (Ben Woosley) Pull request description: This is a companion to PIVX-Project#2272 that focuses on on the `.dmg` creation aspect of macOS builds (ie, `make deploy`). The following upstream PRs are backported here: - bitcoin#15175 - bitcoin#16477 - bitcoin#20422 - bitcoin#20890 - bitcoin#21658 Also worth mentioning: This drops support for MacPorts entirely, which has been antiquated and un-maintained for quite some time, and never actually used by any PIVX macOS build doc. ACKs for top commit: furszy: Tested using depends, ACK a68c7d5. random-zebra: utACK a68c7d5 and merging... Tree-SHA512: 3e9fa81a905ca3e90f07ff1213ec69dd1220a19a6a215f256ab67f2594476dc95e8fe88f15a1c9f3314b1757a7a2e5d8e6d7a790d85c117bf4236a3833757430

fanquake added Build system Needs gitian build labels Jul 28, 2019

fanquake requested a review from theuni July 28, 2019 03:12

fanquake added 4 commits July 29, 2019 08:28

scripts: add type annotations to macdeployqtplus

1c37e81

scripts: use format() in macdeployqtplus

51729a4

scripts: misc cleanups in macdeployqtplus

57cdd06

scripts: filter more qt plugins we don't use in macdeployqtplus

1ac7b7f

phonon is no longer a part of Qt as of version 5

fanquake force-pushed the slim_macdeployqtplus branch from da98f6d to 1ac7b7f Compare July 29, 2019 01:36

DrahtBot removed the Needs gitian build label Jul 30, 2019

fanquake merged commit 1ac7b7f into bitcoin:master Sep 10, 2019

fanquake removed the request for review from theuni September 10, 2019 00:55

fanquake deleted the slim_macdeployqtplus branch September 10, 2019 01:10

Fuzzbawls mentioned this pull request May 25, 2021

[Build] [Depends] Unify macOS deploy target PIVX-Project/PIVX#2400

Merged

lyricidal mentioned this pull request Nov 1, 2021

[Upstream] [Build] [Depends] Unify macOS deploy target PRCYCoin/PRCYCoin#138

Merged

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build: skip deploying plugins we dont use in macdeployqtplus #16477

build: skip deploying plugins we dont use in macdeployqtplus #16477

Uh oh!

fanquake commented Jul 28, 2019 •

edited

Loading

Uh oh!

promag commented Jul 28, 2019

Uh oh!

fanquake commented Jul 29, 2019

Uh oh!

laanwj commented Jul 29, 2019

Uh oh!

fanquake commented Jul 30, 2019

Uh oh!

laanwj commented Jul 30, 2019

Uh oh!

DrahtBot commented Jul 30, 2019

Uh oh!

laanwj commented Jul 31, 2019

Uh oh!

hebasto commented Aug 27, 2019

Uh oh!

dongcarl commented Sep 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

build: skip deploying plugins we dont use in macdeployqtplus #16477

build: skip deploying plugins we dont use in macdeployqtplus #16477

Uh oh!

Conversation

fanquake commented Jul 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

promag commented Jul 28, 2019

Uh oh!

fanquake commented Jul 29, 2019

Uh oh!

laanwj commented Jul 29, 2019

Uh oh!

fanquake commented Jul 30, 2019

Uh oh!

laanwj commented Jul 30, 2019

Uh oh!

DrahtBot commented Jul 30, 2019

Uh oh!

laanwj commented Jul 31, 2019

Uh oh!

hebasto commented Aug 27, 2019

Uh oh!

dongcarl commented Sep 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

fanquake commented Jul 28, 2019 •

edited

Loading