rpc: sendrawtransaction help privacy note #16467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
reviewed
Jul 26, 2019
jonatack
force-pushed
the
sendrawtransaction-privacy-note
branch
from
8ea017d to
1b41b1a
Compare
Member
|
unsigned ACK 1b41b1a78baa197daa6978095b8207a1f219a536 (only looked at the diff on GitHub for 5 seconds) |
laanwj
reviewed
Jul 27, 2019
jonatack
force-pushed
the
sendrawtransaction-privacy-note
branch
from
1b41b1a to
47a6013
Compare
|
How does rebroadcasting a tx degrade privacy? |
Member
Author
|
@Relaxo143: It can have the effect of announcing that it is your own txn, see discussion at http://www.erisian.com.au/bitcoin-core-dev/log-2019-07-25.html#l-389 |
In sendrawtransaction RPCHelpMan, mention unconditionality and privacy as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-07-25.html#l-522 Thank you to MarcoFalke and laanwj for their review and suggestions.
jonatack
force-pushed
the
sendrawtransaction-privacy-note
branch
from
47a6013 to
07e01d6
Compare
Member
Author
|
Updated PR and description to address @Relaxo143's (good) question and @MarcoFalke feedback. |
|
Maybe a policy could be implemented so that nodes rebroadcast even transactions which are already in their mempools for let's say up to 10 times. That will prevent privacy leakages and also limit abuse. After the node hears the tx for the eleventh time it will no longer resend it. |
Contributor
|
ACK 07e01d6. (restarted appveyor) |
Member
|
ACK 07e01d6 |
laanwj
added a commit
that referenced
this pull request
Jul 29, 2019
07e01d6 rpc: sendrawtransaction unconditionality/privacy note (Jon Atack) Pull request description: In sendrawtransaction RPCHelpMan, mention unconditionality and privacy as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-07-25.html#l-522 before ``` $ bitcoin-cli help sendrawtransaction sendrawtransaction "hexstring" ( maxfeerate ) Submits raw transaction (serialized, hex-encoded) to local node and network. Also see createrawtransaction and signrawtransactionwithkey calls. (...) ``` after ``` $ bitcoin-cli help sendrawtransaction sendrawtransaction "hexstring" ( maxfeerate ) Submit a raw transaction (serialized, hex-encoded) to local node and network. Note that the transaction will be sent unconditionally to all peers, so using this for manual rebroadcast may degrade privacy by leaking the transaction's origin, as nodes will normally not rebroadcast non-wallet transactions already in their mempool. Also see createrawtransaction and signrawtransactionwithkey calls. (...) ``` ACKs for top commit: promag: ACK 07e01d6. laanwj: ACK 07e01d6 Tree-SHA512: 427b3ca29384eef271eb496b7b14e883220863543a536ddeb31940aaffd52ea0b607d929d50f2b7958514105ef7823fa05c1ee381d4a432808753c06bd97af58
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In sendrawtransaction RPCHelpMan, mention unconditionality and privacy as per http://www.erisian.com.au/bitcoin-core-dev/log-2019-07-25.html#l-522
before
after