Skip to content

Conversation

@jgarzik
Copy link
Contributor

@jgarzik jgarzik commented Jul 31, 2012

Add 'mempool' P2P command, and extend 'getdata' behavior to permit downloading of mempool transactions from the remote peer.

to permit downloading of mempool transactions from the remote peer.
@jgarzik
Copy link
Contributor Author

jgarzik commented Aug 1, 2012

@gmaxwell was asking about testing. This was tested successfully with a one-line pynode patch (pynode HEAD deb07f51435cd0d18596bddfee28e337a5a6454e). pynode issues 'mempool' at startup, and fills its own mempool with the returned results.

--- a/node.py
+++ b/node.py
@@ -238,6 +238,7 @@ class NodeConn(asyncore.dispatcher):
                        self.send_message(msg_verack(self.ver_send))
                        if self.ver_send >= CADDR_TIME_VERSION:
                                self.send_message(msg_getaddr(self.ver_send))
+                       self.send_message(msg_mempool())
                        self.send_getblocks()

@jgarzik
Copy link
Contributor Author

jgarzik commented Aug 2, 2012

Random thought: miners may want this, to "prime the pump" after restarting their bitcoind. There is the incentive to capture every fee-paying transactions, after all.

@BitcoinPullTester
Copy link

@sipa
Copy link
Member

sipa commented Aug 13, 2012

ACK on the changes, but maybe there must at least be some discussion about adding this, and the protocol version change involved. An alternative would be using a service bit (I don't personally think that is preferable), but people may have other opinions.

I would expect the startup sequence to also send a mempool command to another node, in case it reports protocol version 60002 or higher?

@BitcoinPullTester
Copy link

@jgarzik
Copy link
Contributor Author

jgarzik commented Aug 17, 2012

@sipa
Copy link
Member

sipa commented Aug 20, 2012

ACK

1 similar comment
@gavinandresen
Copy link
Contributor

ACK

jgarzik pushed a commit that referenced this pull request Aug 20, 2012
Add 'mempool' P2P command, and extend 'getdata' behavior
@jgarzik jgarzik merged commit b3a570d into bitcoin:master Aug 20, 2012
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
suprnurd pushed a commit to chaincoin-legacy/chaincoin that referenced this pull request Dec 5, 2017
This reverts commit d3829e5.

Reverting and postponing the fix till later. Probably should write a DIP and explore different options first.
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1989

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants