Skip to content

Conversation

@l2a5b1
Copy link
Contributor

@l2a5b1 l2a5b1 commented Jun 28, 2019

This pull request replaces the included <wallet/crypter.h> header in src/bench/ccoins_caching.cpp with <keystore.h> because only the latter is required.

For context see:

Every .cpp and .h file should #include every header file it directly uses classes, functions or other definitions from, even if those headers are already included indirectly through other headers.

Avoid surprises. Avoid having to change #includes if an #included header changes. Avoid accidentally becoming dependent on implementation details and logically separate entities included in a header.

This commit replaces the included `<wallet/crypter.h>` header
in `src/bench/ccoins_caching.cpp` with `<keystore.h>` because
only the latter is required.
@maflcko
Copy link
Member

maflcko commented Jun 28, 2019

Thanks. This is currently being worked on, so please provide this as feedback in

@achow101
Copy link
Member

@l2a5b1 #16227 is refactoring and removing all of the CKeyStore and CBasicKeyStore stuff, including removingkeystore.h entirely. So it can also fix this include at the same time.

@l2a5b1
Copy link
Contributor Author

l2a5b1 commented Jun 28, 2019

@achow101 Thanks!

@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants