test: Make test cases separate functions #16293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
1906-testNoScopeLeak
branch
from
fab7c68 to
1111451
Compare
Contributor
|
Concept ACK |
Contributor
|
This seems like a great direction to go! There's probably more we can do in terms of managing state that's shared between test cases, but just explicitly spelling out which state is shared with self.foo, and unsharing other state, is going to remove 90% of the footgun potential right off the top. |
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsNo conflicts as of last run. |
promag
reviewed
Jun 28, 2019
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
ACK 1111451d1, could squash last commit.
Contributor
There was a problem hiding this comment.
nit, could nuke these "boxes".
maflcko
force-pushed
the
1906-testNoScopeLeak
branch
from
1111451 to
fa11d69
Compare
Member
|
Concept ACK, am updating #15687 to this as well after your review comment. Perhaps document where tests are order-dependent, if any. Will review. |
maflcko
force-pushed
the
1906-testNoScopeLeak
branch
from
fa11d69 to
faf8318
Compare
Member
Author
|
Rebased due to conflict in adjacent line |
maflcko
pushed a commit
that referenced
this pull request
Jul 31, 2019
faf8318 test: Split fundrawtx test into subtests (MarcoFalke) fa6fba3 test: Make local symbols in run_test members (MarcoFalke) Pull request description: This prevents scope-leak of symbols that are supposed to be local to one test case. Top commit has no ACKs. Tree-SHA512: 9b2a4ca2cdd631ef915d2f7e6cd62375df9a0919448350aa6e5ae4aa8a8fe3ba53870f7a9a25a57736894b4e3a45e861018253ed2d57d9a64c2bb65fa270fad8
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Aug 1, 2019
faf8318 test: Split fundrawtx test into subtests (MarcoFalke) fa6fba3 test: Make local symbols in run_test members (MarcoFalke) Pull request description: This prevents scope-leak of symbols that are supposed to be local to one test case. Top commit has no ACKs. Tree-SHA512: 9b2a4ca2cdd631ef915d2f7e6cd62375df9a0919448350aa6e5ae4aa8a8fe3ba53870f7a9a25a57736894b4e3a45e861018253ed2d57d9a64c2bb65fa270fad8
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 30, 2020
Summary: faf8318c55a6001270a6fc8ed2298767099bafba test: Split fundrawtx test into subtests (MarcoFalke) fa6fba3bc8013d7f813edd71f152d86eab907e4d test: Make local symbols in run_test members (MarcoFalke) Pull request description: This prevents scope-leak of symbols that are supposed to be local to one test case. Top commit has no ACKs. Backport of Core [[bitcoin/bitcoin#16293 | PR16293]] Test Plan: `test_runner.py rpc_fundrawtransaction` Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Subscribers: majcosta Differential Revision: https://reviews.bitcoinabc.org/D7688
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents scope-leak of symbols that are supposed to be local to one test case.