tests: Remove unused includes #16278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
|
ACK 30dfe9a86c29e6e95aac236b9273738e392cf86e (checked that added includes are required and that removed includes are not) |
Contributor
| Needs rebase |
practicalswift
force-pushed
the
cut-compilation-bloat-in-unit-tests
branch
from
30dfe9a to
47a15fa
Compare
practicalswift
force-pushed
the
cut-compilation-bloat-in-unit-tests
branch
from
47a15fa to
04754f7
Compare
Member
|
47a15fa47519a5ab16a3d6c1dd3227dd76076365 does not compile. CCLD libsecp256k1.la
CXX test/test_bitcoin-mempool_tests.o
test/fs_tests.cpp:14:26: error: use of undeclared identifier 'GetDataDir'
fs::path tmpfolder = GetDataDir();
^
1 error generated.
make[2]: *** [test/test_bitcoin-fs_tests.o] Error 1
make[2]: *** Waiting for unfinished jobs....
test/flatfile_tests.cpp:16:27: error: use of undeclared identifier 'GetDataDir'
const auto data_dir = GetDataDir();
^
test/flatfile_tests.cpp:29:27: error: use of undeclared identifier 'GetDataDir'
const auto data_dir = GetDataDir();
^
test/flatfile_tests.cpp:90:27: error: use of undeclared identifier 'GetDataDir'
const auto data_dir = GetDataDir();
^
test/flatfile_tests.cpp:110:27: error: use of undeclared identifier 'GetDataDir'
const auto data_dir = GetDataDir();
^
4 errors generated.
make[2]: *** [test/test_bitcoin-flatfile_tests.o] Error 1
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1 |
Contributor
Author
|
@fanquake That was fixed in 04754f7. Please re-review :-) |
maflcko
reviewed
Jun 26, 2019
…g unused includes in tests
practicalswift
force-pushed
the
cut-compilation-bloat-in-unit-tests
branch
from
04754f7 to
9a84169
Compare
practicalswift
changed the title
Member
maflcko
changed the title
maflcko
changed the title
pull bot
pushed a commit
to uniibu/bitcoin
that referenced
this pull request
Jun 27, 2019
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift) Pull request description: Reduce compilation time and unneccessary recompiles by removing unused includes in tests. A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment). ACKs for top commit: Sjors: ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289) Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Mar 26, 2020
Summary: Backport of core [[bitcoin/bitcoin#16278 | PR16278]]. Depends on D5556. Test Plan: ninja all check Run the Gitian builds. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5558
vijaydasmp
pushed a commit
to vijaydasmp/dash
that referenced
this pull request
Nov 26, 2021
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift) Pull request description: Reduce compilation time and unneccessary recompiles by removing unused includes in tests. A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment). ACKs for top commit: Sjors: ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289) Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb
PastaPastaPasta
pushed a commit
to dashpay/dash
that referenced
this pull request
Nov 30, 2021
9a84169 tests: Reduce compilation time and unneccessary recompiles by removing unused includes in tests (practicalswift) Pull request description: Reduce compilation time and unneccessary recompiles by removing unused includes in tests. A subset of bitcoin#16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in bitcoin#16273 (comment). ACKs for top commit: Sjors: ACK 9a84169 on macOS 10.14.5 (I rebased on bitcoin#16289) Tree-SHA512: bcb6ecffef689a9839bee1a5cb93abe83db1f30819a54226c5630fee456b5a5d187507d06861454adfda939c3556a975113f97662e415cb47fa0327ea4fd09fb Co-authored-by: MarcoFalke <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce compilation time and unneccessary recompiles by removing unused includes in tests.
A subset of #16273 ("refactor: Reduce total compilation time by 2% and avoid unnecessary recompiles by removing unused includes") as requested by MarcoFalke in #16273 (comment).