rpc: add 2nd arg to signrawtransactionwithkey examples #16210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.
Contributor
|
ACK, should be backport I guess. |
fanquake
changed the title
Contributor
Author
|
Do I need to do anything more or can I leave this with you guys? I don't know the correct dance steps to get things merged. |
Contributor
|
You are good. |
Contributor
|
Concept ACK Maybe call example keys: |
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jun 17, 2019
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter. Github-Pull: bitcoin#16210 Rebased-From: 71fd628
maflcko
pushed a commit
that referenced
this pull request
Jun 17, 2019
71fd628 Add example 2nd arg to signrawtransactionwithkey (Chris Moore) Pull request description: The RPC examples for signrawtransactionwithkey are missing the 2nd parameter. Before this change the help text showed: Examples: > bitcoin-cli signrawtransactionwithkey "myhex" > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/ With the change, it shows: Examples: > bitcoin-cli signrawtransactionwithkey "myhex" "[\"key1\",\"key2\"]" > curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "signrawtransactionwithkey", "params": ["myhex", "[\"key1\",\"key2\"]"] }' -H 'content-type: text/plain;' http://127.0.0.1:8332/ ACKs for commit 71fd62: Tree-SHA512: dadf6bf0ba64ac356b7b8f9ed4d483384b70080ac4b1664b27a2e72b97f25d7266f3dae89fbeade73c1bae802b5bae7b84d596c93a9ae9c748851ae35758d9a6
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 23, 2019
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter. Github-Pull: bitcoin#16210 Rebased-From: 71fd628
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Aug 24, 2019
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter. Github-Pull: bitcoin#16210 Rebased-From: 71fd628
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPC examples for signrawtransactionwithkey are missing the 2nd parameter.
Before this change the help text showed:
With the change, it shows: