doc: analyzepsbt description in doc/psbt.md #16047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix: replace "RPC" with "PSBT" - output includes the current status of the analyzed psbt's inputs - apply "if possible" to the fee as well as to the estimated weight and feerate, since the fee is only shown if all utxo slots in the psbt have been filled - add "final" to the estimated weight and feerate
Member
|
Eh yes much better |
laanwj
reviewed
May 20, 2019
| - **`analyzepsbt`** is a utility RPC that examines an RPC and reports the | ||
| next steps in the workflow if known, computes the fee of the resulting | ||
| transaction, and estimates the weight and feerate if possible. | ||
| - **`analyzepsbt`** is a utility RPC that examines a PSBT and reports the |
Member
There was a problem hiding this comment.
shouldn't it be "an utility RPC" ?
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
ok
i'm only more confused after reading that 😆 in any case, it's not a blocker for me
Member
Author
There was a problem hiding this comment.
I thought it might be a British English vs American English thing, but turns out the Oxford site here https://en.oxforddictionaries.com/definition/utility says:
British & World English: utility
3 Computing
A utility program.
Member
|
utACK d5dc66e |
laanwj
added a commit
that referenced
this pull request
May 29, 2019
d5dc66e doc: fix/improve analyzepsbt in doc/psbt.md (Jon Atack) Pull request description: - fix: replace "RPC" with "PSBT" - output includes the current status of the analyzed psbt's inputs - apply "if possible" to the fee as well as to the estimated weight and feerate, since the fee is only shown if all utxo slots in the psbt have been filled - add "final" to the estimated weight and feerate ACKs for commit d5dc66: laanwj: ACK d5dc66e fanquake: utACK d5dc66e Tree-SHA512: 61ff1ef45ec34182613b300d21cc2b17a28d1e955f70848f5be1a40c82009fe3000db3332d2cfca1833d7c881b61cc4ebc9fc779238f76d38e9e3f706cfb3551
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 30, 2019
d5dc66e doc: fix/improve analyzepsbt in doc/psbt.md (Jon Atack) Pull request description: - fix: replace "RPC" with "PSBT" - output includes the current status of the analyzed psbt's inputs - apply "if possible" to the fee as well as to the estimated weight and feerate, since the fee is only shown if all utxo slots in the psbt have been filled - add "final" to the estimated weight and feerate ACKs for commit d5dc66: laanwj: ACK d5dc66e fanquake: utACK d5dc66e Tree-SHA512: 61ff1ef45ec34182613b300d21cc2b17a28d1e955f70848f5be1a40c82009fe3000db3332d2cfca1833d7c881b61cc4ebc9fc779238f76d38e9e3f706cfb3551
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 5, 2020
Summary: Backport of Core [[bitcoin/bitcoin#15757 | PR15757]] and [[bitcoin/bitcoin#16047 | PR16047]] Depends on D7758 Test Plan: Check rendering of markdown in a viewer. Verify all commands added to the doc are listed in `bitcoin-cli help` Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien Differential Revision: https://reviews.bitcoinabc.org/D7759
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: replace "RPC" with "PSBT"
output includes the current status of the analyzed psbt's inputs
apply "if possible" to the fee as well as to the estimated weight and feerate, since the fee is only shown if all utxo slots in the psbt have been filled
add "final" to the estimated weight and feerate