qt: fix opening bitcoin.conf via Preferences on macOS #16044

web3shannon · 2019-05-19T08:48:08Z

Fix #15409. The QT wallet fail to open the configuration file on Mac, when these is no default application for *.conf files.

Here is a feasible way to solve this bug. When QDesktopServices::openUrl fails to open file:///path/bitcoin.conf with its default application, use QProcess::startDetached to run open -t /path/bitcoin.conf command instead, so as to open the configuration file with system's default text editor.

fanquake · 2019-05-19T08:59:26Z

to run "open -t qtum.conf

What is qtum.conf ?

web3shannon · 2019-05-19T09:01:14Z

Sorry. Since I find this bug initially in the Qtum blockchain, I wrote it wrong and have changed the text...

hebasto · 2019-05-19T10:07:13Z

The mentioned issue #15409 is related to the setting a default application to open *.conf files.
This can be easily achieved via macOS GUI.

/usr/bin/open -t forces to open a file with default text editor. This implies the setting a default application to open *.conf files will not work, right?

@shannon1916 your PR description could be edited using this GitHub tips ;)

web3shannon · 2019-05-19T12:37:52Z

@hebasto The PR description is modified as you suggest.

And, /usr/bin/open -t only works when QDesktopServices::openUrl fails, as detailed in the PR description.

hebasto · 2019-05-19T12:43:33Z

Concept ACK. Will test.

hebasto · 2019-05-19T14:28:15Z

tACK 57b30ce16cf6d4d2e6a30e70ede7f2bdd5fbc003 modulo nits (macOS 10.13.6)

As my system already has a default app to open *.conf files, the next patch was applied for testing purpose:

diff --git a/src/util/system.cpp b/src/util/system.cpp
index 6925bda4e..a5e24c0f3 100644
--- a/src/util/system.cpp
+++ b/src/util/system.cpp
@@ -72 +72 @@ const int64_t nStartupTime = GetTime();
-const char * const BITCOIN_CONF_FILENAME = "bitcoin.conf";
+const char * const BITCOIN_CONF_FILENAME = "bitcoin.conftest";

src/qt/guiutil.cpp

web3shannon · 2019-05-20T00:56:27Z

@hebasto The default app for *.conf files can be set in System Preferences -> Default Apps -> Extensions, as shown below

jonasschnelli · 2019-05-20T09:25:07Z

Too bad this required a MAC #ifdef and a fixed path to an executable. But I guess it's an acceptable fix.
utACK 0ebaa3ad8c252e8d6da37ac62ed568237bbb4bad

src/qt/guiutil.cpp

fanquake

Concept ACK

Have checked that this change works on macOS with and without a .conf file already in place.
In the later case a blank .conf is created and opened.

Will re-ack post comment fix-up and squash.

src/qt/guiutil.cpp

hebasto · 2019-06-03T06:48:33Z

re-ACK 6e6494b

fanquake · 2019-06-03T14:09:45Z

tACK 6e6494b on macOS 10.14.x

Using master (c7cfd20) you cannot open bitcoin.conf through the preferences menu:

Using this PR (6e6494b):

Opening an existing bitcoin.conf works, and if one doesn't exist, a blank one is created and opened.

lldb Bitcoin-Qt.app -- -regtest
(lldb) target create "Bitcoin-Qt.app"
Current executable set to 'Bitcoin-Qt.app' (x86_64).
(lldb) settings set -- target.run-args  "-regtest"
(lldb) run
Process 40791 launched: '/Users/michael/github/bitcoin/Bitcoin-Qt.app/Contents/MacOS/Bitcoin-Qt' (x86_64)
2019-06-03 10:00:00.852544-0400 Bitcoin-Qt[40791:8481788] MessageTracer: Falling back to default whitelist
2019-06-03 10:00:07.232235-0400 open[40799:8481923] MessageTracer: Falling back to default whitelist
2019-06-03 10:00:19.079914-0400 open[40928:8482455] MessageTracer: Falling back to default whitelist

promag · 2019-06-03T15:32:01Z

src/qt/guiutil.cpp

+#ifdef Q_OS_MAC
+    // Workaround for macOS-specific behavior; see #15409.
+    if (!res) {
+        res = QProcess::startDetached("/usr/bin/open", QStringList{"-t", boostPathToQString(pathConfig)});


Just "open"?

high-sierra:~ hebasto$ /usr/bin/open Usage: open [-e] [-t] [-f] [-W] [-R] [-n] [-g] [-h] [-s <partial SDK name>][-b <bundle identifier>] [-a <application>] [filenames] [--args arguments] Help: Open opens files from a shell. By default, opens each file using the default application for that file. If the file is in the form of a URL, the file will be opened as a URL. Options: -a Opens with the specified application. -b Opens with the specified application bundle identifier. -e Opens with TextEdit. -t Opens with default text editor. -f Reads input from standard input and opens with TextEdit. -F --fresh Launches the app fresh, that is, without restoring windows. Saved persistent state is lost, excluding Untitled documents. -R, --reveal Selects in the Finder instead of opening. -W, --wait-apps Blocks until the used applications are closed (even if they were already running). --args All remaining arguments are passed in argv to the application's main() function instead of opened. -n, --new Open a new instance of the application even if one is already running. -j, --hide Launches the app hidden. -g, --background Does not bring the application to the foreground. -h, --header Searches header file locations for headers matching the given filenames, and opens them. -s For -h, the SDK to use; if supplied, only SDKs whose names contain the argument value are searched. Otherwise the highest versioned SDK in each platform is used.

The explicit path seems better, right?

As this is an OS specific hack, I think hardcoding the path seems fine, it's always that.

6e6494b qt: fix opening bitcoin.conf via Preferences on macOS; see #15409 (shannon1916) Pull request description: Fix #15409. The QT wallet fail to open the configuration file on Mac, when these is no default application for `*.conf` files. Here is a feasible way to solve this bug. When `QDesktopServices::openUrl` fails to open `file:///path/bitcoin.conf` with its default application, use `QProcess::startDetached` to run `open -t /path/bitcoin.conf` command instead, so as to open the configuration file with system's default text editor. ACKs for commit 6e6494: hebasto: re-ACK 6e6494b fanquake: tACK 6e6494b on macOS 10.14.x Tree-SHA512: 60e898f4cb77cfd7b8adbc8d33fbebf46bac2a801bdcf40cae15e24b78ad56b1f32358b1879b670623d9f8651dea93961d34269358cea18f4e15b089a8ffcfbf

fanquake · 2019-06-07T08:03:03Z

Backported in #16035.

Github-Pull: bitcoin#16044 Rebased-From: 6e6494b

a41da9f [QT] fix opening *.conf/log files on macOS when there is no default app to open them. (furszy) Pull request description: Built on top of #1515, only last commit counts for this. When MacOS has no default app to open *.conf and *.log throws an error instead of try to open them with a text editor. This PR solves the issue. Coming from btc@[16044](bitcoin#16044) ACKs for top commit: random-zebra: utACK a41da9f Fuzzbawls: utACK a41da9f Tree-SHA512: 5316e3a501576ed240cff9db32526eba7456112b8ad3024e5095a924a1da27f5ad5033fb3a4c50df305d262362e66abdffe2d17ff942895893e9889750dc8bf8

Summary: 6e6494b3fb345848025494cb7a79c5bf8f35e417 qt: fix opening bitcoin.conf via Preferences on macOS; see #15409 (shannon1916) Pull request description: Fix #15409. The QT wallet fail to open the configuration file on Mac, when these is no default application for `*.conf` files. Here is a feasible way to solve this bug. When `QDesktopServices::openUrl` fails to open `file:///path/bitcoin.conf` with its default application, use `QProcess::startDetached` to run `open -t /path/bitcoin.conf` command instead, so as to open the configuration file with system's default text editor. --- Backport of Core [[bitcoin/bitcoin#16044 | PR16044]] Test Plan: ninja all check check-functional I don't have a mac to test this unfortunately Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D8665

fanquake added GUI macOS labels May 19, 2019

web3shannon changed the title ~~fix the bug of OPEN CONFIGURATION FILE on Mac~~ qt: fix the bug of OPEN CONFIGURATION FILE on Mac May 19, 2019

hebasto reviewed May 19, 2019

View reviewed changes

src/qt/guiutil.cpp Outdated Show resolved Hide resolved

src/qt/guiutil.cpp Outdated Show resolved Hide resolved

laanwj reviewed May 20, 2019

View reviewed changes

src/qt/guiutil.cpp Outdated Show resolved Hide resolved

web3shannon mentioned this pull request May 21, 2019

The configuration file could not be opened. #15409

Closed

fanquake reviewed May 30, 2019

View reviewed changes

src/qt/guiutil.cpp Outdated Show resolved Hide resolved

fanquake changed the title ~~qt: fix the bug of OPEN CONFIGURATION FILE on Mac~~ qt: fix opening bitcoin.conf via Preferences on macOS May 30, 2019

qt: fix opening bitcoin.conf via Preferences on macOS; see #15409

6e6494b

fanquake added the Needs backport label Jun 3, 2019

fanquake added this to the 0.18.1 milestone Jun 3, 2019

promag reviewed Jun 3, 2019

View reviewed changes

laanwj merged commit 6e6494b into bitcoin:master Jun 3, 2019

web3shannon mentioned this pull request Jun 6, 2019

Cannot open configuration file in QT wallet on Mac qtumproject/qtum#689

Closed

fanquake removed the Needs backport label Jun 7, 2019

maflcko pushed a commit to maflcko/bitcoin-core that referenced this pull request Jun 7, 2019

qt: fix opening bitcoin.conf via Preferences on macOS; see bitcoin#15409

b55cbe8

Github-Pull: bitcoin#16044 Rebased-From: 6e6494b

HashUnlimited pushed a commit to HashUnlimited/chaincoin that referenced this pull request Aug 23, 2019

qt: fix opening bitcoin.conf via Preferences on macOS; see bitcoin#15409

732e55d

Github-Pull: bitcoin#16044 Rebased-From: 6e6494b

Bushstar pushed a commit to Bushstar/omnicore that referenced this pull request Aug 24, 2019

qt: fix opening bitcoin.conf via Preferences on macOS; see bitcoin#15409

3da1698

Github-Pull: bitcoin#16044 Rebased-From: 6e6494b

furszy mentioned this pull request Apr 10, 2020

[GUI] MacOS fix open files with no default app. PIVX-Project/PIVX#1516

Merged

This was referenced Oct 9, 2020

Various changes --- BlockPo/BlockPo-to-Tradelayer#378

Closed

Various changes --- BlockPo/BlockPo-to-Tradelayer#379

Merged

lyricidal mentioned this pull request Sep 13, 2021

[Upstream] [GUI] MacOS fix open files with no default app. PRCYCoin/PRCYCoin#115

Merged

kwvg added a commit to kwvg/dash that referenced this pull request Nov 4, 2021

merge bitcoin#16044: fix opening bitcoin.conf via Preferences on macOS

81d22b7

kwvg added a commit to kwvg/dash that referenced this pull request Nov 11, 2021

merge bitcoin#16044: fix opening bitcoin.conf via Preferences on macOS

843e6d4

pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021

merge bitcoin#16044: fix opening bitcoin.conf via Preferences on macOS

7436f56

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

qt: fix opening bitcoin.conf via Preferences on macOS #16044

qt: fix opening bitcoin.conf via Preferences on macOS #16044

Uh oh!

Conversation

web3shannon commented May 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fanquake commented May 19, 2019

Uh oh!

web3shannon commented May 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hebasto commented May 19, 2019

Uh oh!

web3shannon commented May 19, 2019

Uh oh!

hebasto commented May 19, 2019

Uh oh!

hebasto commented May 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

web3shannon commented May 20, 2019

Uh oh!

jonasschnelli commented May 20, 2019

Uh oh!

Uh oh!

fanquake left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hebasto commented Jun 3, 2019

Uh oh!

fanquake commented Jun 3, 2019

Uh oh!

promag Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

hebasto Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

hebasto Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

laanwj Jun 3, 2019

Choose a reason for hiding this comment

Uh oh!

fanquake commented Jun 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

web3shannon commented May 19, 2019 •

edited

Loading

web3shannon commented May 19, 2019 •

edited

Loading

hebasto commented May 19, 2019 •

edited

Loading