Add tests and documentation for blocksonly #15990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to distinguish it from CNode::fRelayTxes and avoid bugs like 425278d
maflcko
force-pushed
the
1905-docTestBlocksOnly
branch
from
fae64e6 to
fae9f79
Compare
promag
reviewed
May 9, 2019
promag
reviewed
May 9, 2019
Contributor
promag
left a comment
promag
left a comment
There was a problem hiding this comment.
utACK fae9f795eb1283d82761ffef7e7feffe2597cf59.
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
|
Great work! |
maflcko
force-pushed
the
1905-docTestBlocksOnly
branch
from
fae9f79 to
fac2396
Compare
jonatack
reviewed
May 13, 2019
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
ACK fac23965b1130175a01a4b35d4108f1d7c42ac10. Nice tests and docs. TIL blocksonly is no longer hidden.
Before:
$ bitcoind -help-debug | grep -A3 -- -blocksonly
-blocksonly
Whether to operate in a blocks only mode (default: 0)
$ bitcoind -help | grep -A3 -- -blocksonly
After:
$ bitcoind -help-debug | grep -A3 -- -blocksonly
-blocksonly
Whether to reject transactions from network peers. Transactions from the
wallet or RPC are not affected. (default: 0)
$ bitcoind -help | grep -A3 -- -blocksonly
-blocksonly
Whether to reject transactions from network peers. Transactions from the
wallet or RPC are not affected. (default: 0)
jonatack
reviewed
May 13, 2019
maflcko
force-pushed
the
1905-docTestBlocksOnly
branch
from
fac2396 to
fa9c829
Compare
Member
Author
|
Replied to or addressed @jonatack s nits. Only doc-changes in the last force push |
Member
Author
|
Also addressed @promag s feedback |
Contributor
|
Concept ACK - will review today. |
jamesob
reviewed
May 13, 2019
doc/reduce-traffic.md
Outdated
test/functional/p2p_blocksonly.py
Outdated
Contributor
There was a problem hiding this comment.
Maybe I'm just being thick here, but shouldn't we assert that the mininode hasn't received a message containing the new tx from self.nodes[0] after this sync_with_ping()?
Member
Author
There was a problem hiding this comment.
You mean spinning up a second mininode to check that that one didn't receive it?
I think adding a getmempoolinfo()['size']==0 should do the same?
Contributor
There was a problem hiding this comment.
Yep, the latter sounds good.
jnewbery
reviewed
May 13, 2019
Contributor
jnewbery
left a comment
jnewbery
left a comment
There was a problem hiding this comment.
utACK fa9c8295ea6420fe6ea2ca2a0b828e05689c2d92. One suggested change to the docs.
maflcko
force-pushed
the
1905-docTestBlocksOnly
branch
from
fa9c829 to
979519e
Compare
maflcko
force-pushed
the
1905-docTestBlocksOnly
branch
from
979519e to
fa8ced3
Compare
Contributor
Member
|
utACK fa8ced3, thanks for adding documentation! |
laanwj
added a commit
that referenced
this pull request
May 16, 2019
fa8ced3 doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) fa320de test: Add test for p2p_blocksonly (MarcoFalke) fa3872e test: Format predicate source as multiline on error (MarcoFalke) fa1dce7 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) Pull request description: This is de-facto no longer hidden ACKs for commit fa8ced: jamesob: utACK fa8ced3 Tree-SHA512: 474fbdee6cbd035ed9068a066b6056c1f909ec7520be0417820fcd1672ab3069b53f55c5147968978d9258fd3a3933fe1a9ef8e4f6e14fb6ebbd79701a0a1245
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 16, 2019
This helps to distinguish it from CNode::fRelayTxes and avoid bugs like 425278d Github-Pull: bitcoin#15990 Rebased-From: fa1dce7
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 16, 2019
Github-Pull: bitcoin#15990 Rebased-From: fa3872e
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 16, 2019
Github-Pull: bitcoin#15990 Rebased-From: fa320de
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
May 16, 2019
Github-Pull: bitcoin#15990 Rebased-From: fa8ced3
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
May 18, 2019
fa8ced3 doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) fa320de test: Add test for p2p_blocksonly (MarcoFalke) fa3872e test: Format predicate source as multiline on error (MarcoFalke) fa1dce7 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) Pull request description: This is de-facto no longer hidden ACKs for commit fa8ced: jamesob: utACK bitcoin@fa8ced3 Tree-SHA512: 474fbdee6cbd035ed9068a066b6056c1f909ec7520be0417820fcd1672ab3069b53f55c5147968978d9258fd3a3933fe1a9ef8e4f6e14fb6ebbd79701a0a1245
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 23, 2019
This helps to distinguish it from CNode::fRelayTxes and avoid bugs like 425278d Github-Pull: bitcoin#15990 Rebased-From: fa1dce7
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 23, 2019
Github-Pull: bitcoin#15990 Rebased-From: fa3872e
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 23, 2019
Github-Pull: bitcoin#15990 Rebased-From: fa320de
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 23, 2019
Github-Pull: bitcoin#15990 Rebased-From: fa8ced3
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Aug 24, 2019
This helps to distinguish it from CNode::fRelayTxes and avoid bugs like 425278d Github-Pull: bitcoin#15990 Rebased-From: fa1dce7
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Aug 24, 2019
Github-Pull: bitcoin#15990 Rebased-From: fa3872e
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Aug 24, 2019
Github-Pull: bitcoin#15990 Rebased-From: fa320de
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Aug 24, 2019
Github-Pull: bitcoin#15990 Rebased-From: fa8ced3
deadalnix
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Jun 8, 2020
Summary: * net: Rename ::fRelayTxes to ::g_relay_txes This helps to distinguish it from CNode::fRelayTxes and avoid bugs like 425278d * test: Format predicate source as multiline on error * test: Add test for p2p_blocksonly * doc: Mention blocksonly in reduce-traffic.md, unhide option This is a backport of Core [[bitcoin/bitcoin#15990 | PR15990]] Test Plan: ninja all check-all Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D6424
zkbot
added a commit
to zcash/zcash
that referenced
this pull request
Mar 31, 2021
Add -blocksonly option Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#6993 - bitcoin/bitcoin#7046 - bitcoin/bitcoin#6780 - The third commit (we backported the rest in #2390). - bitcoin/bitcoin#7126 - bitcoin/bitcoin#7439 - bitcoin/bitcoin#15990 - Only the `-blocksonly` documentation changes. - bitcoin/bitcoin#16555 - bitcoin/bitcoin#18391 - Only the `-blocksonly` documentation changes. Part of #2074.
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 20, 2021
fa8ced3 doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) fa320de test: Add test for p2p_blocksonly (MarcoFalke) fa3872e test: Format predicate source as multiline on error (MarcoFalke) fa1dce7 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) Pull request description: This is de-facto no longer hidden ACKs for commit fa8ced: jamesob: utACK bitcoin@fa8ced3 Tree-SHA512: 474fbdee6cbd035ed9068a066b6056c1f909ec7520be0417820fcd1672ab3069b53f55c5147968978d9258fd3a3933fe1a9ef8e4f6e14fb6ebbd79701a0a1245
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 20, 2021
fa8ced3 doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) fa320de test: Add test for p2p_blocksonly (MarcoFalke) fa3872e test: Format predicate source as multiline on error (MarcoFalke) fa1dce7 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) Pull request description: This is de-facto no longer hidden ACKs for commit fa8ced: jamesob: utACK bitcoin@fa8ced3 Tree-SHA512: 474fbdee6cbd035ed9068a066b6056c1f909ec7520be0417820fcd1672ab3069b53f55c5147968978d9258fd3a3933fe1a9ef8e4f6e14fb6ebbd79701a0a1245
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 21, 2021
fa8ced3 doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) fa320de test: Add test for p2p_blocksonly (MarcoFalke) fa3872e test: Format predicate source as multiline on error (MarcoFalke) fa1dce7 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) Pull request description: This is de-facto no longer hidden ACKs for commit fa8ced: jamesob: utACK bitcoin@fa8ced3 Tree-SHA512: 474fbdee6cbd035ed9068a066b6056c1f909ec7520be0417820fcd1672ab3069b53f55c5147968978d9258fd3a3933fe1a9ef8e4f6e14fb6ebbd79701a0a1245
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
May 9, 2022
fa8ced3 doc: Mention blocksonly in reduce-traffic.md, unhide option (MarcoFalke) fa320de test: Add test for p2p_blocksonly (MarcoFalke) fa3872e test: Format predicate source as multiline on error (MarcoFalke) fa1dce7 net: Rename ::fRelayTxes to ::g_relay_txes (MarcoFalke) Pull request description: This is de-facto no longer hidden ACKs for commit fa8ced: jamesob: utACK bitcoin@fa8ced3 Tree-SHA512: 474fbdee6cbd035ed9068a066b6056c1f909ec7520be0417820fcd1672ab3069b53f55c5147968978d9258fd3a3933fe1a9ef8e4f6e14fb6ebbd79701a0a1245
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is de-facto no longer hidden