Docs: Improve build-osx document formatting #15964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Contributor
Author
|
Any update on this? |
fanquake
reviewed
Jun 3, 2019
Member
fanquake
left a comment
fanquake
left a comment
There was a problem hiding this comment.
Concept ACK. Skimmed through and didn't see any incorrect changes.
Can you fixup the nits I've left inline.
Contributor
Author
|
Any update on this? |
fanquake
added a commit
that referenced
this pull request
Jun 29, 2019
dbd137a Improve build-osx formatting (Giulio Lombardo) Pull request description: This `PR` will improve `build-osx.md` formatting by: 1. Updating Markdown syntax to the latest one 2. Adding syntax highlighting to all code blocks 3. Aligning the text up to `80` column guideline (before it was following different guidelines, sometime `80`, sometime `90`, etc.) 4. Small grammar improvements here and there ACKs for top commit: fanquake: ACK dbd137a - Document reads and renders essentially the same as the current `build-osx.md`, with minor formatting / grammatical changes. Tree-SHA512: 47747991b5fddf0725c82f17f153e83150e51f698787544b4c51b32479989e4b550e2b3aec92979d2b0c76edfdcbbe7c4d9d0115df12e2bfde0cfcb277e9b984
maflcko
reviewed
Jun 29, 2019
| ## Notes | ||
| * Tested on OS X 10.10 Yosemite through macOS 10.14 Mojave on 64-bit Intel | ||
| processors only. | ||
| * Building with downloaded Qt binaries is not officially supported. See the notes in [#7714](https://github.com/bitcoin/issues/7714) |
jonatack
added a commit
to jonatack/bitcoin
that referenced
this pull request
Jun 29, 2019
This fixes the regression in PR bitcoin#15964 as noted here: https://github.com/bitcoin/bitcoin/pull/15964/files#r298798933
fanquake
added a commit
that referenced
this pull request
Jun 30, 2019
90b5c4e doc: Fix broken link in doc/build-osx.md (Jon Atack) Pull request description: This fixes the regression in PR #15964 as noted here: https://github.com/bitcoin/bitcoin/pull/15964/files#r298798933 ACKs for top commit: hebasto: ACK 90b5c4e. Provided link verified. fanquake: ACK 90b5c4e. Thanks. Tree-SHA512: 2197809d37c357d36097839941ba3cee32e4d6ba2e4d609d99fb04286330d9dbcb89d6331fe1aa798fdb5964e522970f57b8ce0c2cb034b0f48b77b1d60e33e1
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 30, 2019
dbd137a Improve build-osx formatting (Giulio Lombardo) Pull request description: This `PR` will improve `build-osx.md` formatting by: 1. Updating Markdown syntax to the latest one 2. Adding syntax highlighting to all code blocks 3. Aligning the text up to `80` column guideline (before it was following different guidelines, sometime `80`, sometime `90`, etc.) 4. Small grammar improvements here and there ACKs for top commit: fanquake: ACK dbd137a - Document reads and renders essentially the same as the current `build-osx.md`, with minor formatting / grammatical changes. Tree-SHA512: 47747991b5fddf0725c82f17f153e83150e51f698787544b4c51b32479989e4b550e2b3aec92979d2b0c76edfdcbbe7c4d9d0115df12e2bfde0cfcb277e9b984
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 30, 2019
This fixes the regression in PR bitcoin#15964 as noted here: https://github.com/bitcoin/bitcoin/pull/15964/files#r298798933
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 30, 2019
This fixes the regression in PR bitcoin#15964 as noted here: https://github.com/bitcoin/bitcoin/pull/15964/files#r298798933
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
PRwill improvebuild-osx.mdformatting by:80column guideline (before it was following different guidelines, sometime80, sometime90, etc.)