gitian: Remove Windows 32 bit build #15939

maflcko · 2019-05-02T12:41:05Z

The Windows 32 bit build has been removed from https://bitcoincore.org/en/download/, so unless there are complaints, we don't need to build it even

luke-jr · 2019-05-02T12:42:22Z

contrib/gitian-descriptors/gitian-win.yml

This looks so bare. Almost makes me want to build a PPC64 Windows binary just for the sake of it. :)

Can you install windows on ppc even?

o dear I have been running bitcoin core on a 32-bit windows system for a few years now. Am I the last one? I'd like to upgrade to 0.18 please. Any chance of having 32-bit windows back, or is it too much bother?

Why can't you use the 64-bit build?

I'll defer to someone who knows more than me, but can a 64-bit build run on a 32-bit machine?

practicalswift · 2019-05-02T13:05:47Z

Concept ACK

laanwj · 2019-05-02T13:55:38Z

even in the unlikely case that we decide to restore it for 0.18, I think removing it for 0.19 ~~is non-controversial~~
utACK faf04430963cb991f730e83d9a66474b6a93967a

DrahtBot · 2019-05-02T15:33:29Z

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#15068 (Install icon & .desktop file to XDG data by luke-jr)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

achow101 · 2019-05-02T16:57:01Z

utACK faf04430963cb991f730e83d9a66474b6a93967a

practicalswift · 2019-05-03T07:26:17Z

utACK faf04430963cb991f730e83d9a66474b6a93967a

maflcko · 2019-05-03T17:42:04Z

Removed it from depends and travis as well

fanquake · 2019-05-06T02:42:54Z

Concept ACK

laanwj · 2019-05-06T09:58:13Z

This was bound to be a somewhat controversial decision: however one architecture per platform is great for maintenance-heavy outlier platforms such as Windows (and MacOSX). This allows for more focus in testing and, and hopefully a better user experience and better security, in time. Cross-compilation to windows is fraught with some risks, and they're minimized by only having one toolchain (mingw-w64) to check.

If you need a wider range of architectures it's better to stick with Linux, or one of the BSDs. Another option is to use a VM. I was about to suggest WSL, but there's no 32-bit support either!

luke-jr · 2019-05-06T12:27:17Z

I do think we should keep the Travis job around...

DrahtBot · 2019-05-06T19:25:55Z

Gitian builds for commit d7d7d31 (master):

c59f3c978c4c518bfe56067b11ce2bbc... bitcoin-0.18.99-osx-unsigned.dmg
f2907fbbcd626dcb056ead2c9cb65c05... bitcoin-0.18.99-osx64.tar.gz
3cceb902ab481a5bfbf43f5c9319603b... bitcoin-0.18.99-win32-debug.zip
f2955f7cca2738c0699d2f006dbaf5e9... bitcoin-0.18.99-win32-setup-unsigned.exe
86436426811cfb6264011ee0db921016... bitcoin-0.18.99-win32.zip
5e00d70e672b5eac1d6072feb39b137d... bitcoin-0.18.99-win64-debug.zip
42c7f2e5a1b9a5420634e8d4bb257170... bitcoin-0.18.99-win64-setup-unsigned.exe
2d64034e16227a7c5169498521f3f7a7... bitcoin-0.18.99-win64.zip
2f9f4764037d2f2db897b02224b413a8... bitcoin-core-osx-0.19-res.yml
1d66196d817ba0c994edf3a72a21fda5... bitcoin-core-win-0.19-res.yml
bcf951923e910086fa7f9dcd9e27af45... bitcoin-linux-build.log
6238adfdae5c4d5a1802ae9b163cf4b8... bitcoin-osx-build.log
d57bf770ebdbb8175c0f482ffdff50e1... bitcoin-win-build.log

Gitian builds for commit d102d5df176068bfe5f6cf5bb09eeebaad6c27da (master and this pull):

7164406f52f0aa5a209ddd66da78a9fc... bitcoin-0.18.99-osx-unsigned.dmg
578369b976a751683da8f6562adbd6d1... bitcoin-0.18.99-osx64.tar.gz
7568613de409d2e84c07108fd5757734... bitcoin-0.18.99-win64-debug.zip
5819f3531f8aec671f356def6aa4bfdc... bitcoin-0.18.99-win64-setup-unsigned.exe
ba0da74910d99b668e4123b02efea4ed... bitcoin-0.18.99-win64.zip
41e9570a254033a0d66601377165c27f... bitcoin-core-osx-0.19-res.yml
e36439aa0696ed97120bc699588fec2f... bitcoin-core-win-0.19-res.yml
de48b5a1f6675f0b49ada3d21350862a... bitcoin-linux-build.log
da31f36bf25f5755d2a67f17f5be0271... bitcoin-osx-build.log
afadb21900e2042fe5355f74bf7b762f... bitcoin-win-build.log

fanquake · 2019-05-08T15:33:40Z

There's a few more win32 references that can be removed:

https://github.com/bitcoin/bitcoin/blame/master/doc/release-process.md#L224

bitcoin/contrib/gitian-build.py

Line 101 in c459c5f

    
           subprocess.check_call('mv build/out/bitcoin-*win32-setup.exe ../bitcoin-binaries/'+args.version, shell=True)

maflcko · 2019-05-08T15:48:44Z

Thanks, done

luke-jr · 2019-05-08T16:29:51Z

.travis.yml

-        RUN_FUNCTIONAL_TESTS=false
-        GOAL="deploy"
-        BITCOIN_CONFIG="--enable-reduce-exports --disable-gui-tests"
-


Let's keep the Travis job...

Why? I am not aware that this job ever failed and the win64 one didn't. Also, why would we want to waste resources on testing a target that we never ship?
I'd rather have freebsd tests than a win32 one.

We ship source code.

It is the responsibility of the user to run the tests. You could argue that many users don't run the tests on their target when they download the gitian binaries, but that doesn't apply here. If some users compile on their own, they need to run the tests themselves.

Travis doesn't exist to run the tests. It exists to help us developers avoid doing things that will break the tests. (Running the tests is just how we accomplish that.)

Either we support win32, test and ship it, or we don't. There is no in-between.

I do not agree. We support plenty of things we do not recommend or ship binaries for.

Indeed, the best approach is to compile yourself, which itself falls outside the "ship" scope.

FWIW I agree with @MarcoFalke here -- seems like not a great use of travis resources to explicitly test a platform that we're no longer interested in continuing to support (who will debug problems if they are found?). On top of that, reducing the load on travis has benefits; I've noticed that the time I wait from updating a PR to having the travis jobs complete has ticked up recently. So I'd rather we not spend those travis cycles on win32 unless it was an important platform to test on for some reason, and the decision to drop it strikes me as a statement that it's not.

The decision not to provide binaries isn't necessarily a decision to drop support.

(That being said, I certainly am not interested in providing support, so if nobody else is either...)

fanquake · 2019-05-09T02:34:37Z

utACK fa193dc

I agree with @MarcoFalke & @sdaftuar about Travis. I don't think we should have a job dedicated to a binary we aren't shipping.

laanwj · 2019-05-09T19:19:58Z

utACK fa193dc

fa193dc doc: Remove win32 from the release process (MarcoFalke) faf666f Remove Windows 32 bit build (MarcoFalke) Pull request description: The Windows 32 bit build has been removed from https://bitcoincore.org/en/download/, so unless there are complaints, we don't need to build it even ACKs for commit fa193d: fanquake: utACK fa193dc Tree-SHA512: d6f2976a2e0c407698f720b00ac23ec4056626de4eff8621f4c5581120af0460afd1bdef72329cc0e7d92afca48d94ae5fce6777cb36bfabb60b8034ff08fd88

fa193dc doc: Remove win32 from the release process (MarcoFalke) faf666f Remove Windows 32 bit build (MarcoFalke) Pull request description: The Windows 32 bit build has been removed from https://bitcoincore.org/en/download/, so unless there are complaints, we don't need to build it even ACKs for commit fa193d: fanquake: utACK bitcoin@fa193dc Tree-SHA512: d6f2976a2e0c407698f720b00ac23ec4056626de4eff8621f4c5581120af0460afd1bdef72329cc0e7d92afca48d94ae5fce6777cb36bfabb60b8034ff08fd88

449872b [Build] Remove Windows 32 bit build, coming from btc@faf666f8148eeb305a9c4f78459aff2c7268016b (furszy) Pull request description: Coming from [btc@15939](bitcoin#15939). Based on #1315. ACKs for top commit: Fuzzbawls: ACK 449872b random-zebra: ACK 449872b and merging... Tree-SHA512: 39c8785ade1202c09c76d964fdc3c739f9e162fec5c9b2991ee9a0a60c4935485c3822be82fd2e279fe536e049b3b1e4a9d5137145505adc09feea850420d8f0

Summary: The win32 target will no longer be part of our release nor officially supported. It is still possible for users to run the build by themselves, but the instructions are removed from the doc in order to reflect the "unsupported" status of this target. Backport of core [[bitcoin/bitcoin#15939 | PR15939]]. Depends on D5610. Test Plan: Run the Windows Gitian build. Check the win32 binaries are no longer part of the output. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5612

This partially reverts commit faf666f.

449872b167e86060578d196d6e4d6ecb52a69f64 [Build] Remove Windows 32 bit build, coming from btc@faf666f8148eeb305a9c4f78459aff2c7268016b (furszy) Pull request description: Coming from [btc@15939](bitcoin/bitcoin#15939). Based on #1315. ACKs for top commit: Fuzzbawls: ACK 449872b167e86060578d196d6e4d6ecb52a69f64 random-zebra: ACK 449872b167e86060578d196d6e4d6ecb52a69f64 and merging... Tree-SHA512: 39c8785ade1202c09c76d964fdc3c739f9e162fec5c9b2991ee9a0a60c4935485c3822be82fd2e279fe536e049b3b1e4a9d5137145505adc09feea850420d8f0 # Conflicts: # contrib/devtools/test-security-check.py # doc/release-process.md

Summary: The win32 target will no longer be part of our release nor officially supported. It is still possible for users to run the build by themselves, but the instructions are removed from the doc in order to reflect the "unsupported" status of this target. Backport of core [[bitcoin/bitcoin#15939 | PR15939]]. Depends on D5610. Test Plan: Run the Windows Gitian build. Check the win32 binaries are no longer part of the output. Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Subscribers: jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D5612 Conflicts: doc/build-windows.md doc/release-notes.md

This partially reverts commit faf666f.

fa193dc doc: Remove win32 from the release process (MarcoFalke) faf666f Remove Windows 32 bit build (MarcoFalke) Pull request description: The Windows 32 bit build has been removed from https://bitcoincore.org/en/download/, so unless there are complaints, we don't need to build it even ACKs for commit fa193d: fanquake: utACK bitcoin@fa193dc Tree-SHA512: d6f2976a2e0c407698f720b00ac23ec4056626de4eff8621f4c5581120af0460afd1bdef72329cc0e7d92afca48d94ae5fce6777cb36bfabb60b8034ff08fd88

57b3c5b build_msvc: Drop 32-bit build configurations (Hennadii Stepanov) b3decea build_msvc: Make bitcoin-util ProjectGuid unique (Hennadii Stepanov) Pull request description: A 32-bit application for Windows in 2021 looks outdated. I'm pretty sure no one is going to run Bitcoin Core v23.0 on 32-bit Windows. Also see #15939. ACKs for top commit: sipsorcery: tACK 57b3c5b. Tree-SHA512: d03dccb7bab9f6694d008c4b1fdade1dbd7e5980b5199cc6648c1a8c0c66f07170ae9cb6a77b4ab54c9195003587051b94217b014f97c215dffeec2bcd8fcd6e

maflcko added Needs gitian build Build system labels May 2, 2019

luke-jr reviewed May 2, 2019

View reviewed changes

maflcko added this to the 0.19.0 milestone May 2, 2019

DrahtBot removed the Needs gitian build label May 3, 2019

maflcko added the Needs gitian build label May 3, 2019

Remove Windows 32 bit build

faf666f

maflcko force-pushed the 1904-GitianWin branch from faf0443 to faf666f Compare May 3, 2019 17:41

DrahtBot removed the Needs gitian build label May 6, 2019

bitcoin deleted a comment from DrahtBot May 6, 2019

doc: Remove win32 from the release process

fa193dc

maflcko added Needs gitian build and removed Needs gitian build labels May 8, 2019

luke-jr suggested changes May 8, 2019

View reviewed changes

laanwj merged commit fa193dc into bitcoin:master May 9, 2019

maflcko deleted the 1904-GitianWin branch May 9, 2019 19:24

practicalswift mentioned this pull request May 26, 2019

RFC: Improving testing under the remaining supported 32 bit platforms #16096

Closed

laanwj mentioned this pull request Nov 26, 2019

Add Support for x32-bit/x86 Windows Devices #17609

Closed

fanquake mentioned this pull request Jan 14, 2020

windows: Enable heap terminate-on-corruption #17916

Merged

furszy mentioned this pull request Feb 7, 2020

[Build] Remove Windows 32 bit build. PIVX-Project/PIVX#1324

Merged

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Jun 9, 2020

Partially revert part of bitcoin#15939 "Remove Windows 32 bit build"

16570d9

This partially reverts commit faf666f.

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Nov 17, 2020

Partially revert part of bitcoin#15939 "Remove Windows 32 bit build"

6b18f76

This partially reverts commit faf666f.

SomberNight mentioned this pull request Mar 7, 2021

consider building 64-bit Windows binaries (x64, x86_64, amd64, 64 bit, architecture) spesmilo/electrum#6598

Open

lyricidal mentioned this pull request Aug 18, 2021

[Build] Remove Windows 32 bit build. PRCYCoin/PRCYCoin#95

Merged

hebasto mentioned this pull request Sep 7, 2021

build: Drop 32-bit build configurations for MSVC #22908

Merged

bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021

gitian: Remove Windows 32 bit build #15939

gitian: Remove Windows 32 bit build #15939

Uh oh!

Conversation

maflcko commented May 2, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

practicalswift commented May 2, 2019

Uh oh!

laanwj commented May 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DrahtBot commented May 2, 2019

Conflicts

Uh oh!

achow101 commented May 2, 2019

Uh oh!

practicalswift commented May 3, 2019

Uh oh!

maflcko commented May 3, 2019

Uh oh!

fanquake commented May 6, 2019

Uh oh!

laanwj commented May 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luke-jr commented May 6, 2019

Uh oh!

DrahtBot commented May 6, 2019

Uh oh!

fanquake commented May 8, 2019

Uh oh!

maflcko commented May 8, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fanquake commented May 9, 2019

Uh oh!

laanwj commented May 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

laanwj commented May 2, 2019 •

edited

Loading

laanwj commented May 6, 2019 •

edited

Loading