rpc: Document iswitness flag and fix bug in converttopsbt #15899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maflcko
force-pushed
the
1904-docIsWitness
branch
2 times, most recently
from
fab96c9 to
fa8630d
Compare
Member
Author
|
review beg 🙏 @meshcollider As the author of the docstring, you seem qualified to review the doc change? |
Member
|
utACK fa8630d268dc65e097ead9962d9d8af2301182ca |
ryanofsky
approved these changes
May 16, 2019
Contributor
ryanofsky
left a comment
ryanofsky
left a comment
There was a problem hiding this comment.
utACK fa8630d268dc65e097ead9962d9d8af2301182ca
src/rpc/rawtransaction.cpp
Outdated
Contributor
There was a problem hiding this comment.
In commit "rpc: Document iswitness flag" (faee652f971e5422c4df1dff3f36c9089aaf587f)
Maybe drop this sentence and just use the same "If not present, If true..., If false..." text from converttopsbt. I think the converttopsbt explanation is a little clearer, and that it's better to keep the text consistent in all three methods so readers don't have to parse text closely to see where differences are.
Sipa's explanation and advice from the bug also seem very helpful and so might be worth incorporating too:
Member
Author
There was a problem hiding this comment.
Force pushed to use the same docstring everywhere
maflcko
force-pushed
the
1904-docIsWitness
branch
2 times, most recently
from
fa5a72d to
faa568a
Compare
Also explain the param in all RPCs
maflcko
force-pushed
the
1904-docIsWitness
branch
from
faa568a to
fa499b5
Compare
Member
Author
|
Anything left to do here? |
Contributor
|
utACK fa499b5 |
meshcollider
added a commit
that referenced
this pull request
Jun 18, 2019
fa499b5 rpc: bugfix: Properly use iswitness in converttopsbt (MarcoFalke) fa5c5cd rpc: Switch touched RPCs to IsValidNumArgs (MarcoFalke) Pull request description: When a serialized transaction has inputs, there is no risk in only trying to deserialize it with witness allowed. (This is how all transactions from p2p are deserialized.) In fact, it would avoid a common issue where a transaction with inputs can be deserialized in two ways: * Fixes #12989 * Fixes #15872 * Fixes #15701 * Fixes #13738 * ... When a serialized transaction has no inputs, there is no risk in only trying to deserialze it with witness disallowed. (A transaction without inputs can't have corresponding witness data) ACKs for commit fa499b: meshcollider: utACK fa499b5 ryanofsky: utACK fa499b5. Changes since last review: consolidating commits and making iswitness documentation the same across methods. PastaPastaPasta: utACK fa499b5 Tree-SHA512: a64423a3131f3f0222a40da557c8b590c9ff01b45bcd40796f77a1a64ae74c6680a6be9d01ece95c492dfbcc7e2810409d2c2b336c2894af00bb213972fc85c6
Merged
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jun 18, 2019
Github-Pull: bitcoin#15899 Rebased-From: fa5c5cd
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Jun 18, 2019
Also explain the param in all RPCs Github-Pull: bitcoin#15899 Rebased-From: fa499b5
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jun 19, 2019
…erttopsbt fa499b5 rpc: bugfix: Properly use iswitness in converttopsbt (MarcoFalke) fa5c5cd rpc: Switch touched RPCs to IsValidNumArgs (MarcoFalke) Pull request description: When a serialized transaction has inputs, there is no risk in only trying to deserialize it with witness allowed. (This is how all transactions from p2p are deserialized.) In fact, it would avoid a common issue where a transaction with inputs can be deserialized in two ways: * Fixes bitcoin#12989 * Fixes bitcoin#15872 * Fixes bitcoin#15701 * Fixes bitcoin#13738 * ... When a serialized transaction has no inputs, there is no risk in only trying to deserialze it with witness disallowed. (A transaction without inputs can't have corresponding witness data) ACKs for commit fa499b: meshcollider: utACK bitcoin@fa499b5 ryanofsky: utACK fa499b5. Changes since last review: consolidating commits and making iswitness documentation the same across methods. PastaPastaPasta: utACK fa499b5 Tree-SHA512: a64423a3131f3f0222a40da557c8b590c9ff01b45bcd40796f77a1a64ae74c6680a6be9d01ece95c492dfbcc7e2810409d2c2b336c2894af00bb213972fc85c6
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 23, 2019
Github-Pull: bitcoin#15899 Rebased-From: fa5c5cd
HashUnlimited
pushed a commit
to HashUnlimited/chaincoin
that referenced
this pull request
Aug 23, 2019
Also explain the param in all RPCs Github-Pull: bitcoin#15899 Rebased-From: fa499b5
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Aug 24, 2019
Github-Pull: bitcoin#15899 Rebased-From: fa5c5cd
Bushstar
pushed a commit
to Bushstar/omnicore
that referenced
this pull request
Aug 24, 2019
Also explain the param in all RPCs Github-Pull: bitcoin#15899 Rebased-From: fa499b5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a serialized transaction has inputs, there is no risk in only trying to deserialize it with witness allowed. (This is how all transactions from p2p are deserialized.) In fact, it would avoid a common issue where a transaction with inputs can be deserialized in two ways:
When a serialized transaction has no inputs, there is no risk in only trying to deserialze it with witness disallowed. (A transaction without inputs can't have corresponding witness data)